staging: rtl8723bs: remove CamelCase variable bAllow
PATCH 1/1 staging: rtl8723bs: remove CamelCase variable bAllow
Fix a checkpatch.pl warning regarding CamelCase naming conventions. Change the variable 'bAllow' to 'allow' in rtw_cmd_filter() to conform with standard Linux kernel coding styles.
Signed-off-by Oliver Burns <[email protected]>
--- drivers/staging/rtl8723bs/core/rtw_cmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +3 -3
@@ -299,12 +299,12 @@ void rtw_free_cmd_priv(struct cmd_priv *pcmdpriv)int rtw_cmd_filter (struct cmd_priv *pcmdpriv,struct cmd_obj *cmd_obj);int rtw_cmd_filter (struct cmd_priv *pcmdpriv,struct cmd_obj *cmd_obj) { -u8 bAllow = false;/* set to true to allow enqueuing cmd when hw_init_completed is false */ +u8 allow = false;/* set to true to allow enqueuing cmd when hw_init_completed is false */ if (cmd_obj->cmdcode ==GEN_CMD_CODE (_SetChannelPlan)) - bAllow = true; + allow = true; -if ((!pcmdpriv->padapter->hw_init_completed && !bAllow) || +if ((!pcmdpriv->padapter->hw_init_completed && !allow) || !atomic_read (&pcmdpriv->cmdthd_running))/* com_thread not running */ return _FAIL;
Signature · 1 line
2.55.0
Greg KH
maintainerQuoted 14 lines · Oliver Burns
Fix a checkpatch.pl warning regarding CamelCase naming conventions. Change the variable 'bAllow' to 'allow' in
rtw_cmd_filter()to conform with standard Linux kernel coding styles.Signed-off-by Oliver Burns <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_cmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/rtl8723bs/core/rtw_cmd.c +0
-0
drivers/staging/rtl8723bs/core/rtw_cmd.c void rtw_free_cmd_priv(struct cmd_priv *pcmdpriv) · line 302
Quoted 5 lines
drivers/staging/rtl8723bs/core/rtw_cmd.c +1
-1@@ -299,12 +299,12 @@ void rtw_free_cmd_priv(struct cmd_priv *pcmdpriv)int rtw_cmd_filter (struct cmd_priv *pcmdpriv,struct cmd_obj *cmd_obj);int rtw_cmd_filter (struct cmd_priv *pcmdpriv,struct cmd_obj *cmd_obj) { -u8 bAllow = false;/* set to true to allow enqueuing cmd when hw_init_completed is false */ +u8 allow = false;/* set to true to allow enqueuing cmd when hw_init_completed is false */
Shouldn't this now be a 'bool'?
thanks,
greg k-h