Skip to contentSkip to conversation

Doc: process: Getting rid of OProfile url enlisting

PATCH In review Bhaskar Chowdhury 4 participants 4 messages Aug 15 – Aug 16

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Doc: process: Getting rid of OProfile url enlisting

Aren't we done with this damn tool from a kernel perspective?? Thought,the link could be removed.

---
 Documentation/process/changes.rst | 4 ----
 1 file changed, 4 deletions(-)
Documentation/process/changes.rst +0 -4
index 0aa232b117b5..336c07190c9b 100644
@@ -556,10 +556,6 @@ Ip-route2
 
 - <https://www.kernel.org/pub/linux/utils/net/iproute2/>
 
-OProfile
---------
-
-- <https://oprofile.sf.net/download/>
 
 Kernel documentation
 ********************

--
2.54.0

#1 lore raw
Quoted 2 lines · Bhaskar Chowdhury

Aren't we done with this damn tool from a kernel perspective?? Thought,the link could be removed.

Maybe you'd like to use more polite wording in this commit message.

#2 lore raw
In reply to Bhaskar Chowdhury
Quoted 2 lines · Bhaskar Chowdhury

Aren't we done with this damn tool from a kernel perspective?? Thought,the link could be removed.

This would finalize (fix?) this commit 8e9fa2f21151 (oprofiled version output line removed from the list)

Maybe add some reasoning (To reduce it's OS jitter or because it's a leftover link)

And if it's the way to handle translations remove:
Documentation/translations/it_IT/process/changes.rst:- <https://oprofile.sf.net/download/>
Documentation/translations/pt_BR/process/changes.rst:- <https://oprofile.sf.net/download/>

I have no clue about the technical side, that's why I'm asking:
Can this be removed aswell?
arch/sparc/kernel/nmi.c:atomic_t nmi_active = ATOMIC_INIT(0); /* oprofile uses this */

Thanks
Manuel

Quoted 24 lines

---
 Documentation/process/changes.rst | 4 ----

 1 file changed, 4 deletions(-)
Documentation/process/changes.rst +0 -0
index 0aa232b117b5..336c07190c9b 100644
@@ -556,10 +556,6 @@ Ip-route2
 

 - <https://www.kernel.org/pub/linux/utils/net/iproute2/>

Documentation/process/changes.rst +0 -4
-OProfile
---------
-
-- <https://oprofile.sf.net/download/>

 Kernel documentation
 ********************
--
2.54.0

reviewer
#3 lore raw
Quoted 9 lines · Manuel Ebner
Quoted 2 lines · Bhaskar Chowdhury

Aren't we done with this damn tool from a kernel perspective?? Thought,the link could be removed.

This would finalize (fix?) this commit 8e9fa2f21151 (oprofiled version output line removed from the list)

Maybe add some reasoning (To reduce it's OS jitter or because it's a leftover link)

Quoted 7 lines

And if it's the way to handle translations remove:
Documentation/translations/it_IT/process/changes.rst:- <https://oprofile.sf.net/download/>
Documentation/translations/pt_BR/process/changes.rst:- <https://oprofile.sf.net/download/>

I have no clue about the technical side, that's why I'm asking:
Can this be removed aswell?
arch/sparc/kernel/nmi.c:atomic_t nmi_active = ATOMIC_INIT(0); /* oprofile uses this */

It looks like nmi_active is used in that source file regardless of oprofile. I'd say No.
Other than the comment itself, which can be deleted if oprofile support is going (gone) away.

Quoted 24 lines
Quoted 23 lines

---
 Documentation/process/changes.rst | 4 ----

 1 file changed, 4 deletions(-)
Documentation/process/changes.rst +0 -0
index 0aa232b117b5..336c07190c9b 100644
@@ -556,10 +556,6 @@ Ip-route2
 

 - <https://www.kernel.org/pub/linux/utils/net/iproute2/>

Documentation/process/changes.rst +0 -4
-OProfile
---------
-
-- <https://oprofile.sf.net/download/>

 Kernel documentation
 ********************
--
2.54.0

Signature · 1 line
~Randy