Add SM7250 base dts file
v2 cover Add SM7250 base dts file
Qualcomm SM7250 is known as lito.
This patchset add base devicetree file for SM7250 SoC and SM7250 MTP platform. This file adds the basic nodes like cpu, psci and other required configuration for booting up to the serial console.
v2 - Fixes/Changes:
#1 [Fix] The timer@17c20000 node incorrectly configures #address-cells and #size-cells, leading to broken memory mappings. #2 [Fix] The spmi@c440000 bus node incorrectly sets #address-cells and #size-cells, breaking SPMI device enumeration. #3 [Fix] Missing mandatory properties cache-level and cache-unified in L2 and L3 cache nodes.
#4 [Fix] The CPU topology cpu-map is entirely missing, breaking cluster-awareness and Energy Aware Scheduling. #5 [Fix] The SPMI node name qcom,spmi@c440000 violates the standard generic node naming requirements.
#6 [Fix] The memory-mapped tcsr_mutex is placed at the root of the device tree rather than within the soc simple-bus node.
Sreeshankar K (5):
arm64: dts: qcom: Add SM7250 base dts file
dt-bindings: arm: cpus: Document Kryo 475 CPUs
dt-bindings: arm: qcom: Document SM7250 SoC and boards
dt-bindings: firmware: qcom,scm: Document SM7250 SCM
dt-bindings: interrupt-controller: qcom,pdc: Document SM7250 PDC
.../devicetree/bindings/arm/cpus.yaml | 1 + .../devicetree/bindings/arm/qcom.yaml | 6 + .../bindings/firmware/qcom,scm.yaml | 1 + .../interrupt-controller/qcom,pdc.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/sm7250-mtp.dts | 30 ++ arch/arm64/boot/dts/qcom/sm7250.dtsi | 499 ++++++++++++++++++ 7 files changed, 539 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm7250-mtp.dts create mode 100644 arch/arm64/boot/dts/qcom/sm7250.dtsi
Signature · 1 line
2.43.0
PATCH v2 1/5 arm64: dts: qcom: Add SM7250 base dts file
Add devicetree file for SM7250 SoC and SM7250 MTP platform. This file adds the basic nodes like cpu, psci and other required configuration for booting up to the serial console.
--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/sm7250-mtp.dts | 30 ++ arch/arm64/boot/dts/qcom/sm7250.dtsi | 499 ++++++++++++++++++++++++ 3 files changed, 530 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm7250-mtp.dts create mode 100644 arch/arm64/boot/dts/qcom/sm7250.dtsi
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -347,6 +347,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm6375-sony-xperia-murray-pdx225.dtb dtb-$(CONFIG_ARCH_QCOM) += sm7125-xiaomi-curtana.dtb dtb-$(CONFIG_ARCH_QCOM) += sm7125-xiaomi-joyeuse.dtb dtb-$(CONFIG_ARCH_QCOM) += sm7225-fairphone-fp4.dtb +dtb-$(CONFIG_ARCH_QCOM) += sm7250-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm7325-motorola-dubai.dtb dtb-$(CONFIG_ARCH_QCOM) += sm7325-nothing-spacewar.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8150-hdk.dtb
arch/arm64/boot/dts/qcom/sm7250-mtp.dts new file +30 -0
@@ -0,0 +1,30 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) 2020, The Linux Foundation. All rights reserved. + * Copyright (c) 2026, Sreeshankar K <[email protected]> + */ + +/dts-v1/; + +#include "sm7250.dtsi" + +/ { + model = "Qualcomm Technologies, Inc. SM7250 MTP"; + compatible = "qcom,sm7250-mtp", "qcom,sm7250"; + + aliases { + serial0 = &uart2; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; +}; + +&qupv3_id_1 { + status = "okay"; +}; + +&uart2 { + status = "okay"; +};
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +499 -0
499 lines not on this page · raw message
Signature · 1 line
2.43.0
[email protected]
AI reviewRe: [PATCH v2 1/5] arm64: dts: qcom: Add SM7250 base dts file
Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider: - [High] The `cpu-map` cluster definitions use non-zero starting indices (`core6`, `core7`), breaking Linux…
Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [High] The cpu-map cluster definitions use non-zero starting indices (core6, core7), breaking Linux topology parsing.
- [High] Mismatched QUPv3 wrapper addresses and clocks.
- [Low] Missing devicetree bindings header for the clock controller.
- [Low] Invalid GIC_CPU_MASK_SIMPLE usage in GICv3 interrupt specifier.
--
--- Patch [1]: [PATCH v2 1/5] arm64: dts: qcom: Add SM7250 base dts file --- commit f9be33ec0cc19ce8ffedcebd3293f880830f4c83
Author: Sreeshankar K <[email protected]>
arm64: dts: qcom: Add SM7250 base dts file
Add devicetree file for SM7250 SoC and SM7250 MTP platform. This file adds the basic nodes like cpu, psci and other required configuration for booting up to the serial console.
arch/arm64/boot/dts/qcom/sm7250.dtsi line 8
Quoted 11 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +8
-0@@ -0,0 +1,499 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) 2020, The Linux Foundation. All rights reserved. + * Copyright (c) 2026, Sreeshankar K <[email protected]> + */ + +#include <dt-bindings/clock/qcom,rpmh.h> +#include <dt-bindings/clock/qcom,gcc-sm7250.h>
[Severity: Low]
Does this file exist in the source tree? A missing devicetree bindings header will cause a preprocessor error during compilation and break the build.
[ ... ]
Quoted 5 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +5
-0+ cpu-map { + cluster0 { + core0 { + cpu = <&cpu0>; + };
[ ... ]
Quoted 4 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +4
-0+ }; + + cluster1 { + core6 {
arch/arm64/boot/dts/qcom/sm7250.dtsi line 200
Quoted 10 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +10
-0+ cpu = <&cpu6>; + }; + }; + + cluster2 { + core7 { + cpu = <&cpu7>; + }; + }; + };
[Severity: High]
Will this topology be parsed correctly by the kernel?
Looking at parse_cluster() in drivers/base/arch_topology.c, the kernel iterates over cluster cores looking for child nodes named core%d starting strictly at index 0. Because cluster1 and cluster2 start at core6 and core7, it seems the parser will fail to find core0, break out of the loop instantly, and completely ignore the remaining cores which will degrade scheduling behavior and performance.
[ ... ]
arch/arm64/boot/dts/qcom/sm7250.dtsi line 345
Quoted 6 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +6
-0+ qupv3_id_1: geniqup@9c0000 { + compatible = "qcom,geni-se-qup"; + reg = <0x0 0x009c0000 0x0 0x6000>; + clock-names = "m-ahb", "s-ahb"; + clocks = <&gcc GCC_QUPV3_WRAP_1_M_AHB_CLK>, + <&gcc GCC_QUPV3_WRAP_1_S_AHB_CLK>;
[Severity: High]
Are these clocks correct for this QUP base address?
The base address 0x9c0000 physically corresponds to QUP0, but the clocks requested here belong to QUP1 (GCC_QUPV3_WRAP_1_M_AHB_CLK). During driver initialization, won't the driver enable QUP1 clocks and then attempt to read or write registers belonging to QUP0, triggering a synchronous external abort and kernel panic due to accessing an unclocked AMBA peripheral?
[ ... ]
arch/arm64/boot/dts/qcom/sm7250.dtsi line 493
Quoted 6 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +6
-0+ timer { + compatible = "arm,armv8-timer"; + interrupts = <GIC_PPI 1 + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 2 + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
[Severity: Low]
Does this comply with the GICv3 devicetree bindings?
The schema for arm,gic-v3.yaml requires the third cell of a GICv3 interrupt specifier to only contain trigger type and level flags in bits [3:0]. GIC_CPU_MASK_SIMPLE is a GICv2 legacy macro that sets bits [15:8], which causes dtbs_check validation failures.
Quoted 6 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +6
-0+ <GIC_PPI 3 + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 0 + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>; + }; +};
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Re: [PATCH v2 1/5] arm64: dts: qcom: Add SM7250 base dts file
In reply to Sreeshankar KQuoted 31 lines · Sreeshankar K
Add devicetree file for SM7250 SoC and SM7250 MTP platform. This file adds the basic nodes like cpu, psci and other required configuration for booting up to the serial console.
Signed-off-by Sreeshankar K <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/sm7250-mtp.dts | 30 ++ arch/arm64/boot/dts/qcom/sm7250.dtsi | 499 ++++++++++++++++++++++++ 3 files changed, 530 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm7250-mtp.dts create mode 100644 arch/arm64/boot/dts/qcom/sm7250.dtsiarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -347,6 +347,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm6375-sony-xperia-murray-pdx225.dtb dtb-$(CONFIG_ARCH_QCOM) += sm7125-xiaomi-curtana.dtb dtb-$(CONFIG_ARCH_QCOM) += sm7125-xiaomi-joyeuse.dtb dtb-$(CONFIG_ARCH_QCOM) += sm7225-fairphone-fp4.dtb +dtb-$(CONFIG_ARCH_QCOM) += sm7250-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm7325-motorola-dubai.dtb dtb-$(CONFIG_ARCH_QCOM) += sm7325-nothing-spacewar.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8150-hdk.dtbarch/arm64/boot/dts/qcom/sm7250-mtp.dts new file +0
-0
arch/arm64/boot/dts/qcom/sm7250-mtp.dts line 9
Quoted 9 lines
arch/arm64/boot/dts/qcom/sm7250-mtp.dts new file +9
-0@@ -0,0 +1,30 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) 2020, The Linux Foundation. All rights reserved. + * Copyright (c) 2026, Sreeshankar K <[email protected]> + */ + +/dts-v1/; + +#include "sm7250.dtsi"
If you have declared SPMI node, you can include PMIC files here.
Quoted 46 lines
arch/arm64/boot/dts/qcom/sm7250-mtp.dts new file +21
-0+ +/ { + model = "Qualcomm Technologies, Inc. SM7250 MTP"; + compatible = "qcom,sm7250-mtp", "qcom,sm7250"; + + aliases { + serial0 = &uart2; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; +}; + +&qupv3_id_1 { + status = "okay"; +}; + +&uart2 { + status = "okay"; +};arch/arm64/boot/dts/qcom/sm7250.dtsi new file +19
-0@@ -0,0 +1,499 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) 2020, The Linux Foundation. All rights reserved. + * Copyright (c) 2026, Sreeshankar K <[email protected]> + */ + +#include <dt-bindings/clock/qcom,rpmh.h> +#include <dt-bindings/clock/qcom,gcc-sm7250.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/soc/qcom,rpmh-rsc.h> + +/ { + interrupt-parent = <&intc>; + #address-cells = <2>; + #size-cells = <2>; + + clocks { + xo_board: xo-board { + compatible = "fixed-clock";
arch/arm64/boot/dts/qcom/sm7250.dtsi line 29
Quoted 10 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +10
-0+ #clock-cells = <0>; + clock-frequency = <38400000>; + clock-output-names = "xo_board"; + }; + + sleep_clk: sleep-clk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32000>; + };
Please move these clocks to the board DT. You an keep referencing them from the DTSI (see for example, sm8750.dtsi).
arch/arm64/boot/dts/qcom/sm7250.dtsi line 42
Quoted 13 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +13
-0+ }; + + cpus { + #address-cells = <2>; + #size-cells = <0>; + + cpu0: cpu@0 { + device_type = "cpu"; + compatible = "qcom,kryo475"; + reg = <0x0 0x0>; + enable-method = "psci"; + next-level-cache = <&l2_0>; + l2_0: l2-cache {
empty lines between each subnode (here and further).
Quoted 14 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +14
-0+ compatible = "cache"; + cache-level = <2>; + cache-size = <0x20000>; + cache-unified; + next-level-cache = <&l3_0>; + l3_0: l3-cache { + compatible = "cache"; + cache-level = <3>; + cache-size = <0x200000>; + cache-unified; + }; + }; + }; +
[..]
arch/arm64/boot/dts/qcom/sm7250.dtsi line 231
Quoted 7 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +7
-0+ + reserved_memory: reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + hyp_mem: memory@80000000 {
Don't use just memory@. Add more descriptive node names (again, sm8750.dtsi).
Quoted 72 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +72
-0+ reg = <0x0 0x80000000 0x0 0x600000>; + no-map; + }; + + xbl_aop_mem: memory@80700000 { + reg = <0x0 0x80700000 0x0 0x160000>; + no-map; + }; + + cmd_db: memory@80860000 { + compatible = "qcom,cmd-db"; + reg = <0x0 0x80860000 0x0 0x20000>; + no-map; + }; + + smem_mem: memory@80900000 { + reg = <0x0 0x80900000 0x0 0x200000>; + no-map; + }; + + removed_mem: memory@80b00000 { + reg = <0x0 0x80b00000 0x0 0x1300000>; + no-map; + }; + + camera_mem: memory@86000000 { + reg = <0x0 0x86000000 0x0 0x500000>; + no-map; + }; + + gpu_mem: memory@8bc15400 { + reg = <0x0 0x8bc15400 0x0 0x2000>; + no-map; + }; + + npu_mem: memory@86500000 { + reg = <0x0 0x86500000 0x0 0x500000>; + no-map; + }; + + video_mem: memory@86a00000 { + reg = <0x0 0x86a00000 0x0 0x500000>; + no-map; + }; + + wlan_mem: memory@8ba00000 { + reg = <0x0 0x8ba00000 0x0 0x200000>; + no-map; + }; + + ipa_fw_mem: memory@8bc00000 { + reg = <0x0 0x8bc00000 0x0 0x10000>; + no-map; + }; + + ipa_gsi_mem: memory@8bc10000 { + reg = <0x0 0x8bc10000 0x0 0x5400>; + no-map; + }; + + cdsp_mem: memory@87400000 { + reg = <0x0 0x87400000 0x0 0x1e00000>; + no-map; + }; + + adsp_mem: memory@89200000 { + reg = <0x0 0x89200000 0x0 0x2800000>; + no-map; + }; + + modem_mem: memory@8c000000 { + reg = <0x0 0x8c000000 0x0 0xf800000>;
arch/arm64/boot/dts/qcom/sm7250.dtsi line 313
Quoted 10 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +10
-0+ no-map; + }; + + cdsp_sec_mem: memory@9f400000 { + reg = <0x0 0x9f400000 0x0 0xc00000>; + no-map; + }; + }; + + smem: qcom,smem {
Don't use qcom, in node names. the label is unused. Also you can just move it to the reserved-memory and drop memory-region.
Quoted 4 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +4
-0+ compatible = "qcom,smem"; + memory-region = <&smem_mem>; + hwlocks = <&tcsr_mutex 3>; + };
arch/arm64/boot/dts/qcom/sm7250.dtsi line 327
Quoted 10 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +10
-0+ + soc: soc@0 { + #address-cells = <2>; + #size-cells = <2>; + ranges = <0 0 0 0 0x10 0>; + dma-ranges = <0 0 0 0 0x10 0>; + compatible = "simple-bus"; + + gcc: clock-controller@100000 { + compatible = "qcom,gcc-sm7250";
qcom,sm7250-gcc. Where are the bindings, BTW?
Quoted 15 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +15
-0+ reg = <0x0 0x00100000 0x0 0x1f0000>; + #clock-cells = <1>; + #reset-cells = <1>; + #power-domain-cells = <1>; + clock-names = "bi_tcxo", + "bi_tcxo_ao", + "sleep_clk"; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&rpmhcc RPMH_CXO_CLK_A>, + <&sleep_clk>; + }; + + qupv3_id_1: geniqup@9c0000 { + compatible = "qcom,geni-se-qup"; + reg = <0x0 0x009c0000 0x0 0x6000>;
arch/arm64/boot/dts/qcom/sm7250.dtsi line 352
Quoted 10 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +10
-0+ clock-names = "m-ahb", "s-ahb"; + clocks = <&gcc GCC_QUPV3_WRAP_1_M_AHB_CLK>, + <&gcc GCC_QUPV3_WRAP_1_S_AHB_CLK>; + #address-cells = <2>; + #size-cells = <2>; + ranges; + status = "disabled"; + + uart2: serial@988000 { + compatible = "qcom,geni-debug-uart";
Wring indentation.
Quoted 37 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +37
-0+ reg = <0 0x00988000 0 0x4000>; + clock-names = "se"; + clocks = <&gcc GCC_QUPV3_WRAP1_S2_CLK>; + interrupts = <GIC_SPI 355 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + }; + + intc: interrupt-controller@17a00000 { + compatible = "arm,gic-v3"; + reg = <0x0 0x17a00000 0x0 0x10000>, /* GICD */ + <0x0 0x17a60000 0x0 0x100000>; /* GICR * 8 */ + #interrupt-cells = <3>; + interrupt-controller; + interrupts = <GIC_PPI 8 IRQ_TYPE_LEVEL_HIGH>; + }; + + pdc: interrupt-controller@b220000 { + compatible = "qcom,sm7250-pdc", "qcom,pdc"; + reg = <0 0xb220000 0 0x30000>, <0 0x17c000f0 0 0x60>; + qcom,pdc-ranges = <0 480 42>, <42 612 28>, + <70 63 1>, <71 640 15>, <86 522 52>; + #interrupt-cells = <2>; + interrupt-parent = <&intc>; + interrupt-controller; + }; + + spmi_bus: spmi@c440000 { + compatible = "qcom,spmi-pmic-arb"; + reg = <0x0 0x0c440000 0x0 0x0001100>, + <0x0 0x0c600000 0x0 0x2000000>, + <0x0 0x0e600000 0x0 0x0100000>, + <0x0 0x0e700000 0x0 0x00a0000>, + <0x0 0x0c40a000 0x0 0x0026000>; + reg-names = "core", "chnls", "obsrvr", "intr", "cnfg"; + interrupt-names = "periph_irq"; + interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
arch/arm64/boot/dts/qcom/sm7250.dtsi line 399
Quoted 10 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +10
-0+ qcom,ee = <0>; + qcom,channel = <0>; + #address-cells = <2>; + #size-cells = <0>; + interrupt-controller; + #interrupt-cells = <4>; + }; + + apps_rsc: rsc@18200000 { + label = "apps_rsc";
Move label further down. The typical order is: compatible, reg+reg-names, then everything else.
Quoted 5 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +5
-0+ compatible = "qcom,rpmh-rsc"; + reg = <0x0 0x18200000 0x0 0x10000>, + <0x0 0x18210000 0x0 0x10000>, + <0x0 0x18220000 0x0 0x10000>; + reg-names = "drv-0", "drv-1", "drv-2";
arch/arm64/boot/dts/qcom/sm7250.dtsi line 414
Quoted 10 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +10
-0+ interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; + qcom,tcs-offset = <0xd00>; + qcom,drv-id = <2>; + qcom,tcs-config = <ACTIVE_TCS 2>, <SLEEP_TCS 3>, + <WAKE_TCS 3>, <CONTROL_TCS 1>; + + rpmhcc: clock-controller { + compatible = "qcom,sm7250-rpmh-clk";
Missing schema and a driver update.
arch/arm64/boot/dts/qcom/sm7250.dtsi line 418
Quoted 4 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +4
-0+ #clock-cells = <1>; + clock-names = "xo"; + clocks = <&xo_board>; + };
While you are at it, please add rpmhpd here. Most likely gcc needs to use RPMHPD_CX as as power-domain.
Quoted 2 lines
arch/arm64/boot/dts/qcom/sm7250.dtsi new file +2
-0+ }; +
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH v2 1/5] arm64: dts: qcom: Add SM7250 base dts file
In reply to Sreeshankar KQuoted 1 line · Sreeshankar K
Add devicetree file for SM7250 SoC and SM7250 MTP platform.
How did you get an MTP? AFAIK, MTPs are available only via official distribution channels to partners.
I am asking because if you do not have MTP, I see no point in taking DTS for it. I would even say that if only you have MTP, it is still not really useful DTS, because no one else has (except Qualcomm).
Best regards,
Krzysztof
PATCH v2 2/5 dt-bindings: arm: cpus: Document Kryo 475 CPUs
In reply to Sreeshankar KDocument Kryo 475 CPUs found in Qualcomm SM7250 SoC.
--- Documentation/devicetree/bindings/arm/cpus.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/cpus.yaml +1 -0
@@ -212,6 +212,7 @@ properties: - qcom,kryo465 - qcom,kryo468 - qcom,kryo470 + - qcom,kryo475 - qcom,kryo485 - qcom,kryo560 - qcom,kryo570
Signature · 1 line
2.43.0
PATCH v2 3/5 dt-bindings: arm: qcom: Document SM7250 SoC and boards
In reply to Sreeshankar KDocument the Qualcomm SM7250 SoC binding and the MTP board.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +6 -0
@@ -1050,6 +1050,11 @@ properties: - fairphone,fp4 - const: qcom,sm7225 + - items: + - enum: + - qcom,sm7250-mtp + - const: qcom,sm7250 + - items: - enum: - motorola,dubai
@@ -1306,6 +1311,7 @@ allOf: - qcom,sm6350 - qcom,sm7125 - qcom,sm7225 + - qcom,sm7250 - qcom,sm8150 - qcom,sm8250 then:
Signature · 1 line
2.43.0
Re: [PATCH v2 3/5] dt-bindings: arm: qcom: Document SM7250 SoC and boards
Quoted 6 lines · Sreeshankar K
Document the Qualcomm SM7250 SoC binding and the MTP board.
Signed-off-by Sreeshankar K <[email protected]>--- Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ 1 file changed, 6 insertions(+)
Where is the SoC ID?
Quoted 18 lines
Documentation/devicetree/bindings/arm/qcom.yaml +5
-0@@ -1050,6 +1050,11 @@ properties: - fairphone,fp4 - const: qcom,sm7225 + - items: + - enum: + - qcom,sm7250-mtp + - const: qcom,sm7250 + - items: - enum: - motorola,dubai
Documentation/devicetree/bindings/arm/qcom.yaml allOf: · line 1314
Quoted 4 lines
Documentation/devicetree/bindings/arm/qcom.yaml +1
-0@@ -1306,6 +1311,7 @@ allOf: - qcom,sm6350 - qcom,sm7125 - qcom,sm7225 + - qcom,sm7250
No, list cannot grow.
Best regards,
Krzysztof
PATCH v2 4/5 dt-bindings: firmware: qcom,scm: Document SM7250 SCM
In reply to Sreeshankar KDocument the SCM compatible for Qualcomm SM7250 SoC.
--- Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/firmware/qcom,scm.yaml +1 -0
@@ -72,6 +72,7 @@ properties: - qcom,scm-sm6350 - qcom,scm-sm6375 - qcom,scm-sm7150 + - qcom,scm-sm7250 - qcom,scm-sm8150 - qcom,scm-sm8250 - qcom,scm-sm8350
Signature · 1 line
2.43.0
Re: [PATCH v2 4/5] dt-bindings: firmware: qcom,scm: Document SM7250 SCM
Quoted 6 lines · Sreeshankar K
Document the SCM compatible for Qualcomm SM7250 SoC.
Signed-off-by Sreeshankar K <[email protected]>--- Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 + 1 file changed, 1 insertion(+)
Best regards,
Krzysztof
PATCH v2 5/5 dt-bindings: interrupt-controller: qcom,pdc: Document SM7250 PDC
In reply to Sreeshankar KDocument the PDC block on the SM7250 SoC.
--- .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml +1 -0
@@ -50,6 +50,7 @@ properties: - qcom,sdx75-pdc - qcom,sm4450-pdc - qcom,sm6350-pdc + - qcom,sm7250-pdc - qcom,sm8150-pdc - qcom,sm8250-pdc - qcom,sm8350-pdc
Signature · 1 line
2.43.0
Re: [PATCH v2 5/5] dt-bindings: interrupt-controller: qcom,pdc: Document SM7250 PDC
Quoted 7 lines · Sreeshankar K
Document the PDC block on the SM7250 SoC.
Signed-off-by Sreeshankar K <[email protected]>--- .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 1 + 1 file changed, 1 insertion(+)
Please organize the patch documenting the compatible (DT bindings) before the patch using that compatible.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
Best regards,
Krzysztof