Skip to contentSkip to conversation

wifi: rtl8xxxu: Adjust logging pattern

PATCH In review rafad900 2 participants 2 messages Aug 16 – Aug 17 RTL8XXXU wireless driver (rtl8xxxu)

lore
Share & tools
lore

rafad900

author
#0 lore raw

PATCH 1/1 wifi: rtl8xxxu: Adjust logging pattern

To ensure consistent patterns, the device struct was defined and used when dev_warn() is called within rtl8188eu_rx_iqk_path_a().
This follows the logging pattern used by all the other functions defined in the file.

---
 drivers/net/wireless/realtek/rtl8xxxu/8188e.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/realtek/rtl8xxxu/8188e.c +2 -1
index fea5aec9ced9..4a64633b2da3 100644
@@ -643,6 +643,7 @@ static int rtl8188eu_iqk_path_a(struct rtl8xxxu_priv *priv)
 
 static int rtl8188eu_rx_iqk_path_a(struct rtl8xxxu_priv *priv)
 {
+	struct device *dev = &priv->udev->dev;
 	u32 reg_ea4, reg_eac, reg_e94, reg_e9c, val32;
 	int result = 0;
 
@@ -740,7 +741,7 @@ static int rtl8188eu_rx_iqk_path_a(struct rtl8xxxu_priv *priv)
 	    ((reg_eac & 0x03ff0000) != 0x00360000))
 		result |= 0x02;
 	else
-		dev_warn(&priv->udev->dev, "%s: Path A RX IQK failed!\n",
+		dev_warn(dev, "%s: Path A RX IQK failed!\n",
 			 __func__);
 
 out:
Signature · 1 line
2.43.0
#1 lore raw
Quoted 7 lines · rafad900 <[email protected]> wrote:

To ensure consistent patterns, the device struct was defined and used when dev_warn() is called within rtl8188eu_rx_iqk_path_a().
This follows the logging pattern used by all the other functions defined in the file.

Please use your real name.

The subject can explicitly point out that you are adjusting to use a local 'dev' variable for dev_warn().

Quoted 18 lines
---
 drivers/net/wireless/realtek/rtl8xxxu/8188e.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/realtek/rtl8xxxu/8188e.c +1 -0
index fea5aec9ced9..4a64633b2da3 100644
@@ -643,6 +643,7 @@ static int rtl8188eu_iqk_path_a(struct rtl8xxxu_priv *priv)
 
 static int rtl8188eu_rx_iqk_path_a(struct rtl8xxxu_priv *priv)
 {
+       struct device *dev = &priv->udev->dev;
        u32 reg_ea4, reg_eac, reg_e94, reg_e9c, val32;
        int result = 0;
 

drivers/net/wireless/realtek/rtl8xxxu/8188e.c static int rtl8188eu_rx_iqk_path_a(struct rtl8xxxu_priv *priv) · line 744

Quoted 5 lines
drivers/net/wireless/realtek/rtl8xxxu/8188e.c +1 -1
@@ -740,7 +741,7 @@ static int rtl8188eu_rx_iqk_path_a(struct rtl8xxxu_priv *priv)
            ((reg_eac & 0x03ff0000) != 0x00360000))
                result |= 0x02;
        else
-               dev_warn(&priv->udev->dev, "%s: Path A RX IQK failed!\n",
+               dev_warn(dev, "%s: Path A RX IQK failed!\n",

The counts of individual use case are:

$ git grep "dev_warn(&priv->udev->dev" drivers/net/wireless/realtek/rtl8xxxu/ | wc -l
19
$ git grep "dev_warn(dev" drivers/net/wireless/realtek/rtl8xxxu/ | wc -l
35

If it is worth to do, please convert all of them.

Quoted 6 lines
drivers/net/wireless/realtek/rtl8xxxu/8188e.c +0 -1
                         __func__);
 
 out:
--

2.43.0