soc: qcom: smem: Fix signedness bug
Subsystems (2)
PATCH 1/1 soc: qcom: smem: Fix signedness bug
The function smem_dram_infer_struct_version() returns negative error codes and 'ver' is an enum, which makes subsequent condition (ver < 0) always impossible.
Fixes 1d234eeafc56a ("soc: qcom: smem: Expose DDR data from SMEM")
Signed-off-by Ethan Tidmore <[email protected]>
--- drivers/soc/qcom/smem_dramc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/qcom/smem_dramc.c +1 -1
@@ -371,10 +371,10 @@ DEFINE_SHOW_ATTRIBUTE(smem_hbb);struct dentry *smem_dram_parse (struct qcom_smem *smem,struct device *dev) {struct dentry *debugfs_dir; -enum ddr_info_version ver;struct smem_dram *dram;size_t actual_size;void *data; +int ver;/* No need to check qcom_smem_is_available(), this func is called by the SMEM driver */ data =__qcom_smem_get (smem,QCOM_SMEM_HOST_ANY ,SMEM_DDR_INFO_ID , &actual_size);
Signature · 3 lines
Thanks, ET https://github.com/sponsors/ethantidmore
Quoted 7 lines · Ethan Tidmore
The function
smem_dram_infer_struct_version()returns negative error codes and 'ver' is an enum, which makes subsequent condition (ver < 0) always impossible.Fixes 1d234eeafc56a ("soc: qcom: smem: Expose DDR data from SMEM")Signed-off-by Ethan Tidmore <[email protected]>---
We already got another fix for that:
https://lore.kernel.org/linux-arm-msm/[email protected]/
Konrad