ASoC: mediatek: mt7986: Drop redundant probe error messages
Subsystems (3)
PATCH 1/1 ASoC: mediatek: mt7986: Drop redundant probe error messages
From: bui duc phuc <[email protected]>
The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_err() calls are redundant and can be removed.
--- sound/soc/mediatek/mt7986/mt7986-afe-pcm.c | 8 ++++---- sound/soc/mediatek/mt7986/mt7986-dai-etdm.c | 2 +- sound/soc/mediatek/mt7986/mt7986-wm8960.c | 4 +--- 3 files changed, 6 insertions(+), 8 deletions(-)
sound/soc/mediatek/mt7986/mt7986-afe-pcm.c +4 -4
@@ -334,7 +334,7 @@ static int mt7986_init_clock(struct mtk_base_afe *afe) ret =devm_clk_bulk_get (afe->dev, afe_priv->num_clks, afe_priv->clks);if (ret) -return dev_err_probe (afe->dev, ret,"Failed to get clocks\n" ); +return ret;return 0 ; }
@@ -414,7 +414,7 @@ static int mt7986_afe_runtime_resume(struct device *dev) ret =clk_bulk_prepare_enable (afe_priv->num_clks, afe_priv->clks);if (ret) -return dev_err_probe (afe->dev, ret,"Failed to enable clocks\n" ); +return ret;if (!afe->regmap || afe_priv->pm_runtime_bypass_reg_ctl)return 0 ;
@@ -484,7 +484,7 @@ static int mt7986_afe_pcm_dev_probe(struct platform_device *pdev)/* initial audio related clock */ ret =mt7986_init_clock (afe);if (ret) -return dev_err_probe (dev, ret,"Cannot initialize clocks\n" ); +return ret; ret =devm_pm_runtime_enable (dev);if (ret)
@@ -535,7 +535,7 @@ static int mt7986_afe_pcm_dev_probe(struct platform_device *pdev) ret =devm_request_irq (dev, irq_id, mt7986_afe_irq_handler,IRQF_TRIGGER_NONE ,"asys-isr" , (void *)afe);if (ret) -return dev_err_probe (dev, ret,"Failed to request irq for asys-isr\n" ); +return ret;/* init sub_dais */ INIT_LIST_HEAD (&afe->sub_dais);
sound/soc/mediatek/mt7986/mt7986-dai-etdm.c +1 -1
@@ -124,7 +124,7 @@ static int mtk_dai_etdm_startup(struct snd_pcm_substream *substream, ret =clk_bulk_prepare_enable (afe_priv->num_clks, afe_priv->clks);if (ret) -return dev_err_probe (afe->dev, ret,"Failed to enable clocks\n" ); +return ret;regmap_update_bits (afe->regmap,AUDIO_TOP_CON2 ,CLK_OUT5_PDN_MASK ,0 );regmap_update_bits (afe->regmap,AUDIO_TOP_CON2 ,CLK_IN5_PDN_MASK ,0 );
sound/soc/mediatek/mt7986/mt7986-wm8960.c +1 -3
@@ -135,10 +135,8 @@ static int mt7986_wm8960_machine_probe(struct platform_device *pdev) } ret =snd_soc_of_parse_audio_routing (card,"audio-routing" ); -if (ret) { -dev_err (&pdev->dev,"Failed to parse audio-routing: %d\n" , ret); +if (ret) goto err_of_node_put; - } ret =devm_snd_soc_register_card (&pdev->dev, card);if (ret) {
Signature · 1 line
2.43.0
Mark Brown
maintainerQuoted 1 line · On Tue, 18 Aug 2026 17:45:26 +0700, [email protected] wrote:
ASoC: mediatek: mt7986: Drop redundant probe error messages
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.4
Thanks!
[1/1] ASoC: mediatek: mt7986: Drop redundant probe error messages
https://git.kernel.org/broonie/sound/c/bf71d5c64cd0
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark