HID: corsair-void: Fix firmware event packet description
PATCH RESEND 1/1 HID: corsair-void: Fix firmware event packet description
The size was incorrectly stated as 4 bytes since the ID was missed out. Add the ID in and correct the indices for the firmware versions.
--- drivers/hid/hid-corsair-void.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
drivers/hid/hid-corsair-void.c +9 -6
@@ -51,20 +51,23 @@/* Receiver report information: (ID 102) */ /* -------------------------------------------------------------------------- */ /* -* When queried, the recevier responds with 4 bytes to describe the firmware -* The first 2 bytes are for the receiver, the second 2 are the headset +* When queried, the receiver responds with 5 bytes to describe the firmware +* The first byte is the ID, then 2 bytes for the receiver, then 2 for the headset * The headset firmware version will be 0 if no headset is connected * -* 0: Recevier firmware major version +* 0: Report ID +* 102 for the firmware packet +* +* 1: Receiver firmware major version * Major version of the receiver's firmware * -* 1: Recevier firmware minor version +* 2: Receiver firmware minor version * Minor version of the receiver's firmware * -* 2: Headset firmware major version +* 3: Headset firmware major version * Major version of the headset's firmware * -* 3: Headset firmware minor version +* 4: Headset firmware minor version * Minor version of the headset's firmware */ /* -------------------------------------------------------------------------- */
Signature · 1 line
2.55.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [Medium] Missing report size validation in corsair_void_raw_event allows out-of-bounds read of the data array, leading to processing of uninitialized or stale data. --
--- Patch [1]: [PATCH RESEND] HID: corsair-void: Fix firmware event packet description --- commit 80e19492934a593a71b8da5c14d031065a2f1255
Author: Stuart Hayhurst <[email protected]>
HID: corsair-void: Fix firmware event packet description
This commit updates the firmware event packet description in the corsair-void driver. It corrects the size to 5 bytes to account for the report ID and updates the byte indices for the firmware version fields.
Quoted 4 lines
drivers/hid/hid-corsair-void.c +0
-0
[ ... ]
Quoted 5 lines
- * 3: Headset firmware minor version
+ * 4: Headset firmware minor version
* Minor version of the headset's firmware
*/
/* -------------------------------------------------------------------------- */
[Severity: Medium]
This is a pre-existing issue, but since the documentation correctly notes the receiver responds with 5 bytes, does the driver need to validate this size before parsing the packet?
In drivers/hid/hid-corsair-void.c:corsair_void_raw_event(), the data array is accessed up to index 4 without first validating the report size:
} else if (hid_report->id == CORSAIR_VOID_FIRMWARE_REPORT_ID) {
drvdata->fw_receiver_major = data[1];
drvdata->fw_receiver_minor = data[2];
drvdata->fw_headset_major = data[3];
drvdata->fw_headset_minor = data[4];
}If an untrusted or misbehaving USB device sends a short report where the size is less than 5, could this lead to an out-of-bounds read and cause the driver to process uninitialized or stale data from the HID core's input buffer?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 4 lines · Stuart Hayhurst
The size was incorrectly stated as 4 bytes since the ID was missed out. Add the ID in and correct the indices for the firmware versions.
Signed-off-by Stuart Hayhurst <[email protected]>
Applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs