Skip to contentSkip to conversation

scripts/mkcompile_h: Update LINUX_COMPILE_HOST command substitution syntax

PATCH In review Bhaskar Chowdhury 2 participants 2 messages Aug 18 – Sep 1 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 scripts/mkcompile_h: Update LINUX_COMPILE_HOST command substitution syntax

The assignment of LINUX_COMPILE_HOST uses the classic backtick style for its command substitution but the rest of the script uses the more common '$()'. Update LINUX_COMPILE_HOST to match for consistency.

---
Changes from V1:
Nathan suggested explicit statement should be given as commit log. Hence,the changes incorporated.

 scripts/mkcompile_h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/mkcompile_h +1 -1
index 2596f78e52ef..bf0d5669d9bc 100755
@@ -11,7 +11,7 @@ else
 	LINUX_COMPILE_BY=$KBUILD_BUILD_USER
 fi
 if test -z "$KBUILD_BUILD_HOST"; then
-	LINUX_COMPILE_HOST=`uname -n`
+	LINUX_COMPILE_HOST=$(uname -n)
 else
 	LINUX_COMPILE_HOST=$KBUILD_BUILD_HOST
 fi

--
2.54.0

#1 lore raw
Quoted 1 line · Bhaskar Chowdhury

scripts/mkcompile_h: Update LINUX_COMPILE_HOST command substitution syntax

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/kbuild/linux.git kbuild-next-unstable

Thanks!

[1/1] scripts/mkcompile_h: Update LINUX_COMPILE_HOST command substitution syntax

      https://git.kernel.org/kbuild/c/72c442e5bad35

Please look out for regression or issue reports or other follow up comments, as they may result in the patch/series getting dropped or reverted. Patches applied to an "unstable" branch are accepted pending wider testing in -next and any post-commit review; they will generally be moved to the main branch in a week if no issues are found.

Best regards,

Signature · 2 lines
Cheers,
Nathan