Input: synaptics - disable InterTouch on ThinkPad T440p (board id 2722)
Subsystems (2)
PATCH 1/1 Input: synaptics - disable InterTouch on ThinkPad T440p (board id 2722)
From: Raphaël Larocque <[email protected]>
The Lenovo ThinkPad T440p (PNP ID LEN0036, board id 2722) has a Synaptics touchpad whose SMBus companion is not ready at boot and takes ~200 s to appear. During this window the touchpad and pointer are completely unresponsive on approximately 50% of boots, making the machine unusable until the companion finally registers.
The device is in the topbuttonpad_pnp_ids[] SMBus allowlist, so the kernel attempts to use SMBus/RMI4 mode by default. When the companion is not ready, psmouse_smbus_init() leaves breadcrumbs and returns -EAGAIN, the PS/2 fallback path is taken, but the device does not function properly until the companion appears and RMI4 takes over.
Disable SMBus InterTouch for PNP ID LEN0036 with board id 2722 so the touchpad and TrackPoint work immediately via PS/2 from boot. Users can still force SMBus with psmouse.synaptics_intertouch=1 if needed.
--- drivers/input/mouse/synaptics.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/input/mouse/synaptics.c +10 -0
@@ -1837,6 +1837,16 @@ static int synaptics_setup_intertouch(struct psmouse *psmouse,return -ENXIO ; } + +/* Disable intertouch on known-broken board revisions */ +if (psmouse_matches_pnp_id (psmouse, + (const char *const []){"LEN0036" ,NULL }) && + info->board_id ==2722 ) { +psmouse_info (psmouse, +"Disabling intertouch for board id %d\n" , + info->board_id); +return -ENXIO ; + } }psmouse_info (psmouse,"Trying to set up SMBus access\n" );
Signature · 1 line
2.53.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Format string specifier mismatch in psmouse_info: using `%d` for `u32` variable. --
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Format string specifier mismatch in psmouse_info: using %d for u32 variable. --
--- Patch [1]: [PATCH] Input: synaptics - disable InterTouch on ThinkPad T440p (board id 2722) --- commit 4b10eb76fbd26fd6245ba466bd6e79e874e7afbb
Author: Raphaël Larocque <[email protected]>
Input: synaptics - disable InterTouch on ThinkPad T440p (board id 2722)
This commit disables SMBus InterTouch for the Lenovo ThinkPad T440p (PNP ID LEN0036, board id 2722) by default. This addresses an issue where the SMBus companion takes too long to appear at boot, causing the touchpad to become unresponsive.
Quoted 4 lines
drivers/input/mouse/synaptics.c +0
-0
[ ... ]
Quoted 1 line
drivers/input/mouse/synaptics.c +0
-0@@ -1838,6 +1838,16 @@ static int synaptics_setup_intertouch(struct psmouse *psmouse,
[ ... ]
drivers/input/mouse/synaptics.c static int synaptics_setup_intertouch(struct psmouse *psmouse, · line 1847
Quoted 7 lines
drivers/input/mouse/synaptics.c +7
-0+/* Disable intertouch on known-broken board revisions */ +if (psmouse_matches_pnp_id (psmouse, + (const char *const []){"LEN0036" ,NULL }) && + info->board_id ==2722 ) { +psmouse_info (psmouse, +"Disabling intertouch for board id %d\n" , + info->board_id);
[Severity: Low]
Since info->board_id is defined as a u32 (unsigned 32-bit integer) in struct synaptics_device_info, should this format specifier be %u instead of %d to avoid strict type warnings?
Quoted 3 lines
drivers/input/mouse/synaptics.c +2
-0+return -ENXIO ; + } }
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1