vfio/fsl-mc: prevent read-only region mappings from becoming writable
Subsystems (3)
PATCH 1/1 vfio/fsl-mc: prevent read-only region mappings from becoming writable
vfio_fsl_mc_mmap() rejects writable mappings of regions without the WRITE flag, but leaves VM_MAYWRITE set. Userspace can map such a region read-only and then upgrade the mapping to writable with mprotect(), writing to MMIO regions (e.g. response portals) the device marks read-only.
Clear VM_MAYWRITE for regions without the WRITE flag, as i915 does for its read-only objects and as fixed in drm/vc4 (CVE-2026-68445) and drm/panthor (CVE-2024-53071) and ptp: vmclock (commit a5edadbae57e2298a56cf7a4e774a027905a331f).
Fixes fb1ff4c194157 ("vfio/fsl-mc: Add VFIO framework skeleton for fsl-mc devices")
Signed-off-by Abdifatah Suruur <[email protected]>
---
drivers/vfio/fsl-mc/vfio_fsl_mc.c +4 -0
@@ -406,7 +406,11 @@if (!(vdev->regions[index].flags &VFIO_REGION_INFO_FLAG_WRITE ) && (vma->vm_flags &VM_WRITE ))return -EINVAL ; +/* Prevent read-only region mappings from being upgraded with mprotect() */ +if (!(vdev->regions[index].flags &VFIO_REGION_INFO_FLAG_WRITE )) +vm_flags_clear (vma,VM_MAYWRITE ); + vma->vm_private_data = mc_dev;return vfio_fsl_mc_mmap_mmio (vdev->regions[index], vma);
}