scsi: gdth: ensure event string is NUL-terminated
Subsystems (2)
PATCH 1/1 scsi: gdth: ensure event string is NUL-terminated
No upstream commit exists for this patch. GDT driver was removed from kernel in commit 0653c358d2dc ("scsi: Drop gdth driver").
For GDT_PCIMPR controllers, the driver copies up to 256 bytes from the controller event buffer and later handles the result as a C string.
If the firmware does not provide a NUL byte within the buffer, gdth_log_event() may read beyond event_string through printk() and sprintf().
Force the last byte of event_string to NUL after copying it from the controller. This preserves shorter strings and safely truncates an unterminated full-length event.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
--- drivers/scsi/gdth.c | 1 + 1 file changed, 1 insertion(+)
drivers/scsi/gdth.c +1 -0
@@ -2562,6 +2562,7 @@ static irqreturn_t __gdth_interrupt(gdth_ha_str *ha,if (ha->dvr.event_string[i] ==0 )break ; } + ha->dvr.event_string[255 ] =0 ; } }writeb (0xff , &dp6m_ptr->i960r.edoor_reg);
Signature · 1 line
2.43.0
Sasha Levin
maintainerQuoted 2 lines
No upstream commit exists for this patch. GDT driver was removed from kernel in commit
0653c358d2dc("scsi: Drop gdth driver").
[...]
Quoted 1 line
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Since this driver has been gone for the past few years, a maintainer ack will be appreciated before we pull this in.
Does anyone even care?
Signature · 2 lines
Thanks, Sasha