iio: proximity: srf04: fix error handling in srf04_probe()
Subsystems (2)
PATCH 1/1 iio: proximity: srf04: fix error handling in srf04_probe()
If pm_runtime_set_active() fails during srf04_probe(), iio_device_unregister() is called to cleanup, but the driver continues to execute pm_runtime_enable() and pm_runtime_idle() instead of aborting probe.
Fix this by returning 'ret' immediately inside the error path if pm_runtime_set_active() fails, preventing invalid runtime PM operations on an unregistered device.
--- drivers/iio/proximity/srf04.c | 1 + 1 file changed, 1 insertion(+)
drivers/iio/proximity/srf04.c +1 -0
@@ -330,6 +330,7 @@ static int srf04_probe(struct platform_device *pdev)if (ret) {dev_err (data->dev,"pm_runtime_set_active: %d\n" , ret);iio_device_unregister (indio_dev); +return ret; }pm_runtime_enable (data->dev);
Signature · 1 line
2.43.0
Jonathan Cameron
maintainerQuoted 11 lines · On Wed, 19 Aug 2026 20:03:17 +0100 Salah Triki <[email protected]> wrote:
If
pm_runtime_set_active()fails duringsrf04_probe(),iio_device_unregister()is called to cleanup, but the driver continues to executepm_runtime_enable()andpm_runtime_idle()instead of aborting probe.Fix this by returning 'ret' immediately inside the error path if
pm_runtime_set_active()fails, preventing invalid runtime PM operations on an unregistered device.Fixes 2251157b335b ("iio: srf04: add power management feature")Signed-off-by Salah Triki <[email protected]>
Fixed a few weeks back.
Thanks
Jonathan
Quoted 16 lines
--- drivers/iio/proximity/srf04.c | 1 + 1 file changed, 1 insertion(+)drivers/iio/proximity/srf04.c +1
-0@@ -330,6 +330,7 @@ static int srf04_probe(struct platform_device *pdev)if (ret) {dev_err (data->dev,"pm_runtime_set_active: %d\n" , ret);iio_device_unregister (indio_dev); +return ret; }pm_runtime_enable (data->dev);