Skip to contentSkip to conversation

memory: emif: Replace __ASSEMBLY__ with __ASSEMBLER__ in non-uapi headers

PATCH Applied Thomas Huth 2 participants 2 messages Aug 21 – Sep 4

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 memory: emif: Replace __ASSEMBLY__ with __ASSEMBLER__ in non-uapi headers

While the GCC and Clang compilers already define __ASSEMBLER__ auto- matically when compiling assembly code, __ASSEMBLY__ is a macro that only gets defined by the Makefiles in the kernel. This can be very confusing when switching between userspace and kernelspace coding, or when dealing with uapi headers that rather should use __ASSEMBLER__ instead. Let's standardize now on the __ASSEMBLER__ macro to avoid this confusion.

---
Note: This has been split from an earlier bigger patch of mine into
this separate patch to ease reviewing

 drivers/memory/emif.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/memory/emif.h +2 -2
index 55aeb36a5bf24..5dfb09adb0960 100644
@@ -558,7 +558,7 @@
 #define EMIF_SRAM_AM33_REG_LAYOUT			0x00000000
 #define EMIF_SRAM_AM43_REG_LAYOUT			0x00000001
 
-#ifndef __ASSEMBLY__
+#ifndef __ASSEMBLER__
 /*
  * Structure containing shadow of important registers in EMIF
  * The calculation function fills in this structure to be later used for
@@ -603,5 +603,5 @@ void ti_emif_enter_sr(void);
 void ti_emif_exit_sr(void);
 void ti_emif_abort_sr(void);
 
-#endif /* __ASSEMBLY__ */
+#endif /* __ASSEMBLER__ */
 #endif /* __EMIF_H */
Signature · 1 line
2.55.0
maintainer Applied
#1 lore raw
Quoted 9 lines · Thomas Huth

While the GCC and Clang compilers already define __ASSEMBLER__ auto- matically when compiling assembly code, __ASSEMBLY__ is a macro that only gets defined by the Makefiles in the kernel. This can be very confusing when switching between userspace and kernelspace coding, or when dealing with uapi headers that rather should use __ASSEMBLER__ instead. Let's standardize now on the __ASSEMBLER__ macro to avoid this confusion.

[...]

Applied, thanks!

[1/1] memory: emif: Replace __ASSEMBLY__ with __ASSEMBLER__ in non-uapi headers

      https://git.kernel.org/krzk/linux-mem-ctrl/c/8676f8e6dc8da769d5192135992a78853f9ea048

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>