Skip to contentSkip to conversation

ARM: EXYNOS: Replace __ASSEMBLY__ with __ASSEMBLER__

PATCH Applied Thomas Huth 2 participants 2 messages Aug 21 – Sep 4

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: EXYNOS: Replace __ASSEMBLY__ with __ASSEMBLER__

While the GCC and Clang compilers already define __ASSEMBLER__ auto- matically when compiling assembly code, __ASSEMBLY__ is a macro that only gets defined by the Makefiles in the kernel. This can be very confusing when switching between userspace and kernelspace coding, or when dealing with uapi headers that rather should use __ASSEMBLER__ instead. Let's standardize now on the __ASSEMBLER__ macro to avoid this confusion.

---
Note: This has been split from an earlier bigger patch of mine into
a separate patch to ease reviewing

 arch/arm/mach-exynos/smc.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-exynos/smc.h +2 -2
index 5c30feb8f07d9..5c7730f6259fc 100644
@@ -32,11 +32,11 @@
 #define SMC_REG_CLASS_SFR_W	(0x1 << 30)
 #define SMC_REG_ID_SFR_W(addr)	(SMC_REG_CLASS_SFR_W | ((addr) >> 2))
 
-#ifndef __ASSEMBLY__
+#ifndef __ASSEMBLER__
 
 extern void exynos_smc(u32 cmd, u32 arg1, u32 arg2, u32 arg3);
 
-#endif /* __ASSEMBLY__ */
+#endif /* __ASSEMBLER__ */
 
 /* op type for SMC_CMD_SAVE and SMC_CMD_SHUTDOWN */
 #define OP_TYPE_CORE		0x0
Signature · 1 line
2.55.0
maintainer Applied
#1 lore raw
Quoted 9 lines · Thomas Huth

While the GCC and Clang compilers already define __ASSEMBLER__ auto- matically when compiling assembly code, __ASSEMBLY__ is a macro that only gets defined by the Makefiles in the kernel. This can be very confusing when switching between userspace and kernelspace coding, or when dealing with uapi headers that rather should use __ASSEMBLER__ instead. Let's standardize now on the __ASSEMBLER__ macro to avoid this confusion.

[...]

Applied, thanks!

[1/1] ARM: EXYNOS: Replace __ASSEMBLY__ with __ASSEMBLER__

      https://git.kernel.org/krzk/linux/c/80c92d1f1a4e3000e6eb351ad8af16267b1d4e63

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>