Skip to contentSkip to conversation

pmdomain: airoha: fix unselectable AIROHA_CPU_PM_DOMAIN kconfig

PATCH In review Christian Marangi 3 participants 3 messages Aug 21 – Sep 1

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pmdomain: airoha: fix unselectable AIROHA_CPU_PM_DOMAIN kconfig

The AIROHA_CPU_PM_DOMAIN config was wrongly guarded under the Mediatek PM Domains menu and was unselectable.

Move it outside the menu so it's now visible and correctly selectable by default on Airoha SoC.

Fixes 82e703dd438b ("pmdomain: airoha: Add Airoha CPU PM Domain support")
---
 drivers/pmdomain/mediatek/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pmdomain/mediatek/Kconfig +3 -2
index 8923e6516441..a2eb704a773c 100644
@@ -43,9 +43,12 @@ config MTK_MFG_PM_DOMAIN
 	  This driver is required for the Mali GPU to work at all on MT8196 and
 	  MT6991.
 
+endmenu
+
 config AIROHA_CPU_PM_DOMAIN
 	tristate "Airoha CPU power domain"
 	default ARCH_AIROHA
+	depends on ARCH_AIROHA || COMPILE_TEST
 	depends on HAVE_ARM_SMCCC
 	depends on PM
 	select PM_GENERIC_DOMAINS
@@ -54,5 +57,3 @@ config AIROHA_CPU_PM_DOMAIN
 
 	  CPU frequency and power is controlled by ATF with SMC command to
 	  set performance states.
-
-endmenu
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Christian Marangi

The AIROHA_CPU_PM_DOMAIN config was wrongly guarded under the Mediatek PM Domains menu and was unselectable.

Move it outside the menu so it's now visible and correctly selectable by default on Airoha SoC.

Fixes 82e703dd438b ("pmdomain: airoha: Add Airoha CPU PM Domain support")

This looks OK to me, so:

#2 lore raw
In reply to Christian Marangi
Quoted 10 lines · Christian Marangi

The AIROHA_CPU_PM_DOMAIN config was wrongly guarded under the Mediatek PM Domains menu and was unselectable.

Move it outside the menu so it's now visible and correctly selectable by default on Airoha SoC.

Fixes 82e703dd438b ("pmdomain: airoha: Add Airoha CPU PM Domain support")

Applied for fixes, thanks!

Kind regards
Uffe

Quoted 30 lines
---
 drivers/pmdomain/mediatek/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pmdomain/mediatek/Kconfig +3 -3
index 8923e6516441..a2eb704a773c 100644
@@ -43,9 +43,12 @@ config MTK_MFG_PM_DOMAIN
          This driver is required for the Mali GPU to work at all on MT8196 and
          MT6991.
 
+endmenu
+
 config AIROHA_CPU_PM_DOMAIN
        tristate "Airoha CPU power domain"
        default ARCH_AIROHA
+       depends on ARCH_AIROHA || COMPILE_TEST
        depends on HAVE_ARM_SMCCC
        depends on PM
        select PM_GENERIC_DOMAINS
@@ -54,5 +57,3 @@ config AIROHA_CPU_PM_DOMAIN
 
          CPU frequency and power is controlled by ATF with SMC command to
          set performance states.
-
-endmenu
--

2.53.0