Skip to contentSkip to conversation

soc/tegra: pmc: Fix uninitialised clock rate

PATCH Applied Jon Hunter 2 participants 2 messages Aug 21 – Sep 10 Tegra architecture support

lore
Share & tools
lore

Jon Hunter

author maintainer
#0 lore raw

PATCH 1/1 soc/tegra: pmc: Fix uninitialised clock rate

For legacy 32-bit Tegra devices, the warning in the tegra_pmc_enter_suspend_mode() function is being triggered because the early_pmc->rate variable is never configured and hence, always 0. This issue started occurring after updating the PMC driver to create the PMC context dynamically which causes the 'rate' to be set in the new dynamic context, but missed updating the rate in the early PMC context.

Fix this by initialising the early_pmc->rate variable for 32-bit Tegra devices when the rate for the PMC context is initialised.

Fixes 4d61f0342689 ("soc/tegra: pmc: Create PMC context dynamically")
---
 drivers/soc/tegra/pmc.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/soc/tegra/pmc.c +3 -0
index 41ed716d5857..6d7ac2b8c74e 100644
@@ -3121,6 +3121,9 @@ static int tegra_pmc_probe(struct platform_device *pdev)
 		}
 
 		pmc->rate = clk_get_rate(pmc->clk);
+#if defined(CONFIG_ARM)
+		early_pmc->rate = pmc->rate;
+#endif
 	}
 
 	err = tegra_pmc_init(pmc);
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw

From: Thierry Reding <[email protected]>

Quoted 8 lines · Jon Hunter

For legacy 32-bit Tegra devices, the warning in the tegra_pmc_enter_suspend_mode() function is being triggered because the early_pmc->rate variable is never configured and hence, always 0. This issue started occurring after updating the PMC driver to create the PMC context dynamically which causes the 'rate' to be set in the new dynamic context, but missed updating the rate in the early PMC context.

[...]

Applied, thanks!

[1/1] soc/tegra: pmc: Fix uninitialised clock rate

      commit: c5c95dbdc9011a56359df4dc00be829bbcc0b036

Best regards,

Signature · 1 line
Thierry Reding <[email protected]>