Skip to contentSkip to conversation

Add UALink instrastructure series 1

PATCH In review Alex Deucher 2 participants 97 messages Aug 21 – Aug 25 Page 2 of 2

Subsystems (5)
lore
Share & tools
lore
author maintainer
#92 lore raw

PATCH 92/95 drm/amdgpu: Handle concurrent UALINK handle import race

In reply to Alex Deucher

From: Mukul Joshi <[email protected]>

When two threads import the same UALINK handle concurrently, the first xa_insert() succeeds and the second gets -EBUSY. Convert -EBUSY to -EAGAIN so user-space retries instead of seeing a spurious error.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c +9 -3
index 765105aea09e2..444b0e29ee9f4 100644
@@ -3807,9 +3807,15 @@ int amdgpu_ualink_import_handle(struct drm_device *dev,
 			      imp_xa_node, GFP_KERNEL);
 		if (r) {
 			kfree(imp_xa_node);
-			dev_err(adev->dev,
-				"IMPORT: XA insert failed for handle:%llx:%llx err:%d\n",
-				handle.handle_hi, handle.handle_lo, r);
+			/* -EBUSY means another thread raced us and inserted a
+			 * node for the same handle. Ask user-space to retry.
+			 */
+			if (r == -EBUSY)
+				r = -EAGAIN;
+			else
+				dev_err(adev->dev,
+					"IMPORT: XA insert failed for handle:%llx:%llx err:%d\n",
+					handle.handle_hi, handle.handle_lo, r);
 			goto out;
 		}
 
Signature · 1 line
2.55.0
author maintainer
#93 lore raw

PATCH 93/95 drm/amdgpu: create UALink NPA import BO directly in the NPA domain

In reply to Alex Deucher

From: Mukul Joshi <[email protected]>

amdgpu_ualink_map_npa_to_dmabuf() created the NPA import BO in the CPU/SYSTEM domain and then moved it to NPA. SYSTEM is use_tt=true, so TTM attaches a host-page ttm_tt that the null move to NPA leaves behind. On dma-buf export, ttm_bo_populate() then fills that ttm_tt with system pages, spiking host RAM by the entire NPA window size.

Create the BO directly in the NPA domain (use_tt=false) so no ttm_tt is ever attached, and relocate it to the exact remote window.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c | 29 ++++++++++++++--------
 1 file changed, 18 insertions(+), 11 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c +18 -11
index 444b0e29ee9f4..402d8941fb045 100644
@@ -2987,10 +2987,10 @@ static void amdgpu_ualink_invalidate_import_mappings(struct amdgpu_bo *bo)
 static int amdgpu_ualink_map_npa_to_dmabuf(struct amdgpu_device *adev,
 				struct amdgpu_ualink_imp_xa_node *imp_xa_node)
 {
-	u64 alloc_flags = AMDGPU_GEM_CREATE_NO_CPU_ACCESS, npa_addr, size;
 	struct ttm_operation_ctx ctx = { false, false };
-	u32 initial_domain = AMDGPU_GEM_DOMAIN_CPU;
+	u32 initial_domain = AMDGPU_GEM_DOMAIN_NPA;
 	struct drm_gem_object *gobj = NULL;
+	u64 alloc_flags, npa_addr, size;
 	struct dma_buf *dmabuf;
 	struct amdgpu_bo *bo;
 	u32 handle;
@@ -3002,21 +3002,19 @@ static int amdgpu_ualink_map_npa_to_dmabuf(struct amdgpu_device *adev,
 	dev_dbg(adev->dev, "Create NPA BO addr 0x%llx size in pages 0x%llx\n",
 		npa_addr, size);
 
-	/* TODO: Check if this needs to be on a xcp_id basis */
+	/*
+	 * Create the BO directly in the NPA domain.
+	 */
+	alloc_flags = AMDGPU_GEM_CREATE_NO_CPU_ACCESS;
 	r = amdgpu_gem_object_create(adev, size * AMDGPU_GPU_PAGE_SIZE, 1,
 				     initial_domain, alloc_flags,
 				     ttm_bo_type_device, NULL, &gobj, 0);
 	if (r) {
-		dev_err(adev->dev,
-			"Failed to create NPA BO in CPU domain. ret %d\n", r);
+		dev_err(adev->dev, "Failed to create NPA BO. ret %d\n", r);
 		return r;
 	}
 
 	bo = gem_to_amdgpu_bo(gobj);
-	amdgpu_bo_placement_from_domain(bo, AMDGPU_GEM_DOMAIN_NPA);
-
-	bo->placements[0].fpfn = npa_addr;
-	bo->placements[0].lpfn = npa_addr + size;
 
 	r = amdgpu_bo_reserve(bo, false);
 	if (unlikely(r != 0)) {
@@ -3024,11 +3022,20 @@ static int amdgpu_ualink_map_npa_to_dmabuf(struct amdgpu_device *adev,
 		goto err_reserve_failed;
 	}
 
-	r = ttm_bo_validate(&bo->tbo, &bo->placement, &ctx);
+	/*
+	 * Drop the arbitrarily-placed NPA node and re-create it at the exact
+	 * remote window, mirroring amdgpu_bo_create_kernel_at().
+	 */
+	ttm_resource_free(&bo->tbo, &bo->tbo.resource);
+
+	bo->placements[0].fpfn = npa_addr;
+	bo->placements[0].lpfn = npa_addr + size;
+
+	r = ttm_bo_mem_space(&bo->tbo, &bo->placement, &bo->tbo.resource, &ctx);
 	amdgpu_bo_unreserve(bo);
 	if (r) {
 		dev_err(adev->dev,
-			"Failed to validate BO in NPA domain, r: %d\n", r);
+			"Failed to place NPA BO at 0x%llx, r: %d\n", npa_addr, r);
 		goto err_validate_failed;
 	}
 
Signature · 1 line
2.55.0
author maintainer
#94 lore raw

PATCH 94/95 drm/amdgpu: add mtype_remote module parameter

In reply to Alex Deucher

From: Mukul Joshi <[email protected]>

Add an amdgpu_mtype_remote module parameter so the MTYPE used for remote memory accesses can be overridden. For now only MTYPE_NC and MTYPE_UC are selectable (0 = MTYPE_NC, 1 = MTYPE_UC); it defaults to the ASIC-dependent value. Currently, it is used only for GFX 12.1.

The MTYPEs resolved for both local and remote memory are logged once.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu.h     |  1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c |  7 +++++
 drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c  | 34 +++++++++++++------------
 drivers/gpu/drm/amd/amdkfd/kfd_svm.c    |  8 ++++--
 4 files changed, 32 insertions(+), 18 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu.h +1 -0
index f619d95a5ccfe..79b69d74eb2e5 100644
@@ -223,6 +223,7 @@ extern int amdgpu_force_asic_type;
 extern int amdgpu_smartshift_bias;
 extern int amdgpu_use_xgmi_p2p;
 extern int amdgpu_mtype_local;
+extern int amdgpu_mtype_remote;
 extern int amdgpu_enforce_isolation;
 extern uint amdgpu_debug_mask;
 #ifdef CONFIG_HSA_AMD
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +7 -0
index 53738b40c97f6..04b21e456fbc0 100644
@@ -844,6 +844,13 @@ int amdgpu_mtype_local = -1;
 MODULE_PARM_DESC(mtype_local, "MTYPE for local memory (default: ASIC dependent, 0 = MTYPE_RW, 1 = MTYPE_NC, 2 = MTYPE_CC)");
 module_param_named_unsafe(mtype_local, amdgpu_mtype_local, int, 0444);
 
+/**
+ * DOC: mtype_remote (int)
+ */
+int amdgpu_mtype_remote = -1;
+MODULE_PARM_DESC(mtype_remote, "MTYPE for remote memory (default: ASIC dependent, 0 = MTYPE_NC, 1 = MTYPE_UC)");
+module_param_named_unsafe(mtype_remote, amdgpu_mtype_remote, int, 0444);
+
 /**
  * DOC: pcie_p2p (bool)
  * Enable PCIe P2P (requires large-BAR). Default value: true (on)
drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c +18 -16
index a3b7e240abaed..4e7b6e2c87ab5 100644
@@ -618,8 +618,8 @@ static void gmc_v12_1_get_npa_flags(struct amdgpu_device *adev,
 
 /*
  * Resolve the MTYPEs used for local and remote memory accesses on GFX 12.1.
- * Remote memory always uses MTYPE_UC; local memory depends on the AID stepping
- * and the amdgpu_mtype_local module parameter.
+ * Both default to an ASIC-dependent value that can be overridden through the
+ * amdgpu_mtype_local and amdgpu_mtype_remote module parameters.
  */
 static void gmc_v12_1_get_mtypes(struct amdgpu_device *adev,
 				 unsigned int *mtype_local,
@@ -627,23 +627,25 @@ static void gmc_v12_1_get_mtypes(struct amdgpu_device *adev,
 {
 	bool is_aid_a1 = (adev->rev_id & 0x10);
 
+	/* Local memory: ASIC default depends on the AID stepping. */
 	*mtype_local = is_aid_a1 ? MTYPE_RW : MTYPE_NC;
-	/* Remote memory always uses MTYPE_UC on GFX 12.1. */
-	*mtype_remote = MTYPE_UC;
-
-	if (amdgpu_mtype_local == 0) {
-		DRM_INFO_ONCE("Using MTYPE_RW for local memory\n");
+	if (amdgpu_mtype_local == 0)
 		*mtype_local = MTYPE_RW;
-	} else if (amdgpu_mtype_local == 1) {
-		DRM_INFO_ONCE("Using MTYPE_NC for local memory\n");
+	else if (amdgpu_mtype_local == 1)
 		*mtype_local = MTYPE_NC;
-	} else if (amdgpu_mtype_local == 2) {
-		DRM_INFO_ONCE("MTYPE_CC not supported, using %s for local memory\n",
-			      is_aid_a1 ? "MTYPE_RW" : "MTYPE_NC");
-	} else {
-		DRM_INFO_ONCE("Using %s for local memory and MTYPE_UC for remote memory\n",
-			      is_aid_a1 ? "MTYPE_RW" : "MTYPE_NC");
-	}
+	else if (amdgpu_mtype_local == 2)
+		DRM_INFO_ONCE("MTYPE_CC not supported for local memory\n");
+
+	/* Remote memory defaults to MTYPE_UC on GFX 12.1. */
+	*mtype_remote = MTYPE_UC;
+	if (amdgpu_mtype_remote == 0)
+		*mtype_remote = MTYPE_NC;
+	else if (amdgpu_mtype_remote == 1)
+		*mtype_remote = MTYPE_UC;
+
+	DRM_INFO_ONCE("Using %s for local memory and %s for remote memory\n",
+		      *mtype_local == MTYPE_RW ? "MTYPE_RW" : "MTYPE_NC",
+		      *mtype_remote == MTYPE_NC ? "MTYPE_NC" : "MTYPE_UC");
 }
 
 /*
drivers/gpu/drm/amd/amdkfd/kfd_svm.c +6 -2
index 64fb38400bd1a..c521ec07bf3c0 100644
@@ -1348,8 +1348,12 @@ svm_range_get_pte_flags(struct kfd_node *node, struct amdgpu_vm *vm,
 		mtype_local = amdgpu_mtype_local == 0 ? AMDGPU_VM_MTYPE_RW :
 				amdgpu_mtype_local == 1 ? AMDGPU_VM_MTYPE_NC :
 				is_aid_a1 ? AMDGPU_VM_MTYPE_RW : AMDGPU_VM_MTYPE_NC;
-		/* Remote memory always uses MTYPE_UC on GFX 12.1. */
-		mtype_remote = AMDGPU_VM_MTYPE_UC;
+		/* Remote memory defaults to MTYPE_UC on GFX 12.1 and can be
+		 * overridden through the amdgpu_mtype_remote module parameter
+		 * (0 = MTYPE_NC, 1 = MTYPE_UC).
+		 */
+		mtype_remote = amdgpu_mtype_remote == 0 ? AMDGPU_VM_MTYPE_NC :
+				AMDGPU_VM_MTYPE_UC;
 		snoop = true;
 
 		if (is_local) /* local HBM  */ {
Signature · 1 line
2.55.0
author maintainer
#95 lore raw

PATCH 95/95 drm/amdgpu: Honor mtype overrides for NPA remote memory

In reply to Alex Deucher

From: Mukul Joshi <[email protected]>

Derive mtype_remote in gmc_v12_1_get_npa_flags() from gmc_v12_1_get_mtypes() so the module-parameter override and ASIC defaults are honored instead of recomputing with hard-coded values.

---
 drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c +6 -3
index 4e7b6e2c87ab5..565ee7fba3cdb 100644
@@ -28,6 +28,10 @@
 #include "oss/osssys_7_1_0_sh_mask.h"
 #include "ivsrcid/vmc/irqsrcs_vmc_1_0.h"
 
+static void gmc_v12_1_get_mtypes(struct amdgpu_device *adev,
+				 unsigned int *mtype_local,
+				 unsigned int *mtype_remote);
+
 static int gmc_v12_1_vm_fault_interrupt_state(struct amdgpu_device *adev,
 					      struct amdgpu_irq_src *src,
 					      unsigned int type,
@@ -603,10 +607,9 @@ static void gmc_v12_1_get_vm_pde(struct amdgpu_device *adev, int level,
 static void gmc_v12_1_get_npa_flags(struct amdgpu_device *adev,
 				    uint64_t *flags)
 {
-	bool is_aid_a1 = (adev->rev_id & 0x10);
-	unsigned int mtype_remote;
+	unsigned int mtype_local, mtype_remote;
 
-	mtype_remote = is_aid_a1 ? MTYPE_NC : MTYPE_UC;
+	gmc_v12_1_get_mtypes(adev, &mtype_local, &mtype_remote);
 
 	*flags = AMDGPU_PTE_MTYPE_GFX12(*flags, mtype_remote);
 	/* VSCT = 0011 to identify NPA. Additionally PTE.B = 1 */
Signature · 1 line
2.55.0
#96 lore raw
In reply to Alex Deucher

Two nitpicks below.

Regards,
Philip

Quoted 6 lines · Alex Deucher

This adds the core infrastructure for supporting UALink (Ultra Accelerator Link) connected scale up pods. I've split this into two series, one to add the core infrastructure, and one to expose the new IOCTL interface and add the documentation to avoid spamming the larger audience with the implemenation defails. This is the first series.

Quoted 7 lines

This implements UALoE (UALink over Ethernet). An overview of the complete solution can be found here:
https://www.amd.com/en/products/rackscale-solutions/helios.html

Overview

Connected GPUs in a pod can directly access the remove memory on another

s/remove/remote/

Quoted 15 lines

GPU over UALink. Unlike RMDA, there is no copy involved; it is direct loads/stores over the fabric. Shared memory can only be accessed by a remote GPU if the memory was exported and the importer has been authorized. For the memory to be shared, it must be part of a unified physical address space shared between nodes. This address space is called NPA (Nework Physical Address) space. This address space is partitioned between the GPUs so that each GPU has it's own segment of the address space in which to export its memory. Each GPU maintains a dedicated set of page tables for their NPA space similar to GPUVM.

Exported memory is not pinned. The exporter may need to move memory or make it unavailable to the importers. This is handled via remote TLB shootdowns on the exporter in the case of TTM evictions or MMU notifiers and remote presense checks with retry on the importer.

Quoted 4 lines

To access remote memory, the driver can map NPA addresses into its per process GPUVM page tables just like local memory. Applications use opaque handles to represent remote memory. GPUs in a pod communicate with eachother directly to exchange NPA addresses between importers

s/eachother/each other/

Quoted 201 lines

and exporters. If a node goes offline or is reset, their peers will clean up any remaining refrences that are lost when that happens.

User interface

Export Memory

To export memory, a handle must be created for an allocation that can be shared with another node in the pod. To do this the exporter calls the GEM UALink IOCTL with the GEM handle to the buffer it wants to export. The IOCTL returns a unique handle which can be shared with the remote host.

Import Memory

To import the memory, the handle from the remote node must be converted from a unique handle to a local GEM object which represents the local reference to the NPA space on the importer. If the memory has already been imported, it just returns a new reference to the existing object. If not, the importer queries the exporter to get the NPA address. Once it has that the importer can create a dma-buf to represent the NPA space used by the allocation and that is returned to the application.

Alex Sierra (1):
drm/amdgpu: log remote memory MTYPE for GC 12.1.0

Felix Kuehling (17):
drm/amdgpu: Add sysfs API for UALink information drm/amdgpu: Add sysfs API for UALink physical pod setup drm/amdgpu: Add sysfs API for UALink virtual pod config drm/amdgpu: Add sysfs API for UALink station configuration drm/amdgpu: Implement PSP cmd UAL_GET_CONFIG drm/amdgpu: Query initial UALink config from PSP drm/amdgpu: Implement PSP cmd UAL_SET_PPOD_CONFIG drm/amdgpu: Set physical pod configuration to PSP drm/amdgpu: Implement PSP cmd UAL_SET_VPOD_CONFIG drm/amdgpu: Set virtual pod configuration to PSP drm/amdgpu: Implement PSP cmd UAL_SET_STATION_CONFIG drm/amdgpu: Set UALink station config to PSP drm/amdgpu: Implement PSP cmd UAL_SET_NPA_CONFIG drm/amdgpu: Enable/disable NPA address translation using PSP drm/amdgpu: Prevent double-free of drm_exec drm/amdgpu: Pin page tables in NPA VMs
drm/amdgpu: Initialize NPA PT/PDs to noretry

Gangliang Xie (1):
drm/amdgpu: add handler for nHT error

Harish Kasiviswanathan (2):
drm/amdgpu: Add helper function to check psp xgmi ta drm/amdgpu: Add ual_config_state to ual_get_config

Jinzhou Su (1):
drm/amdgpu: Fix NULL pointer issue during ualink init

Le Ma (1):
drm/amdgpu: extend PSP command polling sleep range

Lijo Lazar (15):
drm/amdgpu: Add psp ualink command interfaces drm/amdgpu: Fetch asp ualink interface version drm/amdgpu: Separate out ualink init sequences drm/amdgpu: Add ualink as separate ip block drm/admgpu: Seggregate ualink nht messaging drm/amdgpu: Assign accel state based on ASP config drm/amdgpu: Drop duplicate vpod check functions drm/amdgpu: Add support to send ASP completion drm/amdgpu: Add handlers for ualink notifications drm/amdgpu: Improve ualink state transitions drm/amdgpu: Use uniform logic for inband/sideband drm/amdgpu: Add name for ualink ip block drm/amdgpu: Move ualink ip version related changes drm/amdgpu: Add hw_fini for ualink drm/amdgpu: Expose ualink info under each xcp

Mukul Joshi (42):
drm/amdgpu: Add UALink manager core infrastructure drm/amdgpu: Add a new NPA Address space
drm/amdgpu: Add address allocator for NPA addresses drm/amdgpu: Initialize VM for NPA addr management drm/amdgpu: Rework VMID reservation logic
drm/amdgpu: Reserve VMID for NPA VM
drm/amdgpu: Use reserved VMID for NPA VM
drm/amdgpu: Enable UALink Manager when pod becomes active drm/amdgpu: Create a drm client for UALink NPA BOs drm/amdgpu: Control NPA DMA-buf importing
drm/amdgpu: Add ualink handle to BOs
drm/amdgpu: Implement UALink handle export
drm/amdgpu: Add connection state management
drm/amdgpu: Implement UALink handle import ioctl drm/amdgpu: Implement mechanism to revoke exported memory drm/amdgpu: lock UALink import invalidation via drm_exec drm/amdgpu: Cleanup exported UALink handles
drm/amdgpu: Cleanup imported UALink handles
drm/amdgpu: Handle connection reset
drm/amdgpu: Setup PTE mappings for NPA addresses drm/amdgpu: Add handling for remote interrupts drm/amdgpu: Send TLB shootdown on exported memory unmap drm/amdgpu: Handle local GPUs in UALink import drm/amdgpu: Add debugfs to drop UALink protocol messages drm/amdgpu: Temporarily disable sending remote TLB shootdowns drm/amdgpu: Temporarily Flush TLB on NPA mapping always drm/amdgpu: fix NPA-RELEASE race in UALink exporter cleanup drm/amdgpu: initialize UALink importer node list head drm/amdgpu: Fix initialization flags for UALink XAs drm/amdgpu: fix dma_buf leak in UALink exporter cleanup drm/amdgpu: Fix uninitialized fence in UALink NPA unmap drm/amdgpu: Use vm->last_update fence in UALink NPA unmap paths drm/amdgpu: always use MTYPE_UC for remote memory on GFX 12.1 drm/amdkfd: program compute MQD coherent_aql_mtype on GFX 12.1 drm/amdgpu: Fix GART and SDMA entity leak on vPod reconfiguration drm/amdgpu: Add UALink diagnostic logging for vpod commit/activation drm/amdgpu: Handle UALink vPod reconfiguration while ACTIVE drm/amdgpu: Cleanup UALink XA entries on manager stop drm/amdgpu: Handle concurrent UALINK handle import race drm/amdgpu: create UALink NPA import BO directly in the NPA domain drm/amdgpu: add mtype_remote module parameter
drm/amdgpu: Honor mtype overrides for NPA remote memory

Philip Yang (15):
drm/amdgpu: Fix UALink vPod double-activation drm/amdgpu: Add UALink remote state structures and API declarations drm/amdgpu: Add UALink NPA address layout helpers drm/amdgpu: Add UALink NPA address computation for ring buffers drm/amdgpu: Add UALink NPA VM mapping for ring buffers drm/amdgpu: Add UALink SDMA scheduler entities drm/amdgpu: Add UALink GART helpers for NPA address access drm/amdgpu: Add UALink ring buffer allocation and firmware init drm/amdgpu: Add UALink remote command packets and SDMA dispatch drm/amdgpu: Add UALink firmware writeback address configuration drm/amdgpu: Add UALink cross-GPU TLB shootdown and remote interrupt drm/amdgpu: Add UALink software init, teardown, and reset drm/amdgpu: Add UALink IH ring and enable interrupt drm/amdgpu: UALink use LSDMA to send remote interrupt command drm/amdgpu: Increase UALink soft ring size

  drivers/gpu/drm/amd/amdgpu/Makefile           |    3 +
  drivers/gpu/drm/amd/amdgpu/amdgpu.h           |    5 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c   |   14 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |    2 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c |   21 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c   |    5 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       |    7 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h       |    1 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c       |   33 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_ids.h       |   27 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h        |    1 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_ip.c        |    1 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c       |   17 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h       |    7 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_object.c    |   11 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_object.h    |    5 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c       |  280 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h       |   27 +
  .../gpu/drm/amd/amdgpu/amdgpu_res_cursor.h    |    1 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c       |   17 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h       |    4 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c    | 6174 +++++++++++++++++
  drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.h    |  421 ++
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c        |   44 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h        |    4 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c     |   29 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c       |    6 +
  drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.h       |    7 +
  drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c        |    2 +-
  drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c        |    2 +-
  drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c        |    2 +-
  drivers/gpu/drm/amd/amdgpu/gfx_v12_1.c        |   51 +-
  drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c         |    2 +-
  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c         |    2 +-
  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c         |    2 +-
  drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c       |    2 +-
  drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c        |    4 +
  drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c        |    5 +
  drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c        |   26 +-
  drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c        |   98 +-
  drivers/gpu/drm/amd/amdgpu/gmc_v12_1.h        |    1 +
  drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c         |    6 +
  drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c         |    6 +
  drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c         |    6 +
  drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c         |    6 +
  drivers/gpu/drm/amd/amdgpu/ih_v7_0.c          |    8 +
  drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h       |  162 +
  drivers/gpu/drm/amd/amdgpu/psp_v15_0_8.c      |   48 +-
  drivers/gpu/drm/amd/amdgpu/soc_v1_0.c         |    6 -
  drivers/gpu/drm/amd/amdgpu/ualink_v1_0.c      |  143 +
  drivers/gpu/drm/amd/amdgpu/ualink_v1_0.h      |   30 +
  .../drm/amd/amdkfd/kfd_mqd_manager_v12_1.c    |    7 +
  drivers/gpu/drm/amd/amdkfd/kfd_svm.c          |    8 +-
  drivers/gpu/drm/amd/include/amd_shared.h      |    2 +
  .../ivsrcid/mpnht/irqsrcs_mpnht_15_0.h        |   30 +
  drivers/gpu/drm/amd/include/v12_structs.h     |    2 +-
  include/drm/ttm/ttm_resource.h                |    2 +-
  include/uapi/drm/amdgpu_drm.h                 |    6 +
  58 files changed, 7782 insertions(+), 69 deletions(-)

create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c
create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.h
create mode 100644 drivers/gpu/drm/amd/amdgpu/ualink_v1_0.c
create mode 100644 drivers/gpu/drm/amd/amdgpu/ualink_v1_0.h
create mode 100644 drivers/gpu/drm/amd/include/ivsrcid/mpnht/irqsrcs_mpnht_15_0.h