pci: Add broken-GPE quirk for Lenovo Legion 16APH8 and 16AHP9 Nvidia GPUs
Subsystems (2)
PATCH v2 1/1 pci: Add broken-GPE quirk for Lenovo Legion 16APH8 and 16AHP9 Nvidia GPUs
On the Lenovo Legion Slim 5 16APH8 and 16AHP9, the firmware appears to enjoy firing a GPE on the parent PCIe port of the nvidia GPU very shortly after the GPU enters D3Cold. This means that every time the GPU is runtime suspended, ACPI firmware immediately wakes up its parent PCIe port, which then wakes up the GPU. Once it falls asleep again, the cycle repeats.
See: https://github.com/NVIDIA/open-gpu-kernel-modules/issues/905
Note, this bug doesn't require Nvidia's driver. It happens on nouveau and nova as well, and it even seems possible for this to happen without any driver loaded.
This seems to simply be a bug. Luckily, there is nothing that we actually need ACPI wakeup events for on the GPU. Events such as display connector hotplug events in D3Cold come through as ACPI_VIDEO events which aren't affected by this quirk.
---
V2:
* Don't forget to actually use parent_adev with acpi_remove_pm_notifier()
* Check if parent_adev is NULL (could happen if booted with acpi=off), just consider it a no-op if it is.
* Base the patch off Linux master instead, I based it off drm-misc-next by mistake because I'm too used to working on DRM drivers :).
drivers/pci/quirks.c | 79 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 79 insertions(+)
drivers/pci/quirks.c +79 -0
@@ -6165,6 +6165,85 @@ DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, 0x13b1,PCI_CLASS_DISPLAY_VGA ,8 , quirk_reset_lenovo_thinkpad_p50_nvgpu); +#ifdef CONFIG_ACPI +#ifdef CONFIG_DMI +static const struct dmi_system_id nvidia_dgpu_broken_gpe_quirk_table[] = { + { + .matches = { +DMI_EXACT_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), +DMI_MATCH (DMI_PRODUCT_VERSION ,"16APH8" ), + }, + }, + { + .matches = { +DMI_EXACT_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), +DMI_MATCH (DMI_PRODUCT_VERSION ,"16AHP9" ), + }, + }, + {} +}; + +/* +* On the Lenovo Legion Slim 5 16APH8 and 16AHP9, the firmware appears to enjoy +* firing a GPE on the parent PCIe port of the nvidia GPU very shortly after the +* GPU enters D3Cold. This means that every time the GPU is runtime suspended, +* ACPI firmware immediately wakes up its parent PCIe port, which then wakes up +* the GPU. Once it falls asleep again, the cycle repeats. +* +* See: https://github.com/NVIDIA/open-gpu-kernel-modules/issues/905 +* +* Note, this bug doesn't require Nvidia's driver. It happens on nouveau and +* nova as well, and it even seems possible for this to happen without any +* driver loaded. +* +* This seems to simply be a bug. Luckily, there is nothing that we actually +* need ACPI wakeup events for on the GPU. Events such as display connector +* hotplug events in D3Cold come through as ACPI_VIDEO events which aren't +* affected by this quirk. +* +* So, workaround this by disabling wakeup events for the parent PCIe port of +* the GPU. +*/ +static void quirk_nvidia_dgpu_broken_gpe (struct pci_dev *pdev) +{ +struct acpi_device *parent_adev; +struct device *parent_dev; +int ret; + +/* Just to be extra safe and make sure we don't try this on an eGPU */ +if (pci_is_thunderbolt_attached (pdev)) +return ; + + ret =dmi_check_system (nvidia_dgpu_broken_gpe_quirk_table); +if (ret ==0 ) +return ; + +pci_info (pdev,FW_BUG "GPU PCIe port has broken wakeup events, disabling\n" ); + + parent_dev =pci_physfn (pdev)->dev.parent; +if (!parent_dev) { +pci_err (pdev, +"Can't find PCIe parent? Your Nvidia GPU will have broken runtime PM\n" ); +return ; + } + + parent_adev =ACPI_COMPANION (parent_dev); +if (!parent_adev)/* No ACPI? That means no GPE, and nothing to do here. */ +return ; + +/* The spurious GPEs will be sent from the ACPI device for the PCIe port this GPU is +* connected to, so remove our PM notifier to turn them into a no-op. +*/ + ret =acpi_remove_pm_notifier (parent_adev); +if (ACPI_FAILURE (ret)) +pci_err (pdev,"Removing PM notifier failed: %d\n" , ret); +} +DECLARE_PCI_FIXUP_CLASS_FINAL (PCI_VENDOR_ID_NVIDIA ,0x28e0 , +PCI_CLASS_DISPLAY_VGA ,8 , + quirk_nvidia_dgpu_broken_gpe); +#endif +#endif +/* * Device [1b21:2142] * When in D0, PME# doesn't get asserted when plugging USB 3.0 device.
base-commit: 2be02a7c996aa733bb36e29e07715621b0de9736
Signature · 1 line
2.55.0
[email protected]
AI reviewSashiko has reviewed this patch and found no issues. It looks great!
Quoted 12 lines
On the Lenovo Legion Slim 5 16APH8 and 16AHP9, the firmware appears to enjoy firing a GPE on the parent PCIe port of the nvidia GPU very shortly after the GPU enters D3Cold. This means that every time the GPU is runtime suspended, ACPI firmware immediately wakes up its parent PCIe port, which then wakes up the GPU. Once it falls asleep again, the cycle repeats.
See: https://github.com/NVIDIA/open-gpu-kernel-modules/issues/905
Note, this bug doesn't require Nvidia's driver. It happens on nouveau and nova as well, and it even seems possible for this to happen without any driver loaded.
Quoted 8 lines
This seems to simply be a bug. Luckily, there is nothing that we actually need ACPI wakeup events for on the GPU. Events such as display connector hotplug events in D3Cold come through as
ACPI_VIDEOevents which aren't affected by this quirk.Reported-by Ryan Brue <[email protected]>Co-authored-by Ryan Brue <[email protected]>Signed-off-by Lyude Paul <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 31 lines · Lyude Paul
On the Lenovo Legion Slim 5 16APH8 and 16AHP9, the firmware appears to enjoy firing a GPE on the parent PCIe port of the nvidia GPU very shortly after the GPU enters D3Cold. This means that every time the GPU is runtime suspended, ACPI firmware immediately wakes up its parent PCIe port, which then wakes up the GPU. Once it falls asleep again, the cycle repeats.
See: https://github.com/NVIDIA/open-gpu-kernel-modules/issues/905
Note, this bug doesn't require Nvidia's driver. It happens on nouveau and nova as well, and it even seems possible for this to happen without any driver loaded.
This seems to simply be a bug. Luckily, there is nothing that we actually need ACPI wakeup events for on the GPU. Events such as display connector hotplug events in D3Cold come through as
ACPI_VIDEOevents which aren't affected by this quirk.Reported-by Ryan Brue <[email protected]>Co-authored-by Ryan Brue <[email protected]>Signed-off-by Lyude Paul <[email protected]>---
V2:
* Don't forget to actually useparent_adevwithacpi_remove_pm_notifier()
* Check ifparent_adevis NULL (could happen if booted with acpi=off), just consider it a no-op if it is.
* Base the patch off Linux master instead, I based it off drm-misc-next by mistake because I'm too used to working on DRM drivers :).
Quoted 2 lines
drivers/pci/quirks.c | 79 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 79 insertions(+)
FWIW, this has been tested by me, with positive results, on my Lenovo Legion Slim 5 16APH8. Not sure if this warrants a Tested-by trailer since I'm a co-author, but just in case.
In the thread [1], we have had another user report positive results on their 16AHP9 (note that Lenovo seems to have switched the P and the H around for the laptop one generation up for some reason). Said user tested on both OpenRM and nouveau on top of kernel 7.1.10.
This means we have tested 16APH8 on nouveau, and 16AHP9 on both OpenRM and nouveau.
[1] https://github.com/NVIDIA/open-gpu-kernel-modules/issues/905#issuecomment-5444071160