Skip to contentSkip to conversation

mmc: sdio_uart: fix xmit_fifo leak when the port table is full

PATCH In review Felix Gu 2 participants 2 messages Aug 21 – Sep 10 MMC, SD and SDIO

lore
Share & tools
lore

Felix Gu

author
#0 lore raw

PATCH 1/1 mmc: sdio_uart: fix xmit_fifo leak when the port table is full

sdio_uart_add_port() allocates the transmit fifo before claiming a slot in sdio_uart_table[]. When all UART_NR slots are taken, it returns -EBUSY with the fifo still allocated, but the probe error path only kfree()s the port, leaking the transmit fifo.

Free the fifo in the failure path of sdio_uart_add_port() itself so the function retains nothing on error.

Fixes 8b197a5ce7a7 ("sdio_uart: Use kfifo instead of the messy circ stuff")
---
 drivers/mmc/core/sdio_uart.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/core/sdio_uart.c +3 -0
index 7fd5dedf3ac0..705163c42972 100644
@@ -104,6 +104,9 @@ static int sdio_uart_add_port(struct sdio_uart_port *port)
 	}
 	spin_unlock(&sdio_uart_table_lock);
 
+	if (ret)
+		kfifo_free(&port->xmit_fifo);
+
 	return ret;
 }
 

---
base-commit: 903c1cf6dff9964e71eda98a39e2e5d442050472
change-id: 20260822-sdio_uart-a702d7cc5eb4

Best regards,

Signature · 1 line
Felix Gu <[email protected]>
#1 lore raw
Quoted 11 lines · Felix Gu

sdio_uart_add_port() allocates the transmit fifo before claiming a slot in sdio_uart_table[]. When all UART_NR slots are taken, it returns -EBUSY with the fifo still allocated, but the probe error path only kfree()s the port, leaking the transmit fifo.

Free the fifo in the failure path of sdio_uart_add_port() itself so the function retains nothing on error.

Fixes 8b197a5ce7a7 ("sdio_uart: Use kfifo instead of the messy circ stuff")

Applied for fixes and by adding a stable tag, thanks!

Kind regards
Uffe

Quoted 27 lines
---
 drivers/mmc/core/sdio_uart.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/core/sdio_uart.c +3 -1
index 7fd5dedf3ac0..705163c42972 100644
@@ -104,6 +104,9 @@ static int sdio_uart_add_port(struct sdio_uart_port *port)
        }
        spin_unlock(&sdio_uart_table_lock);
 
+       if (ret)
+               kfifo_free(&port->xmit_fifo);
+
        return ret;
 }
 
 
---

base-commit: 903c1cf6dff9964e71eda98a39e2e5d442050472
change-id: 20260822-sdio_uart-a702d7cc5eb4

Best regards,
--
Felix Gu <[email protected]>