Skip to contentSkip to conversation

classes: spdx-3.0: add missing vardeps

PATCH Superseded iwanicki92 1 participant 1 message Aug 22

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

iwanicki92

author
#0 lore raw

PATCH 1/1 classes: spdx-3.0: add missing vardeps

Add "${SPDX_IMAGE_SUPPLIER}_name", "${SPDX_IMAGE_SUPPLIER}_type", "${SPDX_PACKAGE_SUPPLIER}_name", and "${SPDX_PACKAGE_SUPPLIER}_type" to respective task vardeps to make sure SPDX is regenerated if those change.

---
 meta/classes-recipe/create-spdx-image-3.0.bbclass | 4 +++-
 meta/classes/create-spdx-3.0.bbclass              | 7 +++++--
 2 files changed, 8 insertions(+), 3 deletions(-)
meta/classes-recipe/create-spdx-image-3.0.bbclass +3 -1
index cf79ef5b013a..faf4eef8a9a3 100644
@@ -57,7 +57,9 @@ do_create_image_spdx[dirs] = "${SPDXIMAGEWORK}"
 do_create_image_spdx[file-checksums] += "${SPDX3_DEP_FILES}"
 do_create_image_spdx[vardeps] += "\
     SPDX_IMAGE_PURPOSE \
-    "
+    ${@'${SPDX_IMAGE_SUPPLIER}_name' if d.getVar('SPDX_IMAGE_SUPPLIER') else ''} \
+    ${@'${SPDX_IMAGE_SUPPLIER}_type' if d.getVar('SPDX_IMAGE_SUPPLIER') else ''} \
+"
 
 python do_create_image_spdx_setscene() {
     sstate_setscene(d)
meta/classes/create-spdx-3.0.bbclass +5 -2
index 56fd01fd533b..6c5f84db1ef3 100644
@@ -253,7 +253,11 @@ do_create_package_spdx[dirs] = "${SPDXRUNTIMEDEPLOY}"
 do_create_package_spdx[cleandirs] = "${SPDXRUNTIMEDEPLOY}"
 do_create_package_spdx[deptask] = "do_create_spdx"
 do_create_package_spdx[rdeptask] = "do_create_spdx"
-do_create_package_spdx[vardeps] += "${SPDX3_VAR_DEPS}"
+do_create_package_spdx[vardeps] += " \
+    ${SPDX3_VAR_DEPS} \
+    ${@'${SPDX_PACKAGE_SUPPLIER}_name' if d.getVar('SPDX_PACKAGE_SUPPLIER') else ''} \
+    ${@'${SPDX_PACKAGE_SUPPLIER}_type' if d.getVar('SPDX_PACKAGE_SUPPLIER') else ''} \
+"
 
 python do_create_package_spdx_setscene () {
     sstate_setscene(d)
@@ -290,4 +294,3 @@ python spdx30_build_started_handler () {
 
 addhandler spdx30_build_started_handler
 spdx30_build_started_handler[eventmask] = "bb.event.BuildStarted"
-
Signature · 1 line
2.55.0