jffs2: fix double-free of f->target in jffs2_alloc_inode()
PATCH 1/1 jffs2: fix double-free of f->target in jffs2_alloc_inode()
jffs2_alloc_inode() does not initialize f->target before returning the new inode. It is normally cleared later by jffs2_init_inode_info(), called from jffs2_iget(), but that runs only after alloc_inode() has already returned successfully.
If inode_init_always() fails in between, alloc_inode() calls ->free_inode() directly on the half-initialized inode. jffs2_free_inode() then does kfree(f->target) on whatever stale value was left in the reused slab object, which can be a pointer that was already freed, causing a double-free.
Initialize f->target to NULL in jffs2_alloc_inode() to close this window, and clear it in jffs2_free_inode() after freeing it so a reused or re-freed object can never carry a dangling pointer.
--- fs/jffs2/super.c | 2 ++ 1 file changed, 2 insertions(+)
fs/jffs2/super.c +2 -0
@@ -42,6 +42,7 @@ static struct inode *jffs2_alloc_inode(struct super_block *sb) f =alloc_inode_sb (sb, jffs2_inode_cachep,GFP_KERNEL );if (!f)return NULL ; + f->target =NULL ;return &f->vfs_inode; }
@@ -50,6 +51,7 @@ static void jffs2_free_inode(struct inode *inode)struct jffs2_inode_info *f =JFFS2_INODE_INFO (inode);kfree (f->target); + f->target =NULL ;kmem_cache_free (jffs2_inode_cachep, f); }
Signature · 1 line
2.34.1
Quoted 45 lines · Deepanshu Kartikey
jffs2_alloc_inode()does not initializef->targetbefore returning the new inode. It is normally cleared later byjffs2_init_inode_info(), called fromjffs2_iget(), but that runs only afteralloc_inode()has already returned successfully.If
inode_init_always()fails in between,alloc_inode()calls ->free_inode() directly on the half-initialized inode.jffs2_free_inode()then doeskfree(f->target)on whatever stale value was left in the reused slab object, which can be a pointer that was already freed, causing a double-free.Initialize
f->targetto NULL injffs2_alloc_inode()to close this window, and clear it injffs2_free_inode()after freeing it so a reused or re-freed object can never carry a dangling pointer.Fixes 4fdcfab5b553 ("jffs2: fix use-after-free on symlink traversal")Reported-by [email protected]Signed-off-by Deepanshu Kartikey <[email protected]>--- fs/jffs2/super.c | 2 ++ 1 file changed, 2 insertions(+)fs/jffs2/super.c +2
-1@@ -42,6 +42,7 @@ static struct inode *jffs2_alloc_inode(struct super_block *sb) f =alloc_inode_sb (sb, jffs2_inode_cachep,GFP_KERNEL );if (!f)return NULL ; + f->target =NULL ;return &f->vfs_inode; }@@ -50,6 +51,7 @@ static void jffs2_free_inode(struct inode *inode)struct jffs2_inode_info *f =JFFS2_INODE_INFO (inode);kfree (f->target); + f->target =NULL ;kmem_cache_free (jffs2_inode_cachep, f); } --
Quoted 2 lines
2.34.1
Gentle Reminder. Please let me know the status of this patch.
Thanks
Deepanshu
Richard Weinberger
maintainerAm Sat, Sep 12, 2026, 03:08 schrieb Deepanshu Kartikey <[email protected]>:
Quoted 46 lines
Quoted 44 lines · Deepanshu Kartikey
jffs2_alloc_inode()does not initializef->targetbefore returning the new inode. It is normally cleared later byjffs2_init_inode_info(), called fromjffs2_iget(), but that runs only afteralloc_inode()has already returned successfully.If
inode_init_always()fails in between,alloc_inode()calls ->free_inode() directly on the half-initialized inode.jffs2_free_inode()then doeskfree(f->target)on whatever stale value was left in the reused slab object, which can be a pointer that was already freed, causing a double-free.Initialize
f->targetto NULL injffs2_alloc_inode()to close this window, and clear it injffs2_free_inode()after freeing it so a reused or re-freed object can never carry a dangling pointer.Fixes 4fdcfab5b553 ("jffs2: fix use-after-free on symlink traversal")Reported-by [email protected]Signed-off-by Deepanshu Kartikey <[email protected]>--- fs/jffs2/super.c | 2 ++ 1 file changed, 2 insertions(+)fs/jffs2/super.c +2
-0@@ -42,6 +42,7 @@ static struct inode *jffs2_alloc_inode(struct super_block *sb) f =alloc_inode_sb (sb, jffs2_inode_cachep,GFP_KERNEL );if (!f)return NULL ; + f->target =NULL ;return &f->vfs_inode; }@@ -50,6 +51,7 @@ static void jffs2_free_inode(struct inode *inode)struct jffs2_inode_info *f =JFFS2_INODE_INFO (inode);kfree (f->target); + f->target =NULL ;kmem_cache_free (jffs2_inode_cachep, f); }
Quoted 5 lines
Quoted 3 lines
--
2.34.1Gentle Reminder. Please let me know the status of this patch.
We got lot's of identical fixes this issue.
I had no time yet to sort out who was the first.
This is maybe the first report with fix suggestions, but the reporter vanished:
https://lore.kernel.org/linux-mtd/CAFLxGvyZO_EDo-YM_EybZG3u7aNUoNiThhvbhQCrOPD7mPV6GA@mail.gmail.com/
Thanks,
//richard
Quoted 55 lines · Richard Weinberger
Am Sat, Sep 12, 2026, 03:08 schrieb Deepanshu Kartikey <[email protected]>:
Quoted 46 lines
Quoted 44 lines · Deepanshu Kartikey
jffs2_alloc_inode()does not initializef->targetbefore returning the new inode. It is normally cleared later byjffs2_init_inode_info(), called fromjffs2_iget(), but that runs only afteralloc_inode()has already returned successfully.If
inode_init_always()fails in between,alloc_inode()calls ->free_inode() directly on the half-initialized inode.jffs2_free_inode()then doeskfree(f->target)on whatever stale value was left in the reused slab object, which can be a pointer that was already freed, causing a double-free.Initialize
f->targetto NULL injffs2_alloc_inode()to close this window, and clear it injffs2_free_inode()after freeing it so a reused or re-freed object can never carry a dangling pointer.Fixes 4fdcfab5b553 ("jffs2: fix use-after-free on symlink traversal")Reported-by [email protected]Signed-off-by Deepanshu Kartikey <[email protected]>--- fs/jffs2/super.c | 2 ++ 1 file changed, 2 insertions(+)fs/jffs2/super.c +2
-0@@ -42,6 +42,7 @@ static struct inode *jffs2_alloc_inode(struct super_block *sb) f =alloc_inode_sb (sb, jffs2_inode_cachep,GFP_KERNEL );if (!f)return NULL ; + f->target =NULL ;return &f->vfs_inode; }@@ -50,6 +51,7 @@ static void jffs2_free_inode(struct inode *inode)struct jffs2_inode_info *f =JFFS2_INODE_INFO (inode);kfree (f->target); + f->target =NULL ;kmem_cache_free (jffs2_inode_cachep, f); }Quoted 5 lines
Quoted 3 lines
--
2.34.1Gentle Reminder. Please let me know the status of this patch.
Quoted 9 lines
We got lot's of identical fixes this issue.
I had no time yet to sort out who was the first.
This is maybe the first report with fix suggestions, but the reporter vanished:
https://lore.kernel.org/linux-mtd/CAFLxGvyZO_EDo-YM_EybZG3u7aNUoNiThhvbhQCrOPD7mPV6GA@mail.gmail.com/Thanks,
//richard
I feel the patch you are pointing at fixes a different kind of issue ?
Richard Weinberger
maintainerAm Sat, Sep 12, 2026, 10:00 schrieb Deepanshu Kartikey <[email protected]>:
Quoted 2 lines · Richard Weinberger
I feel the patch you are pointing at fixes a different kind of issue ?
Well, different symptoms of a common root cause.
Thanks,
//richard
Quoted 9 lines · Richard Weinberger
Am Sat, Sep 12, 2026, 10:00 schrieb Deepanshu Kartikey <[email protected]>:
Quoted 2 lines · Richard Weinberger
I feel the patch you are pointing at fixes a different kind of issue ?
Well, different symptoms of a common root cause.
Thanks,
//richard
Totally understood this. But it is good to have a defensive check so that there is no dangling pointer. It will prevent future [UAF, double free bugs].
Thanks
Deepanshu
Quoted 12 lines · Deepanshu Kartikey
Quoted 9 lines · Richard Weinberger
Am Sat, Sep 12, 2026, 10:00 schrieb Deepanshu Kartikey <[email protected]>:
Quoted 2 lines · Richard Weinberger
I feel the patch you are pointing at fixes a different kind of issue ?
Well, different symptoms of a common root cause.
Thanks,
//richard
Quoted 6 lines
Totally understood this. But it is good to have a defensive check so that there is no dangling pointer. It will prevent future [UAF, double free bugs].
Thanks
Deepanshu
Let me know the status of this patch
Thanks
Deepanshu