Skip to contentSkip to conversation

mfd: da9062: Use DEFINE_RES_IRQ_NAMED()

PATCH Applied Hiroki Nakajima 3 participants 3 messages Aug 23 – Sep 3

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: da9062: Use DEFINE_RES_IRQ_NAMED()

Use the dedicated DEFINE_RES_IRQ_NAMED() helper for the DA9062 IRQ resources instead of open-coding it with DEFINE_RES_NAMED(). This makes the intended resource type explicit and keeps the definitions consistent with the DA9061 resources.

This is a mechanical cleanup with no functional change.

With an x86_64 allmodconfig and W=1, drivers/mfd/da9062-core.o builds successfully and is byte-identical before and after this change.

Assisted-by Codex:gpt-5 coccinelle
---
 drivers/mfd/da9062-core.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/mfd/da9062-core.c +12 -12
index 637c5f47a4b0..ad198183aff7 100644
@@ -203,36 +203,36 @@ static const struct mfd_cell da9061_devs_noirq[] = {
 };
 
 static const struct resource da9062_core_resources[] = {
-	DEFINE_RES_NAMED(DA9062_IRQ_VDD_WARN, 1, "VDD_WARN", IORESOURCE_IRQ),
+	DEFINE_RES_IRQ_NAMED(DA9062_IRQ_VDD_WARN, "VDD_WARN"),
 };
 
 static const struct resource da9062_regulators_resources[] = {
-	DEFINE_RES_NAMED(DA9062_IRQ_LDO_LIM, 1, "LDO_LIM", IORESOURCE_IRQ),
+	DEFINE_RES_IRQ_NAMED(DA9062_IRQ_LDO_LIM, "LDO_LIM"),
 };
 
 static const struct resource da9062_thermal_resources[] = {
-	DEFINE_RES_NAMED(DA9062_IRQ_TEMP, 1, "THERMAL", IORESOURCE_IRQ),
+	DEFINE_RES_IRQ_NAMED(DA9062_IRQ_TEMP, "THERMAL"),
 };
 
 static const struct resource da9062_wdt_resources[] = {
-	DEFINE_RES_NAMED(DA9062_IRQ_WDG_WARN, 1, "WD_WARN", IORESOURCE_IRQ),
+	DEFINE_RES_IRQ_NAMED(DA9062_IRQ_WDG_WARN, "WD_WARN"),
 };
 
 static const struct resource da9062_rtc_resources[] = {
-	DEFINE_RES_NAMED(DA9062_IRQ_ALARM, 1, "ALARM", IORESOURCE_IRQ),
-	DEFINE_RES_NAMED(DA9062_IRQ_TICK, 1, "TICK", IORESOURCE_IRQ),
+	DEFINE_RES_IRQ_NAMED(DA9062_IRQ_ALARM, "ALARM"),
+	DEFINE_RES_IRQ_NAMED(DA9062_IRQ_TICK, "TICK"),
 };
 
 static const struct resource da9062_onkey_resources[] = {
-	DEFINE_RES_NAMED(DA9062_IRQ_ONKEY, 1, "ONKEY", IORESOURCE_IRQ),
+	DEFINE_RES_IRQ_NAMED(DA9062_IRQ_ONKEY, "ONKEY"),
 };
 
 static const struct resource da9062_gpio_resources[] = {
-	DEFINE_RES_NAMED(DA9062_IRQ_GPI0, 1, "GPI0", IORESOURCE_IRQ),
-	DEFINE_RES_NAMED(DA9062_IRQ_GPI1, 1, "GPI1", IORESOURCE_IRQ),
-	DEFINE_RES_NAMED(DA9062_IRQ_GPI2, 1, "GPI2", IORESOURCE_IRQ),
-	DEFINE_RES_NAMED(DA9062_IRQ_GPI3, 1, "GPI3", IORESOURCE_IRQ),
-	DEFINE_RES_NAMED(DA9062_IRQ_GPI4, 1, "GPI4", IORESOURCE_IRQ),
+	DEFINE_RES_IRQ_NAMED(DA9062_IRQ_GPI0, "GPI0"),
+	DEFINE_RES_IRQ_NAMED(DA9062_IRQ_GPI1, "GPI1"),
+	DEFINE_RES_IRQ_NAMED(DA9062_IRQ_GPI2, "GPI2"),
+	DEFINE_RES_IRQ_NAMED(DA9062_IRQ_GPI3, "GPI3"),
+	DEFINE_RES_IRQ_NAMED(DA9062_IRQ_GPI4, "GPI4"),
 };
 
 static const struct mfd_cell da9062_devs_irq[] = {

base-commit: 9d0e4b1ae5b045a2c92b0b9a1c3b268191c219d9

Signature · 1 line
2.34.1
#1 lore raw
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 5 lines

Use the dedicated DEFINE_RES_IRQ_NAMED() helper for the DA9062 IRQ resources instead of open-coding it with DEFINE_RES_NAMED(). This makes the intended resource type explicit and keeps the definitions consistent with the DA9061 resources.

Quoted 7 lines

This is a mechanical cleanup with no functional change.

With an x86_64 allmodconfig and W=1, drivers/mfd/da9062-core.o builds successfully and is byte-identical before and after this change.

Assisted-by Codex:gpt-5 coccinelle

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
maintainer Applied
#2 lore raw

Re: (subset) [PATCH] mfd: da9062: Use DEFINE_RES_IRQ_NAMED()

In reply to Hiroki Nakajima
Quoted 8 lines · Hiroki Nakajima

Use the dedicated DEFINE_RES_IRQ_NAMED() helper for the DA9062 IRQ resources instead of open-coding it with DEFINE_RES_NAMED(). This makes the intended resource type explicit and keeps the definitions consistent with the DA9061 resources.

This is a mechanical cleanup with no functional change.

[...]

Applied, thanks!

[1/1] mfd: da9062: Use DEFINE_RES_IRQ_NAMED()

      commit: 8d0b4b0bef6538ace326afde928eb91f5bce0f9b

--
Lee Jones [李琼斯]