FAILED: patch "[PATCH] ext4: zero out whole block for clean edges in WRITE_ZEROES" failed to apply to 6.18-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 6.18-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.18.y
git checkout FETCH_HEAD
git cherry-pick -x a5179156ac1d9a6646da42254e4c461e1fc20096
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026082408-bogged-oozy-15cf@gregkh' --subject-prefix 'PATCH 6.18.y' 'HEAD^..'
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From a5179156ac1d9a6646da42254e4c461e1fc20096 Mon Sep 17 00:00:00 2001
From: Zhang Yi <[email protected]>
Date: Tue, 14 Jul 2026 16:00:42 +0800
Subject: [PATCH] ext4: zero out whole block for clean edges in WRITE_ZEROES
FALLOC_FL_WRITE_ZEROES requires that all blocks in the requested range end up as written extents with zeroed content. For unaligned edges that were already allocated, ext4_zero_partial_blocks() zeros them directly. However, for unaligned edges whose underlying extent is a clean unwritten extent or a hole, the extent type remains unwritten after partial zeroing, which does not align with the semantics of WRITE_ZEROES.
Therefore, when ext4_zero_partial_blocks() skips partial zeroing, it indicates that the corresponding edges are clean unwritten extents or holes. In this case, we need to expand the aligned allocation range outward to cover such edges, so that ext4_alloc_file_blocks() can correctly allocate blocks for the unaligned range. Edges that were partial-zeroed (i.e., written or dirty) are left untouched.
fs/ext4/extents.c +15 -0
@@ -4760,6 +4760,21 @@ static long ext4_zero_range(struct file *file, loff_t offset,/* Zero range excluding the unaligned edges */ align_start =round_up (offset, blocksize); align_end =round_down (end, blocksize); + +/* +* In WRITE_ZEROES mode, edges that were not partial-zeroed (clean +* unwritten or hole) must be allocated and zeroed as whole blocks. +* Expand the aligned range outward to cover them. +*/ +if (mode &FALLOC_FL_WRITE_ZEROES ) { +if (!IS_ALIGNED (offset, blocksize) && + !(partial_zeroed &EXT4_PARTIAL_ZERO_START )) + align_start =round_down (offset, blocksize); +if (!IS_ALIGNED (end, blocksize) && + !(partial_zeroed &EXT4_PARTIAL_ZERO_END )) + align_end =round_up (end, blocksize); + } +if (align_end > align_start) {if (mode &FALLOC_FL_WRITE_ZEROES ) flags =EXT4_GET_BLOCKS_CREATE_ZERO |EXT4_EX_NOCACHE ;