Skip to contentSkip to conversation

dm-integrity: require stable writes for internal hash modes

PATCH New Chen Cheng 1 participant 1 message Aug 24 Device mapper

lore
Share & tools
lore

Chen Cheng

author
#0 lore raw

PATCH 1/1 dm-integrity: require stable writes for internal hash modes

From: Chen Cheng <[email protected]>

dm-integrity direct, bitmap and inline internal-hash modes compute integrity tags from the pages carried by the write bio. The lower data write also uses those pages, so the tag and the data write depend on the same memory contents staying unchanged while writeback is in flight.

Without stable writes, a buffered writer can modify a writeback folio after dm-integrity has submitted the data bio and before the lower device has consumed the data. After a crash, this can leave data from the later contents with a tag calculated from the earlier contents, causing permanent checksum failures on read.

Set BLK_FEAT_STABLE_WRITES for internal-hash D, B and I modes so filesystems wait for writeback folios to become stable before modifying them again. Journal mode is left unchanged because it copies data into the journal before computing and persisting the tag.

Tested using dm-delay over a virtio-blk test disk, dm-integrity internal_hash:crc32c and no-journal ext4. The D and B reproducers both failed with checksum errors before this change and completed with READ_RC=0 and zero mismatches after it.

---
 drivers/md/dm-integrity.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/md/dm-integrity.c +4 -0
index 1f2593f113f6..49fb7561a30f 100644
@@ -4044,10 +4044,14 @@ static void dm_integrity_io_hints(struct dm_target *ti, struct queue_limits *lim
 
 	dm_stack_bs_limits(limits, ic->sectors_per_block << SECTOR_SHIFT);
 	limits->dma_alignment = limits->logical_block_size - 1;
 	limits->discard_granularity = ic->sectors_per_block << SECTOR_SHIFT;
 
+	if (ic->internal_hash &&
+	    (ic->mode == 'D' || ic->mode == 'B' || ic->mode == 'I'))
+		limits->features |= BLK_FEAT_STABLE_WRITES;
+
 	if (!ic->internal_hash) {
 		struct blk_integrity *bi = &limits->integrity;
 
 		memset(bi, 0, sizeof(*bi));
 		bi->metadata_size = ic->tag_size;
Signature · 1 line
2.55.0