common/xfs: filter mkfs.xfs stripe geometry warning
PATCH 1/1 common/xfs: filter mkfs.xfs stripe geometry warning
mkfs.xfs prints a warning when creating small filesystems on devices that advertise stripe geometry:
mkfs.xfs: small data volume, ignoring data volume stripe unit XXX and stripe width XXX
This warning causes several XFS tests to fail their golden output comparison when SCRATCH_DEV has striped device geometry such as scsi_debug devices.
Filter the warning in _try_scratch_mkfs_xfs() instead of updating individual test expected outputs, as the filesystem is created successfully and the warning does not indicate a failure.
---
Tested with xfs/015, xfs/030, xfs/041, xfs/042, xfs/075, xfs/104, xfs/109, xfs/168 and xfs/177.
Output for xfs/030 before the filter:
QA output created by 030
...
+mkfs.xfs: small data volume, ignoring data volume stripe unit 64 and stripe width 64
...
Ran: xfs/030
Failures: xfs/030
Failed 1 of 1 tests
Output for xfs/030 after adding the filter:
xfs/030 15s
Ran: xfs/030
Passed all 1 tests
common/xfs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
common/xfs +2 -1
@@ -157,7 +157,8 @@ _try_scratch_mkfs_xfs() local mkfs_cmd="`_scratch_mkfs_xfs_opts`" local mkfs_filter="sed -e '/less than device physical sector/d' \ -e '/switching to logical sector/d' \ - -e '/Default configuration/d'" + -e '/Default configuration/d' \ + -e '/small data volume, ignoring data volume stripe unit/d'" local tmp=`mktemp -u` local mkfs_status
Signature · 1 line
2.54.0
Quoted 15 lines · Manognya Singuru
mkfs.xfs prints a warning when creating small filesystems on devices that advertise stripe geometry:
mkfs.xfs: small data volume, ignoring data volume stripe unit XXX and stripe width XXX
This warning causes several XFS tests to fail their golden output comparison when
SCRATCH_DEVhas striped device geometry such asscsi_debugdevices.Filter the warning in
_try_scratch_mkfs_xfs()instead of updating individual test expected outputs, as the filesystem is created successfully and the warning does not indicate a failure.Signed-off-by Manognya Singuru <[email protected]>
Quoted 8 lines
---
Tested with xfs/015, xfs/030, xfs/041, xfs/042, xfs/075, xfs/104, xfs/109, xfs/168 and xfs/177.Output for xfs/030 before the filter:
QA output created by 030
...
+mkfs.xfs: small data volume, ignoring data volume stripe unit 64 and
How big is this volume? I'm guessing less than a gigabyte or two?
Quoted 19 lines
stripe width 64
...
Ran: xfs/030
Failures: xfs/030
Failed 1 of 1 testsOutput for xfs/030 after adding the filter:
xfs/030 15s
Ran: xfs/030
Passed all 1 testscommon/xfs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)common/xfs +0
-0
common/xfs _try_scratch_mkfs_xfs() · line 161
Quoted 6 lines
common/xfs +2
-1@@ -157,7 +157,8 @@ _try_scratch_mkfs_xfs() local mkfs_cmd="`_scratch_mkfs_xfs_opts`" local mkfs_filter="sed -e '/less than device physical sector/d' \ -e '/switching to logical sector/d' \ - -e '/Default configuration/d'" + -e '/Default configuration/d' \ + -e '/small data volume, ignoring data volume stripe unit/d'"
But yeah, that's not output that we care about.
--D
Quoted 7 lines
common/xfs +0
-0local tmp=`mktemp -u` local mkfs_statusSignature · 1 line
2.54.0
Quoted 21 lines · Darrick J. Wong
Quoted 19 lines · Manognya Singuru
mkfs.xfs prints a warning when creating small filesystems on devices that advertise stripe geometry:
mkfs.xfs: small data volume, ignoring data volume stripe unit XXX and stripe width XXX
This warning causes several XFS tests to fail their golden output comparison when
SCRATCH_DEVhas striped device geometry such asscsi_debugdevices.Filter the warning in
_try_scratch_mkfs_xfs()instead of updating individual test expected outputs, as the filesystem is created successfully and the warning does not indicate a failure.Signed-off-by Manognya Singuru <[email protected]>---
Tested with xfs/015, xfs/030, xfs/041, xfs/042, xfs/075, xfs/104, xfs/109, xfs/168 and xfs/177.
Quoted 7 lines
Quoted 4 lines
Output for xfs/030 before the filter:
QA output created by 030
...
+mkfs.xfs: small data volume, ignoring data volume stripe unit 64 andHow big is this volume? I'm guessing less than a gigabyte or two?
Yes, It is 1 gigabyte.
Quoted 14 lines
Quoted 14 lines
stripe width 64
...
Ran: xfs/030
Failures: xfs/030
Failed 1 of 1 testsOutput for xfs/030 after adding the filter:
xfs/030 15s
Ran: xfs/030
Passed all 1 testscommon/xfs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 13 lines
common/xfs _try_scratch_mkfs_xfs() · line 161
Quoted 11 lines
common/xfs +2
-1@@ -157,7 +157,8 @@ _try_scratch_mkfs_xfs() local mkfs_cmd="`_scratch_mkfs_xfs_opts`" local mkfs_filter="sed -e '/less than device physical sector/d' \ -e '/switching to logical sector/d' \ - -e '/Default configuration/d'" + -e '/Default configuration/d' \ + -e '/small data volume, ignoring data volume stripe unit/d'"But yeah, that's not output that we care about.
Yes, many tests fail due to these extra lines in the output.
Quoted 12 lines
Reviewed-by "Darrick J. Wong" <[email protected]>--D
Quoted 7 lines
common/xfs +0
-1local tmp=`mktemp -u` local mkfs_status --2.54.0
Quoted 27 lines · Manognya Singuru
Quoted 26 lines · Darrick J. Wong
Quoted 23 lines · Manognya Singuru
mkfs.xfs prints a warning when creating small filesystems on devices that advertise stripe geometry:
mkfs.xfs: small data volume, ignoring data volume stripe unit XXX and stripe width XXX
This warning causes several XFS tests to fail their golden output comparison when
SCRATCH_DEVhas striped device geometry such asscsi_debugdevices.Filter the warning in
_try_scratch_mkfs_xfs()instead of updating individual test expected outputs, as the filesystem is created successfully and the warning does not indicate a failure.Signed-off-by Manognya Singuru <[email protected]>---
Tested with xfs/015, xfs/030, xfs/041, xfs/042, xfs/075, xfs/104, xfs/109, xfs/168 and xfs/177.Output for xfs/030 before the filter:
QA output created by 030
...
+mkfs.xfs: small data volume, ignoring data volume stripe unit 64 and
Quoted 4 lines
Quoted 2 lines
How big is this volume? I'm guessing less than a gigabyte or two?
Yes, It is 1 gigabyte.
If you're curious, you can demonstrate it with a device like:
modprobe scsi_debug dev_size_mb=1024 opt_xferlen_exp=6 opt_blks=64
- that makes a 1G device with the stripe unit 8 and stripe width 8 from mkfs.xfs's perspective
I think I saw this in "real" testing in some environment but I'm afraid I don't remember how big (small) those devices actually were. The code looks like it only emits it for < GIGABLOCKS(1 ...) but I don't know why I would have been testing with a 1G device.
Worth filtering out anyway, I think.
-Eric
Quoted 45 lines
Quoted 15 lines
Quoted 15 lines
stripe width 64
...
Ran: xfs/030
Failures: xfs/030
Failed 1 of 1 testsOutput for xfs/030 after adding the filter:
xfs/030 15s
Ran: xfs/030
Passed all 1 testscommon/xfs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 13 lines
common/xfs _try_scratch_mkfs_xfs() · line 161
Quoted 11 lines
common/xfs +2
-1@@ -157,7 +157,8 @@ _try_scratch_mkfs_xfs() local mkfs_cmd="`_scratch_mkfs_xfs_opts`" local mkfs_filter="sed -e '/less than device physical sector/d' \ -e '/switching to logical sector/d' \ - -e '/Default configuration/d'" + -e '/Default configuration/d' \ + -e '/small data volume, ignoring data volume stripe unit/d'"But yeah, that's not output that we care about.
Yes, many tests fail due to these extra lines in the output.
Quoted 12 lines
Reviewed-by "Darrick J. Wong" <[email protected]>--D
Quoted 7 lines
common/xfs +0
-1local tmp=`mktemp -u` local mkfs_status --2.54.0