Skip to contentSkip to conversation

hw/misc/vmlaunchupdate: do not clear control bits upon fw-cfg select op

PATCH New Ani Sinha 1 participant 1 message Aug 25

lore
Share & tools
lore

Ani Sinha

author
#0 lore raw

PATCH 1/1 hw/misc/vmlaunchupdate: do not clear control bits upon fw-cfg select op

The control bits define the behavior of the interface and clearing the bits upon reading or select operation will break that behavior. For example, after CTL_HOST_IGVM is set by the guest through a write and then subsequently, if the guest tried to read back the values from the fw-cfg interface, the read would clear CTL_HOST_IGVM. This would break restoring the host IGVM upon subsequent reset.

Fixes 30688c02a76e50e4 ("hw/misc/vmlaunchupdate: Introduce hypervisor fw-cfg interface support")
---
 hw/misc/vmlaunchupdate.c | 1 -
 1 file changed, 1 deletion(-)
hw/misc/vmlaunchupdate.c +0 -1
index afa2d278ae..847d2d963f 100644
@@ -41,7 +41,6 @@ static bool vmlaunchupdate_supported(void)
 static void init_vm_launch_update(VMLaunchUpdateState *s)
 {
     s->launch_update.capabilities = VM_LAUNCHUPDATE_FORMAT_IGVM;
-    s->launch_update.control = 0;
 
     if (s->disabled) {
         s->launch_update.control |= VM_LAUNCHUPDATE_CTL_DISABLE;
Signature · 1 line
2.42.0