Skip to contentSkip to conversation

drm/i915/dp: remove redundant link state check

PATCH New [email protected] 3 participants 4 messages Aug 26

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/dp: remove redundant link state check

From: tarun-tarun143 <[email protected]>

The DP link state is now checked and recovered after link training, including after modesets. The same recovery path is also used from the hotplug and HPD IRQ paths.

The link state check from intel_dp_detect() is therefore redundant. Remove it and rely on the existing link recovery paths.

---
 drivers/gpu/drm/i915/display/intel_dp.c | 12 ------------
 1 file changed, 12 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +0 -12
index 113d767e62e9..ffd39206b958 100644
@@ -6379,18 +6379,6 @@ intel_dp_detect(struct drm_connector *_connector,
 		status = connector_status_disconnected;
 		goto out_unset_edid;
 	}
-
-	/*
-	 * Some external monitors do not signal loss of link synchronization
-	 * with an IRQ_HPD, so force a link status check.
-	 *
-	 * TODO: this probably became redundant, so remove it: the link state
-	 * is rechecked/recovered now after modesets, where the loss of
-	 * synchronization tends to occur.
-	 */
-	if (!intel_dp_is_edp(intel_dp))
-		intel_dp_check_link_state(intel_dp);
-
 	/*
 	 * Clearing NACK and defer counts to get their exact values
 	 * while reading EDID which are required by Compliance tests
Signature · 1 line
2.43.0
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Removing the DP link state check from `intel_dp_detect()` breaks recovery for monitors that drop…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Removing the DP link state check from intel_dp_detect() breaks recovery for monitors that drop link synchronization silently (without sending an HPD IRQ). --

commit 26b9e2acc7df07dcc2e2026421a5c54d7a72b52e
Author: tarun-tarun143 <[email protected]>

drm/i915/dp: remove redundant link state check

This commit removes the DP link state check from intel_dp_detect(), relying instead on the link recovery paths after modesets and hotplug events.

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -2
index 113d767e62e9c..ffd39206b958e 100644
@@ -6379,18 +6379,6 @@ intel_dp_detect(struct drm_connector *_connector,
 		status = connector_status_disconnected;
 		goto out_unset_edid;
 	}
-
-	/*

drivers/gpu/drm/i915/display/intel_dp.c intel_dp_detect(struct drm_connector *_connector, · line 6393

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -10
-	 * Some external monitors do not signal loss of link synchronization
-	 * with an IRQ_HPD, so force a link status check.
-	 *
-	 * TODO: this probably became redundant, so remove it: the link state
-	 * is rechecked/recovered now after modesets, where the loss of
-	 * synchronization tends to occur.
-	 */
-	if (!intel_dp_is_edp(intel_dp))
-		intel_dp_check_link_state(intel_dp);
-

[Severity: Medium]
Does removing this check break recovery for monitors that drop link synchronization silently?

While the link state is recovered after modesets and hotplug events, some non-compliant monitors fail to assert an HPD IRQ when the main link drops due to issues like EMI. When this hardware failure happens, a user or desktop environment running a probe calls intel_dp_detect().

Before this patch, intel_dp_detect() would read the DPCD link status and queue a link retrain, acting as a manual fallback. By removing this check, intel_dp_detect() succeeds via the independent AUX channel but ignores the broken main link. Will this leave users with a permanent blank screen until a full modeset or physical replug is performed?

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_dp.c +0 -0
 	/*
 	 * Clearing NACK and defer counts to get their exact values
 	 * while reading EDID which are required by Compliance tests
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#2 lore raw

✗ LGCI.VerificationFailed: failure for drm/i915/dp: remove redundant link state check

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: drm/i915/dp: remove redundant link state check
URL : https://patchwork.freedesktop.org/series/172818/
State : failure

== Summary ==

Series author address '[email protected]' is not on the allowlist, which prevents CI from being automatically triggered. If you want CI to run for this series, ask Patchwork project owners to click 'retest' on the series in Patchwork. Exception occurred during validation, bailing out!
Build URL: http://intel-gfx-ci-public.igk.intel.com:8080/job/xe_pw_trigger/1262186/ (on master)

#3 lore raw

✗ LGCI.VerificationFailed: failure for drm/i915/dp: remove redundant link state check (rev2)

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: drm/i915/dp: remove redundant link state check (rev2)
URL : https://patchwork.freedesktop.org/series/172819/
State : failure

== Summary ==

Series author address '[email protected]' is not on the allowlist, which prevents CI from being automatically triggered. If you want CI to run for this series, ask Patchwork project owners to click 'retest' on the series in Patchwork. Exception occurred during validation, bailing out!
Build URL: http://gfx-ci.igk.intel.com:8080/job/CI_PW_kernel/185621/ (on built-in)