staging: rtl8723bs: use strscpy() for ifname copy
PATCH 1/1 staging: rtl8723bs: use strscpy() for ifname copy
Replace snprintf() with strscpy() when copying ifname into registry_par to avoid unnecessary format specifier parsing.
Signed-off-by Svyatoslav Nikolenko <[email protected]>
--- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -1
@@ -256,7 +256,7 @@ static void loadparam(struct adapter *padapter, struct net_device *pnetdev) registry_par->enable80211d = (u8 )rtw_80211d; -snprintf (registry_par->ifname,16 ,"%s" , ifname); +strscpy (registry_par->ifname, ifname,sizeof (registry_par->ifname)); registry_par->notch_filter = (u8 )rtw_notch_filter;
Signature · 1 line
2.47.3
Greg Kroah-Hartman
maintainerQuoted 13 lines · Svyatoslav Nikolenko
Replace
snprintf()withstrscpy()when copying ifname intoregistry_parto avoid unnecessary format specifier parsing.Signed-off-by Svyatoslav Nikolenko <[email protected]>--- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8723bs/os_dep/os_intfs.c +0
-0
drivers/staging/rtl8723bs/os_dep/os_intfs.c static void loadparam(struct adapter *padapter, struct net_device *pnetdev) · line 261
Quoted 7 lines
drivers/staging/rtl8723bs/os_dep/os_intfs.c +1
-1@@ -256,7 +256,7 @@ static void loadparam(struct adapter *padapter, struct net_device *pnetdev) registry_par->enable80211d = (u8 )rtw_80211d; -snprintf (registry_par->ifname,16 ,"%s" , ifname); +strscpy (registry_par->ifname, ifname,sizeof (registry_par->ifname)); registry_par->notch_filter = (u8 )rtw_notch_filter;
the ifname module option, and field, should just be removed from this driver entirely. Can you do that instead?
thanks,
greg k-h