nvmet: reject namespace enable without device path
Subsystems (2)
PATCH 1/1 nvmet: reject namespace enable without device path
A newly allocated namespace has a NULL device_path until userspace configures the device_path attribute.
If buffered_io is enabled before device_path is configured, nvmet_bdev_ns_enable() returns -ENOTBLK and nvmet_ns_enable() falls back to nvmet_file_ns_enable(). The latter passes the NULL device_path to filp_open(), causing a NULL pointer dereference in getname_kernel().
Reject namespace enable when device_path has not been configured.
--- drivers/nvme/target/core.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/nvme/target/core.c +5 -0
@@ -591,6 +591,11 @@ int nvmet_ns_enable(struct nvmet_ns *ns)if (ns->enabled) goto out_unlock; +if (!ns->device_path) { + ret = -EINVAL ; + goto out_unlock; + } + ret =nvmet_bdev_ns_enable (ns);if (ret == -ENOTBLK ) ret =nvmet_file_ns_enable (ns);
Signature · 1 line
2.53.0
Looks good:
Quoted 10 lines · Seokgyu Choi
A newly allocated namespace has a NULL
device_pathuntil userspace configures thedevice_pathattribute.If
buffered_iois enabled beforedevice_pathis configured,nvmet_bdev_ns_enable()returns-ENOTBLKandnvmet_ns_enable()falls back tonvmet_file_ns_enable(). The latter passes the NULLdevice_pathtofilp_open(), causing a NULL pointer dereference ingetname_kernel().Reject namespace enable when
device_pathhas not been configured.
Thanks, applied to nvme-7.3.