wifi: mt76: mt7925: restore the reset state when fw_pmctrl fails
Subsystems (2)
Felix Fietkau
maintainerPATCH 1/1 wifi: mt76: mt7925: restore the reset state when fw_pmctrl fails
mt7925e_mac_reset() returns directly when mt792xe_mcu_fw_pmctrl() fails, leaving MT76_RESET set and the TX worker parked. Every other error path jumps to out, which clears both. mt7925_mac_reset_work() clears neither, so once every reset attempt fails there, TX stays blocked until another reset succeeds.
Jump to out instead.
Fixes c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt7925 chips")
Signed-off-by Felix Fietkau <[email protected]>
--- drivers/net/wireless/mediatek/mt76/mt7925/pci_mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/mediatek/mt76/mt7925/pci_mac.c +1 -1
@@ -127,7 +127,7 @@ int mt7925e_mac_reset(struct mt792x_dev *dev) err =mt792xe_mcu_fw_pmctrl (dev);if (err) -return err; + goto out; err =__mt792xe_mcu_drv_pmctrl (dev);if (err)
Signature · 1 line
2.47.3
Quoted 10 lines
mt7925e_mac_reset()returns directly whenmt792xe_mcu_fw_pmctrl()fails, leavingMT76_RESETset and the TX worker parked. Every other error path jumps to out, which clears both.mt7925_mac_reset_work()clears neither, so once every reset attempt fails there, TX stays blocked until another reset succeeds.Jump to out instead.
Fixes c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt7925 chips")Signed-off-by Felix Fietkau <[email protected]>
Acked-by Lorenzo Bianconi <[email protected]>
Quoted 21 lines
--- drivers/net/wireless/mediatek/mt76/mt7925/pci_mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/wireless/mediatek/mt76/mt7925/pci_mac.c +1
-1@@ -127,7 +127,7 @@ int mt7925e_mac_reset(struct mt792x_dev *dev) err =mt792xe_mcu_fw_pmctrl (dev);if (err) -return err; + goto out; err =__mt792xe_mcu_drv_pmctrl (dev);if (err)Signature · 1 line
2.47.3