Skip to contentSkip to conversation

package/collectd: fix build of virt plugin

PATCH Applied Thomas Petazzoni via buildroot 1 participant 3 messages Aug 27 – Sep 4

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/collectd: fix build of virt plugin

Since the bump of libxml2 from 2.13.8 to 2.15.0 in Buildroot commit d81922c1ef8825f10b802984d9721412a1a1a377, the "virt" plugin of collectd no longer builds:

src/virt.c:2208:49: error: expected ';', ',' or ')' before 'ATTRIBUTE_UNUSED'
2208 | static void virt_eventloop_timeout_cb(int timer ATTRIBUTE_UNUSED,

      |                                                 ^~~~~~~~~~~~~~~~
src/virt.c: In function 'register_event_impl':
src/virt.c:2221:26: error: 'virt_eventloop_timeout_cb' undeclared (first use in this function)
 2221 |                          virt_eventloop_timeout_cb, NULL, NULL) < 0) {
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~

src/virt.c:2221:26: note: each undeclared identifier is reported only once for each function it appears in

This is due to the fact that the virt plugin code was incorrectly using the ATTRIBUTE_UNUSED define, which was supposed to be an internal define of libxml2. But it turns out that up to libxml2 2.14.0 and its commit 208f27f9641a59863ce1f7d4992df77f7eb0ea9d, this define had been made publicly available. It could therefore mistakenly be used by collectd's virt plugin... until libxml2 was upgraded.

We backport an upstream patch from collectd that fixes the issue.

Fixes:

https://autobuild.buildroot.net/results/4c8463f0372560f4c3a20b0f67854460f0d1c400/

---
 ...UTE_UNUSED-for-virt_eventloop_timeou.patch | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 package/collectd/0006-virt-Drop-ATTRIBUTE_UNUSED-for-virt_eventloop_timeou.patch
package/collectd/0006-virt-Drop-ATTRIBUTE_UNUSED-for-virt_eventloop_timeou.patch new file +45 -0
new file mode 100644
index 0000000000..6cf0a55ba2
@@ -0,0 +1,45 @@
+From be6ac1ed28b4842e8f2e54c39a2b3fc48feaf8b2 Mon Sep 17 00:00:00 2001
+From: "Matwey V. Kornilov" <[email protected]>
+Date: Sun, 26 Oct 2025 18:36:56 +0300
+Subject: [PATCH] virt: Drop ATTRIBUTE_UNUSED for virt_eventloop_timeout_cb
+
+ATTRIBUTE_UNUSED seems to be never was a public part of the libvirt interface
+and leads to the following issue with recent libvirt versions were
+ATTRIBUTE_UNUSED has been renamed to G_GNUC_UNUSED:
+
+src/virt.c:2209:49: error: expected ';', ',' or ')' before 'ATTRIBUTE_UNUSED'
+ 2209 | static void virt_eventloop_timeout_cb(int timer ATTRIBUTE_UNUSED,
+      |                                                 ^~~~~~~~~~~~~~~~
+src/virt.c: In function 'register_event_impl':
+src/virt.c:2222:26: error: 'virt_eventloop_timeout_cb' undeclared (first use in this function)
+ 2222 |                          virt_eventloop_timeout_cb, NULL, NULL) < 0) {
+      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~
+src/virt.c:2222:26: note: each undeclared identifier is reported only once for each function it appears in
+
+Drop ATTRIBUTE_UNUSED here as there is little use from it.
+
+Upstream: https://github.com/collectd/collectd/commit/050877ed952ffc15c849803a9b3e77c5cec15f81
+Signed-off-by: Thomas Petazzoni <[email protected]>
+---
+ src/virt.c | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/src/virt.c b/src/virt.c
+index 01c7c777..ee0440e9 100644
+--- a/src/virt.c
++++ b/src/virt.c
+@@ -2205,8 +2205,9 @@ static int domain_lifecycle_event_cb(__attribute__((unused)) virConnectPtr con_,
+   return 0;
+ }
+ 
+-static void virt_eventloop_timeout_cb(int timer ATTRIBUTE_UNUSED,
+-                                      void *timer_info) {}
++static void
++virt_eventloop_timeout_cb(__attribute__((unused)) int timer,
++                          __attribute__((unused)) void *timer_info) {}
+ 
+ static int register_event_impl(void) {
+   if (virEventRegisterDefaultImpl() < 0) {
+-- 
+2.55.0
+
Signature · 6 lines
2.55.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 23 lines · Thomas Petazzoni via buildroot

Since the bump of libxml2 from 2.13.8 to 2.15.0 in Buildroot commit d81922c1ef8825f10b802984d9721412a1a1a377, the "virt" plugin of collectd no longer builds:

src/virt.c:2208:49: error: expected ';', ',' or ')' before 'ATTRIBUTE_UNUSED'
2208 | static void virt_eventloop_timeout_cb(int timer
ATTRIBUTE_UNUSED,

      |                                                 

^~~~~~~~~~~~~~~~
src/virt.c: In function 'register_event_impl':
src/virt.c:2221:26: error: 'virt_eventloop_timeout_cb' undeclared (first use in this function)
2221 | virt_eventloop_timeout_cb, NULL, NULL)

< 0) {
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~

src/virt.c:2221:26: note: each undeclared identifier is reported only once for each function it appears in

This is due to the fact that the virt plugin code was incorrectly using the ATTRIBUTE_UNUSED define, which was supposed to be an internal define of libxml2. But it turns out that up to libxml2 2.14.0 and its commit 208f27f9641a59863ce1f7d4992df77f7eb0ea9d, this define had been made publicly available. It could therefore mistakenly be used by collectd's virt plugin... until libxml2 was upgraded.

Quoted 8 lines

We backport an upstream patch from collectd that fixes the issue.

Fixes:

https://autobuild.buildroot.net/results/4c8463f0372560f4c3a20b0f67854460f0d1c400/

Applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Thomas Petazzoni via buildroot

In reply of:

Quoted 20 lines

Since the bump of libxml2 from 2.13.8 to 2.15.0 in Buildroot commit d81922c1ef8825f10b802984d9721412a1a1a377, the "virt" plugin of collectd no longer builds:

src/virt.c:2208:49: error: expected ';', ',' or ')' before 'ATTRIBUTE_UNUSED'
2208 | static void virt_eventloop_timeout_cb(int timer ATTRIBUTE_UNUSED,

      |                                                 ^~~~~~~~~~~~~~~~
src/virt.c: In function 'register_event_impl':
src/virt.c:2221:26: error: 'virt_eventloop_timeout_cb' undeclared (first use in this function)
 2221 |                          virt_eventloop_timeout_cb, NULL, NULL) < 0) {
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~

src/virt.c:2221:26: note: each undeclared identifier is reported only once for each function it appears in

This is due to the fact that the virt plugin code was incorrectly using the ATTRIBUTE_UNUSED define, which was supposed to be an internal define of libxml2. But it turns out that up to libxml2 2.14.0 and its commit 208f27f9641a59863ce1f7d4992df77f7eb0ea9d, this define had been made publicly available. It could therefore mistakenly be used by collectd's virt plugin... until libxml2 was upgraded.

Quoted 7 lines

We backport an upstream patch from collectd that fixes the issue.

Fixes:

https://autobuild.buildroot.net/results/4c8463f0372560f4c3a20b0f67854460f0d1c400/

Applied to 2025.02.x & 2026.05.x. Thanks

Quoted 63 lines
---
 ...UTE_UNUSED-for-virt_eventloop_timeou.patch | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 package/collectd/0006-virt-Drop-ATTRIBUTE_UNUSED-for-virt_eventloop_timeou.patch
package/collectd/0006-virt-Drop-ATTRIBUTE_UNUSED-for-virt_eventloop_timeou.patch new file +45 -0
new file mode 100644
index 0000000000..6cf0a55ba2
@@ -0,0 +1,45 @@
+From be6ac1ed28b4842e8f2e54c39a2b3fc48feaf8b2 Mon Sep 17 00:00:00 2001
+From: "Matwey V. Kornilov" <[email protected]>
+Date: Sun, 26 Oct 2025 18:36:56 +0300
+Subject: [PATCH] virt: Drop ATTRIBUTE_UNUSED for virt_eventloop_timeout_cb
+
+ATTRIBUTE_UNUSED seems to be never was a public part of the libvirt interface
+and leads to the following issue with recent libvirt versions were
+ATTRIBUTE_UNUSED has been renamed to G_GNUC_UNUSED:
+
+src/virt.c:2209:49: error: expected ';', ',' or ')' before 'ATTRIBUTE_UNUSED'
+ 2209 | static void virt_eventloop_timeout_cb(int timer ATTRIBUTE_UNUSED,
+      |                                                 ^~~~~~~~~~~~~~~~
+src/virt.c: In function 'register_event_impl':
+src/virt.c:2222:26: error: 'virt_eventloop_timeout_cb' undeclared (first use in this function)
+ 2222 |                          virt_eventloop_timeout_cb, NULL, NULL) < 0) {
+      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~
+src/virt.c:2222:26: note: each undeclared identifier is reported only once for each function it appears in
+
+Drop ATTRIBUTE_UNUSED here as there is little use from it.
+
+Upstream: https://github.com/collectd/collectd/commit/050877ed952ffc15c849803a9b3e77c5cec15f81
+Signed-off-by: Thomas Petazzoni <[email protected]>
+---
+ src/virt.c | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/src/virt.c b/src/virt.c
+index 01c7c777..ee0440e9 100644
+--- a/src/virt.c
++++ b/src/virt.c
+@@ -2205,8 +2205,9 @@ static int domain_lifecycle_event_cb(__attribute__((unused)) virConnectPtr con_,
+   return 0;
+ }
+ 
+-static void virt_eventloop_timeout_cb(int timer ATTRIBUTE_UNUSED,
+-                                      void *timer_info) {}
++static void
++virt_eventloop_timeout_cb(__attribute__((unused)) int timer,
++                          __attribute__((unused)) void *timer_info) {}
+ 
+ static int register_event_impl(void) {
+   if (virEventRegisterDefaultImpl() < 0) {
+-- 
+2.55.0
+
Signature · 6 lines
2.55.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot