ARM: dts: stm32: Drop bias-disable from STM32MP15xx DHCOM SoM sdmmc1_b4_pins_a
Marek Vasut
maintainerPATCH 1/1 ARM: dts: stm32: Drop bias-disable from STM32MP15xx DHCOM SoM sdmmc1_b4_pins_a
Drop bias-disable property from STM32MP15xx DHCOM SoM sdmmc1_b4_pins_a to fix the following DT checker warning. The bias-pull-up property is the only bias-related property that has to be present in those pinctrl node subnodes.
"arch/arm/boot/dts/st/stm32mp153c-dhcom-drc02.dtb: pinctrl@50002000 (st,stm32mp157-pinctrl): sdmmc1-b4-0:pins1: {'pinmux': [10253, 10509, 10765, 11021, 12813], 'slew-rate': 1, 'drive-push-pull': True, 'bias-disable': True, 'bias-pull-up': True} is valid under each of {'required': ['bias-pull-up']}, {'required': ['bias-disable']} "
---
Cc: Alexandre Torgue <[email protected]>
Cc: Christoph Niedermaier <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi +2 -0
@@ -505,9 +505,11 @@ &sdmmc1_b4_pins_a { * - mandatory on SoMs without SD voltage translator */ pins1 { + /delete-property/ bias-disable; bias-pull-up; }; pins2 { + /delete-property/ bias-disable; bias-pull-up; }; };
Signature · 1 line
2.53.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Missing bias overrides for 'opendrain' and 'init' pinctrl states. --
commit 9ff09c9ba4ada67d4ecaab0a65874ab8bca8e136
Author: Marek Vasut <[email protected]>
Subject: ARM: dts: stm32: Drop bias-disable from STM32MP15xx DHCOM SoM sdmmc1_b4_pins_a
This patch drops the bias-disable property from sdmmc1_b4_pins_a in the STM32MP15xx DHCOM SoM device tree to fix a DT checker warning. It ensures bias-pull-up is the only bias-related property present in the pinctrl subnodes for this state.
Quoted 6 lines
arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi +0
-0@@ -505,9 +505,11 @@ &sdmmc1_b4_pins_a { * - mandatory on SoMs without SD voltage translator
arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi &sdmmc1_b4_pins_a { · line 515
Quoted 10 lines
arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi +2
-0*/ pins1 { + /delete-property/ bias-disable; bias-pull-up; }; pins2 { + /delete-property/ bias-disable; bias-pull-up; }; };
[Severity: High]
This isn't a bug introduced by this patch, but should the bias properties also be overridden for the opendrain and init pinctrl states?
Earlier in arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi, the sdmmc1 node defines these additional states:
&sdmmc1 {
pinctrl-names = "default", "opendrain", "sleep", "init";
pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_a>;
pinctrl-1 = <&sdmmc1_b4_od_pins_a &sdmmc1_dir_pins_a>;
pinctrl-2 = <&sdmmc1_b4_sleep_pins_a &sdmmc1_dir_sleep_pins_a>;
pinctrl-3 = <&sdmmc1_b4_init_pins_a &sdmmc1_dir_init_pins_a>;...
};
Without similar overrides for &sdmmc1_b4_od_pins_a and &sdmmc1_b4_init_pins_a, they will inherit bias-disable from the base dtsi (stm32mp15-pinctrl.dtsi) when the MMC core automatically selects the opendrain or init states during card initialization and specific modes.
Since internal pull-ups are mandatory on SoMs without an SD voltage translator, couldn't inheriting bias-disable leave the bus lines floating during card initialization and cause storage failures?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Alexandre TORGUE
maintainerHi Marek
Quoted 33 lines · Marek Vasut
Drop bias-disable property from STM32MP15xx DHCOM SoM
sdmmc1_b4_pins_ato fix the following DT checker warning. The bias-pull-up property is the only bias-related property that has to be present in those pinctrl node subnodes."
arch/arm/boot/dts/st/stm32mp153c-dhcom-drc02.dtb: pinctrl@50002000 (st,stm32mp157-pinctrl): sdmmc1-b4-0:pins1: {'pinmux': [10253, 10509, 10765, 11021, 12813], 'slew-rate': 1, 'drive-push-pull': True, 'bias-disable': True, 'bias-pull-up': True} is valid under each of {'required': ['bias-pull-up']}, {'required': ['bias-disable']} "Fixes 7cd8567d988a ("ARM: dts: stm32: Enable internal pull-ups for SDMMC1 on DHCOM SoM")Signed-off-by Marek Vasut <[email protected]>---
Cc: Alexandre Torgue <[email protected]>
Cc: Christoph Niedermaier <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]--- arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi +0
-0@@ -505,9 +505,11 @@ &sdmmc1_b4_pins_a { * - mandatory on SoMs without SD voltage translator
arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi &sdmmc1_b4_pins_a { · line 515
Quoted 10 lines
arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi +2
-0*/ pins1 { + /delete-property/ bias-disable; bias-pull-up; }; pins2 { + /delete-property/ bias-disable; bias-pull-up; }; };
Applied on stm32-next.
Thanks.
Alex