Skip to contentSkip to conversation

dt-bindings: usb: generic-ohci: Document ST STM32MP1 SoC compatibles

PATCH In review Marek Vasut 3 participants 6 messages Aug 28 – Aug 31

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 dt-bindings: usb: generic-ohci: Document ST STM32MP1 SoC compatibles

Document SoC compatibles for ST STM32MP13xx and STM32MP15xx series of SoC, so they can be used as more accurate compatible in SoC DTSI. The SoC DTSI currently use plain "generic-ohci" which is not future proof.

---
Cc: Alexandre Torgue <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 Documentation/devicetree/bindings/usb/generic-ohci.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/usb/generic-ohci.yaml +2 -0
index 322808aaa2839..474a84aa32d0f 100644
@@ -49,6 +49,8 @@ properties:
               - ingenic,jz4740-ohci
               - rockchip,rk3588-ohci
               - snps,hsdk-v1.0-ohci
+              - st,stm32mp13-ohci
+              - st,stm32mp15-ohci
           - const: generic-ohci
       - enum:
           - generic-ohci
Signature · 1 line
2.53.0
#1 lore raw

PATCH 2/3 ARM: dts: stm32: Use STM32MP13xx compatible string for OHCI USB controller

Use accurate STM32MP13xx compatible string for OHCI USB controller in addition to "generic-ohci" fallback compatible string. This is future proof, and drivers can match on the accurate compatible string in case they need to discern this controller from the generic-ohci one.

---
Cc: Alexandre Torgue <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 arch/arm/boot/dts/st/stm32mp131.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/st/stm32mp131.dtsi +1 -1
index 5ae33b26e313f..d1c5afb5f89aa 100644
@@ -1128,7 +1128,7 @@ crc1: crc@58009000 {
 		};
 
 		usbh_ohci: usb@5800c000 {
-			compatible = "generic-ohci";
+			compatible = "st,stm32mp13-ohci", "generic-ohci";
 			reg = <0x5800c000 0x1000>;
 			clocks = <&usbphyc>, <&rcc USBH>;
 			resets = <&rcc USBH_R>;
Signature · 1 line
2.53.0
#2 lore raw

PATCH 3/3 ARM: dts: stm32: Use STM32MP15xx compatible string for OHCI USB controller

In reply to Marek Vasut

Use accurate STM32MP15xx compatible string for OHCI USB controller in addition to "generic-ohci" fallback compatible string. This is future proof, and drivers can match on the accurate compatible string in case they need to discern this controller from the generic-ohci one.

---
Cc: Alexandre Torgue <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 arch/arm/boot/dts/st/stm32mp151.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/st/stm32mp151.dtsi +1 -1
index e7fec8b49ae16..c37005c00ad65 100644
@@ -504,7 +504,7 @@ crc1: crc@58009000 {
 		};
 
 		usbh_ohci: usb@5800c000 {
-			compatible = "generic-ohci";
+			compatible = "st,stm32mp15-ohci", "generic-ohci";
 			reg = <0x5800c000 0x1000>;
 			clocks = <&usbphyc>, <&rcc USBH>;
 			resets = <&rcc USBH_R>;
Signature · 1 line
2.53.0
#3 lore raw
In reply to Marek Vasut
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Incomplete binding family update: missing STM32MP1 EHCI compatibles. --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete binding family update: missing STM32MP1 EHCI compatibles. --

commit b94b8c4a5c06e677f1c40f017de92bb5e2ec3002
Author: Marek Vasut <[email protected]>

dt-bindings: usb: generic-ohci: Document ST STM32MP1 SoC compatibles

This commit documents the SoC-specific compatibles for the ST STM32MP13xx and STM32MP15xx series in the generic-ohci binding. This allows the SoC DTSI to use these more accurate compatibles instead of just the generic fallback.

Documentation/devicetree/bindings/usb/generic-ohci.yaml properties: · line 53

Quoted 10 lines
Documentation/devicetree/bindings/usb/generic-ohci.yaml +2 -0
index d42f448fa2044..1b54f0d91061f 100644
@@ -49,6 +49,8 @@ properties:
               - ingenic,jz4740-ohci
               - rockchip,rk3588-ohci
               - snps,hsdk-v1.0-ohci
+              - st,stm32mp13-ohci
+              - st,stm32mp15-ohci

[Severity: Medium]
Since st,stm32mp13-ohci and st,stm32mp15-ohci are being added here, should the companion EHCI compatibles (st,stm32mp13-ehci and st,stm32mp15-ehci) also be added to the compatible block in Documentation/devicetree/bindings/usb/generic-ehci.yaml?

The device tree bindings subsystem guidelines state that when a binding has multiple YAML files for different device types in the same family, related files need matching updates. Updating generic-ehci.yaml would ensure the EHCI companion controller is documented alongside its OHCI counterpart, keeping the entire USB host subsystem on STM32MP1 fully documented and future-proofed.

Quoted 3 lines
Documentation/devicetree/bindings/usb/generic-ohci.yaml +0 -0
           - const: generic-ohci
       - enum:
           - generic-ohci
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#4 lore raw
In reply to Marek Vasut
Quoted 6 lines · Marek Vasut

Document SoC compatibles for ST STM32MP13xx and STM32MP15xx series of SoC, so they can be used as more accurate compatible in SoC DTSI. The SoC DTSI currently use plain "generic-ohci" which is not future proof.

---

This should go also with your access controllers property. What happened to it?

Best regards,
Krzysztof

#5 lore raw
Quoted 11 lines · Krzysztof Kozlowski
Quoted 6 lines · Marek Vasut

Document SoC compatibles for ST STM32MP13xx and STM32MP15xx series of SoC, so they can be used as more accurate compatible in SoC DTSI. The SoC DTSI currently use plain "generic-ohci" which is not future proof.

---

This should go also with your access controllers property. What happened to it?

Ah, I mixed patchsets/devices.

Best regards,
Krzysztof