Skip to contentSkip to conversation

dt-bindings: usb: generic-ehci: Document ST STM32MP1 SoC compatibles

PATCH In review Marek Vasut 3 participants 5 messages Aug 28

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 dt-bindings: usb: generic-ehci: Document ST STM32MP1 SoC compatibles

Document SoC compatibles for ST STM32MP13xx and STM32MP15xx series of SoC, so they can be used as more accurate compatible in SoC DTSI. The SoC DTSI currently use plain "generic-ehci" which is not future proof.

---
Cc: Alexandre Torgue <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: Place ST below Socionext

---
 Documentation/devicetree/bindings/usb/generic-ehci.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/usb/generic-ehci.yaml +2 -0
index ae9fb70d0212c..5d9dfea8e2160 100644
@@ -55,6 +55,8 @@ properties:
               - rockchip,rk3588-ehci
               - snps,hsdk-v1.0-ehci
               - socionext,uniphier-ehci
+              - st,stm32mp13-ehci
+              - st,stm32mp15-ehci
           - const: generic-ehci
       - items:
           - enum:
Signature · 1 line
2.53.0
#1 lore raw

PATCH v2 2/3 ARM: dts: stm32: Use STM32MP13xx compatible string for EHCI USB controller

Use accurate STM32MP13xx compatible string for EHCI USB controller in addition to "generic-ehci" fallback compatible string. This is future proof, and drivers can match on the accurate compatible string in case they need to discern this controller from the generic-ehci one.

---
Cc: Alexandre Torgue <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: No change

---
 arch/arm/boot/dts/st/stm32mp131.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/st/stm32mp131.dtsi +1 -1
index d1c5afb5f89aa..ae45c2023afeb 100644
@@ -1137,7 +1137,7 @@ usbh_ohci: usb@5800c000 {
 		};
 
 		usbh_ehci: usb@5800d000 {
-			compatible = "generic-ehci";
+			compatible = "st,stm32mp13-ehci", "generic-ehci";
 			reg = <0x5800d000 0x1000>;
 			clocks = <&usbphyc>, <&rcc USBH>;
 			resets = <&rcc USBH_R>;
Signature · 1 line
2.53.0
#2 lore raw

PATCH v2 3/3 ARM: dts: stm32: Use STM32MP15xx compatible string for EHCI USB controller

In reply to Marek Vasut

Use accurate STM32MP15xx compatible string for EHCI USB controller in addition to "generic-ehci" fallback compatible string. This is future proof, and drivers can match on the accurate compatible string in case they need to discern this controller from the generic-ehci one.

---
Cc: Alexandre Torgue <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: No change

---
 arch/arm/boot/dts/st/stm32mp151.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/st/stm32mp151.dtsi +1 -1
index c37005c00ad65..ae31883732388 100644
@@ -515,7 +515,7 @@ usbh_ohci: usb@5800c000 {
 		};
 
 		usbh_ehci: usb@5800d000 {
-			compatible = "generic-ehci";
+			compatible = "st,stm32mp15-ehci", "generic-ehci";
 			reg = <0x5800d000 0x1000>;
 			clocks = <&usbphyc>, <&rcc USBH>;
 			resets = <&rcc USBH_R>;
Signature · 1 line
2.53.0
#3 lore raw
In reply to Marek Vasut
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Incomplete binding update: missing matching SoC compatibles for OHCI --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete binding update: missing matching SoC compatibles for OHCI --

commit 7095875c29b62fc4da25d15360437f36863e8a6a
Author: Marek Vasut <[email protected]>

dt-bindings: usb: generic-ehci: Document ST STM32MP1 SoC compatibles

This commit documents SoC-specific compatibles for the ST STM32MP13xx and STM32MP15xx series in the generic-ehci binding. This provides a more accurate compatible string for the SoC DTSI than the plain "generic-ehci" fallback.

Documentation/devicetree/bindings/usb/generic-ehci.yaml properties: · line 60

Quoted 11 lines
Documentation/devicetree/bindings/usb/generic-ehci.yaml +2 -0
index 55a5aa7d7a54e..a88aa1e1ee59c 100644
@@ -55,6 +55,8 @@ properties:
               - rockchip,rk3588-ehci
               - snps,hsdk-v1.0-ehci
               - socionext,uniphier-ehci
+              - st,stm32mp13-ehci
+              - st,stm32mp15-ehci
           - const: generic-ehci

[Severity: Medium]
Since the STM32MP13xx and STM32MP15xx hardware includes both EHCI and OHCI controllers in a companion setup, should a matching update be made to Documentation/devicetree/bindings/usb/generic-ohci.yaml?

Currently, generic-ohci.yaml has an equivalent list of SoC-specific OHCI compatibles:

- ingenic,jz4740-ohci
- rockchip,rk3588-ohci
- snps,hsdk-v1.0-ohci
- const: generic-ohci

Without adding the corresponding ST compatible strings to generic-ohci.yaml, the OHCI controller remains documented only as "generic-ohci", which leaves it not future proof in the same way generic-ehci was prior to this change.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1