Skip to contentSkip to conversation

staging: fbtft: Fix wrong controller name in fb_bd663474

PATCH In review Preetish Amballi 3 participants 4 messages Aug 9 – Aug 28

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fbtft: Fix wrong controller name in fb_bd663474

The file fb_bd663474.c is a driver for the BD663474 LCD controller, but the comment header and MODULE_DESCRIPTION incorrectly reference 'uPD161704' — a copy-paste error from fb_upd161704.c.

Fix the comment and MODULE_DESCRIPTION to say 'BD663474' instead of 'uPD161704'.

---
 drivers/staging/fbtft/fb_bd663474.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fb_bd663474.c +2 -2
index 1629c2c440a9..c34f859043ef 100644
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * FB driver for the uPD161704 LCD Controller
+ * FB driver for the BD663474 LCD Controller
  *
  * Copyright (C) 2014 Seong-Woo Kim
  *
@@ -166,6 +166,6 @@ MODULE_ALIAS("platform:" DRVNAME);
 MODULE_ALIAS("spi:bd663474");
 MODULE_ALIAS("platform:bd663474");
 
-MODULE_DESCRIPTION("FB driver for the uPD161704 LCD Controller");
+MODULE_DESCRIPTION("FB driver for the BD663474 LCD Controller");
 MODULE_AUTHOR("Seong-Woo Kim");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Preetish Amballi

The file fb_bd663474.c is a driver for the BD663474 LCD controller, but the comment header and MODULE_DESCRIPTION incorrectly reference 'uPD161704' — a copy-paste error from fb_upd161704.c.

Fix the comment and MODULE_DESCRIPTION to say 'BD663474' instead of 'uPD161704'.

LGTM,

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

Hi Team,

Could you please merge this.

Regards,
Preetish

Quoted 17 lines · Andy Shevchenko,
Quoted 7 lines · Preetish Amballi

The file fb_bd663474.c is a driver for the BD663474 LCD controller, but the comment header and MODULE_DESCRIPTION incorrectly reference 'uPD161704' — a copy-paste error from fb_upd161704.c.

Fix the comment and MODULE_DESCRIPTION to say 'BD663474' instead of 'uPD161704'.

LGTM,

--
With Best Regards,
Andy Shevchenko

maintainer
#3 lore raw
Quoted 3 lines · Preetish Amballi

Hi Team,

Could you please merge this.

It is the middle of the merge window, nothing can happen now. If you wish to see patches merged quicker, please help out in reviewing other patches on the lists to reduce our workload.

Also, it's a comment change, not a major bugfix, so you want us to handle regressions first, right?

thanks,

greg k-h