opp: Use %pe to print symbolic error name
PATCH 1/1 opp: Use %pe to print symbolic error name
Replace PTR_ERR() and %ld with %pe and pass the original pointer directly to dev_dbg(), dev_warn(), dev_err() or pr_err(). The %pe format specifier prints a symbolic error name (e.g. -ENOMEM) when CONFIG_SYMBOLIC_ERRNAME is enabled, otherwise it falls back gracefully and prints the raw integer value. This makes error messages more readable without any functional change.
--- drivers/opp/core.c | 24 ++++++++++++------------ drivers/opp/of.c | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-)
drivers/opp/core.c +12 -12
@@ -453,8 +453,8 @@ int dev_pm_opp_get_opp_count(struct device *dev)_find_opp_table (dev);if (IS_ERR (opp_table)) { -dev_dbg (dev,"%s: OPP table not found (%ld)\n" , - __func__,PTR_ERR (opp_table)); +dev_dbg (dev,"%s: OPP table not found (%pe)\n" , + __func__, opp_table);return PTR_ERR (opp_table); }
@@ -611,8 +611,8 @@ _find_key(struct device *dev, unsigned long *key, int index, bool available,_find_opp_table (dev);if (IS_ERR (opp_table)) { -dev_err (dev,"%s: OPP table not found (%ld)\n" , __func__, -PTR_ERR (opp_table)); +dev_err (dev,"%s: OPP table not found (%pe)\n" , __func__, + opp_table);return ERR_CAST (opp_table); }
@@ -722,8 +722,8 @@ struct dev_pm_opp *dev_pm_opp_find_key_exact(struct device *dev, struct opp_table *opp_table __free(put_opp_table) = _find_opp_table(dev);if (IS_ERR (opp_table)) { -dev_err (dev,"%s: OPP table not found (%ld)\n" , __func__, -PTR_ERR (opp_table)); +dev_err (dev,"%s: OPP table not found (%pe)\n" , __func__, + opp_table);return ERR_CAST (opp_table); }
@@ -1036,8 +1036,8 @@ static int _set_opp_voltage(struct device *dev, struct regulator *reg,/* Regulator not available for device */ if (IS_ERR (reg)) { -dev_dbg (dev,"%s: regulator not available: %ld\n" , __func__, -PTR_ERR (reg)); +dev_dbg (dev,"%s: regulator not available: %pe\n" , __func__, + reg);return 0 ; }
@@ -1448,8 +1448,8 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq) temp_freq = freq; opp =_find_freq_ceil (opp_table, &temp_freq);if (IS_ERR (opp)) { -dev_err (dev,"%s: failed to find OPP for freq %lu (%ld)\n" , - __func__, freq,PTR_ERR (opp)); +dev_err (dev,"%s: failed to find OPP for freq %lu (%pe)\n" , + __func__, freq, opp);return PTR_ERR (opp); }
@@ -2869,8 +2869,8 @@ static int _opp_set_availability(struct device *dev, unsigned long freq, struct dev_pm_opp *opp __free(put_opp) = ERR_PTR(-ENODEV), *tmp_opp;if (IS_ERR (opp_table)) { -dev_warn (dev,"%s: Device OPP not found (%ld)\n" , __func__, -PTR_ERR (opp_table)); +dev_warn (dev,"%s: Device OPP not found (%pe)\n" , __func__, + opp_table);return PTR_ERR (opp_table); }
drivers/opp/of.c +2 -2
@@ -1345,8 +1345,8 @@ int of_get_required_opp_performance_state(struct device_node *np, int index)_find_table_of_opp_np (required_np);if (IS_ERR (opp_table)) { -pr_err ("%s: Failed to find required OPP table %pOF: %ld\n" , - __func__, np,PTR_ERR (opp_table)); +pr_err ("%s: Failed to find required OPP table %pOF: %pe\n" , + __func__, np, opp_table);return PTR_ERR (opp_table); }
Signature · 1 line
2.43.0
Viresh Kumar
AppliedQuoted 7 lines · Sumeet Pawnikar
Replace
PTR_ERR()and %ld with %pe and pass the original pointer directly todev_dbg(),dev_warn(),dev_err()orpr_err(). The %pe format specifier prints a symbolic error name (e.g.-ENOMEM) whenCONFIG_SYMBOLIC_ERRNAMEis enabled, otherwise it falls back gracefully and prints the raw integer value. This makes error messages more readable without any functional change.
Quoted 5 lines
Signed-off-by Sumeet Pawnikar <[email protected]>--- drivers/opp/core.c | 24 ++++++++++++------------ drivers/opp/of.c | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-)
Applied. Thanks.
Signature · 1 line
viresh