block: make bio_check_eod work for zero sized devices
Subsystems (2)
PATCH 1/1 block: make bio_check_eod work for zero sized devices
From: Christoph Hellwig <[email protected]>
commit 3eb96946f0be6bf447cbdf219aba22bc42672f92 upstream.
This patch is a backport.
Since the dawn of time bio_check_eod has a check for a non-zero size of the device. This doesn't really make any sense as we never want to send I/O to a device that's been set to zero size, or never moved out of that.
I am a bit surprised we haven't caught this for a long time, but the removal of the extra validation inside of zram caused syzbot to trip over this issue recently. I've added a Fixes tag for that commit, but the issue really goes back way before git history.
--- block/blk-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
block/blk-core.c +1 -1
@@ -515,7 +515,7 @@ static inline int bio_check_eod(struct bio *bio)sector_t maxsector =bdev_nr_sectors (bio->bi_bdev);unsigned int nr_sectors =bio_sectors (bio); -if (nr_sectors && maxsector && +if (nr_sectors && (nr_sectors > maxsector || bio->bi_iter.bi_sector > maxsector - nr_sectors)) { pr_info_ratelimited("%s: attempt to access beyond end of device\n"
Signature · 1 line
2.34.1
Greg KH
maintainerQuoted 5 lines · Miguel García
From: Christoph Hellwig <[email protected]>
commit
3eb96946f0be6bf447cbdf219aba22bc42672f92upstream.This patch is a backport.
Why? What requires this change? I don't see the justification for this, especially:
Quoted 1 line
Fixes 9fe95babc742 ("zram: remove valid_io_request")
That commit is in 6.4, NOT 6.1.y, so why does 6.1.y need this?
thanks,
greg k-h
PATCH v2 1/1 block: make bio_check_eod work for zero sized devices
From: Christoph Hellwig <[email protected]>
commit 3eb96946f0be6bf447cbdf219aba22bc42672f92 upstream.
Since the dawn of time bio_check_eod has a check for a non-zero size of the device. This doesn't really make any sense as we never want to send I/O to a device that's been set to zero size, or never moved out of that.
I am a bit surprised we haven't caught this for a long time, but the removal of the extra validation inside of zram caused syzbot to trip over this issue recently. I've added a Fixes tag for that commit, but the issue really goes back way before git history.
Backport note for 6.1.y:
The same underlying bug affects 6.1.y even though 9fe95babc742 is not in that tree. The syzbot reproducer attaches a socket to /dev/nbd0 without setting its capacity, then mounts it as BEFS. BEFS calls sb_bread() while bdev_nr_sectors() is zero. The maxsector guard makes bio_check_eod() accept that read, which reaches NBD and waits for a response instead of failing with -EIO. syzbot reproduced the resulting __bread_gfp() hang on 6.1.y and identified this upstream commit by fix bisection.
---
Changes in v2:
- Explain the 6.1.y NBD and BEFS failure path, as requested by Greg:
https://lore.kernel.org/r/2025041215-grudge-rearrange-7123@gregkh
- Preserve both syzbot reports and the upstream commit metadata.
- Refresh against v6.1.186.
Older stable trees are not included here because this backport and its local validation are scoped to the syzbot report for 6.1.y.
v1: https://lore.kernel.org/r/[email protected]
block/blk-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
block/blk-core.c +1 -1
@@ -515,7 +515,7 @@ static inline int bio_check_eod(struct bio *bio)sector_t maxsector =bdev_nr_sectors (bio->bi_bdev);unsigned int nr_sectors =bio_sectors (bio); -if (nr_sectors && maxsector && +if (nr_sectors && (nr_sectors > maxsector || bio->bi_iter.bi_sector > maxsector - nr_sectors)) { pr_info_ratelimited("%s: attempt to access beyond end of device\n"
Signature · 1 line
2.43.0
Quoted 3 lines
Since the dawn of time
bio_check_eodhas a check for a non-zero size of the device. This doesn't really make any sense as we never want to send I/O to a device that's been set to zero size, or never moved out of that.
Queued for 6.1, thanks.
Signature · 2 lines
Thanks, Sasha
Sasha Levin
maintainer[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected. No action required from the submitter.
The upstream commit SHA1 provided is correct: 3eb96946f0be6bf447cbdf219aba22bc42672f92
WARNING: Author mismatch between patch and upstream commit:
Backport author: <[email protected]> Commit author: Christoph Hellwig<[email protected]>
Status in newer kernel trees:
6.14.y | Present (exact SHA1) 6.13.y | Present (exact SHA1) 6.12.y | Present (exact SHA1)
6.6.y | Present (exact SHA1)
Note: The patch differs from the upstream commit:
---
1: 3eb96946f0be6 ! 1: 6a6f180aae691 block: make bio_check_eod work for zero sized devices
@@ Metadata
## Commit message ##
block: make bio_check_eod work for zero sized devices
+ commit 3eb96946f0be6bf447cbdf219aba22bc42672f92 upstream.
+
+ This patch is a backport.
+
Since the dawn of time bio_check_eod has a check for a non-zero size of the device. This doesn't really make any sense as we never want to send I/O to a device that's been set to zero size, or never moved out of that.
@@ Commit message
the issue really goes back way before git history.
- Reported-by: [email protected]
+ Reported-by: [email protected]
+ Bug: https://syzkaller.appspot.com/bug?extid=2aca91e1d3ae43aef10c
+ (cherry picked from commit 3eb96946f0be6bf447cbdf219aba22bc42672f92)
+ Signed-off-by: Miguel García <[email protected]>
## block/blk-core.c ##
@@ block/blk-core.c: static inline int bio_check_eod(struct bio *bio)
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test | |---------------------------|-------------|------------| | stable/linux-6.1.y | Success | Success |