net: fix use-after-free in pskb_expand_head()
Subsystems (2)
PATCH 1/1 net: fix use-after-free in pskb_expand_head()
pskb_expand_head() and pskb_carve_inside_header() decide whether to drop the old head gracefully via skb_release_data() or directly free it via skb_free_head().
Blamed commit replaced the check against dataref == delta with skb_cloned(skb).
However, skb_cloned(skb) masks out the upper 16 bits (SKB_DATAREF_SHIFT) of dataref using SKB_DATAREF_MASK. For an skb with nohdr == 1 or a clone referencing a shared buffer where only one regular reference exists, skb_cloned(skb) evaluates to false even when dataref is shared with other skbs.
When pskb_expand_head() is called on such a buffer (e.g. during bridge flooding, generic XDP, or VLAN tag insertion), it falsely assumes the head is unshared and calls skb_free_head(skb) directly. This drops the underlying head/frag reference immediately, while other clones or references still point to it, causing a use-after-free in subsequent packet processing.
Introduce skb_dataref_bias() and skb_data_is_shared() to accurately test if dataref is shared by checking atomic_read(&skb_shinfo(skb)->dataref) != bias.
Use skb_dataref_bias() in skb_data_unref() and skb_data_is_shared() in pskb_expand_head() and pskb_carve_inside_header().
--- include/linux/skbuff.h | 13 ++++++++++++- net/core/skbuff.c | 4 ++-- 2 files changed, 14 insertions(+), 3 deletions(-)
include/linux/skbuff.h +12 -1
@@ -1295,6 +1295,11 @@ static inline bool skb_unref(struct sk_buff *skb)return true; } +static inline int skb_dataref_bias (const struct sk_buff *skb) +{ +return skb->nohdr ? (1 <<SKB_DATAREF_SHIFT ) +1 :1 ; +} +static inline bool skb_data_unref (const struct sk_buff *skb,struct skb_shared_info *shinfo) {
@@ -1303,7 +1308,7 @@ static inline bool skb_data_unref(const struct sk_buff *skb,if (!skb->cloned)return true; - bias = skb->nohdr ? (1 <<SKB_DATAREF_SHIFT ) +1 :1 ; + bias =skb_dataref_bias (skb);if (atomic_read (&shinfo->dataref) == bias)smp_rmb ();
@@ -2019,6 +2024,12 @@ static inline struct sk_buff *skb_get(struct sk_buff *skb)* If users == 1, we are the only owner and can avoid redundant atomic changes. */ +static inline bool skb_data_is_shared (const struct sk_buff *skb) +{ +return skb->cloned && +atomic_read (&skb_shinfo (skb)->dataref) !=skb_dataref_bias (skb); +} +/** * skb_cloned - is the buffer a clone * @skb: buffer to check
net/core/skbuff.c +2 -2
@@ -2331,7 +2331,7 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail,* is not we can just drop the old head and let the existing refcount * be since all we did is relocate the values */ -if (skb_cloned (skb)) { +if (skb_data_is_shared (skb)) {if (skb_orphan_frags (skb, gfp_mask)) goto nofrags;if (skb_zcopy (skb))
@@ -6855,7 +6855,7 @@ static int pskb_carve_inside_header(struct sk_buff *skb, const u32 off,skb_shinfo (skb),offsetof (struct skb_shared_info , frags[skb_shinfo(skb)->nr_frags])); -if (skb_cloned (skb)) { +if (skb_data_is_shared (skb)) {/* drop the old head gracefully */ if (skb_orphan_frags (skb, gfp_mask)) {skb_kfree_head (data);
Signature · 1 line
2.55.0.897.gb25b4bd76c-goog
Paolo Abeni
maintainerQuoted 78 lines · Eric Dumazet
pskb_expand_head()andpskb_carve_inside_header()decide whether to drop the old head gracefully viaskb_release_data()or directly free it viaskb_free_head().Blamed commit replaced the check against dataref == delta with
skb_cloned(skb).However,
skb_cloned(skb)masks out the upper 16 bits (SKB_DATAREF_SHIFT) of dataref usingSKB_DATAREF_MASK. For an skb with nohdr == 1 or a clone referencing a shared buffer where only one regular reference exists,skb_cloned(skb)evaluates to false even when dataref is shared with other skbs.When
pskb_expand_head()is called on such a buffer (e.g. during bridge flooding, generic XDP, or VLAN tag insertion), it falsely assumes the head is unshared and callsskb_free_head(skb)directly. This drops the underlying head/frag reference immediately, while other clones or references still point to it, causing a use-after-free in subsequent packet processing.Introduce
skb_dataref_bias()andskb_data_is_shared()to accurately test if dataref is shared by checking atomic_read(&skb_shinfo(skb)->dataref) != bias.Use
skb_dataref_bias()inskb_data_unref()andskb_data_is_shared()inpskb_expand_head()andpskb_carve_inside_header().Fixes 3e24591a19bb ("skb: Drop "fastpath" variable for skb_cloned check in pskb_expand_head")Reported-by [email protected]Reported-by [email protected]Signed-off-by Eric Dumazet <[email protected]>--- include/linux/skbuff.h | 13 ++++++++++++- net/core/skbuff.c | 4 ++-- 2 files changed, 14 insertions(+), 3 deletions(-)include/linux/skbuff.h +12
-1@@ -1295,6 +1295,11 @@ static inline bool skb_unref(struct sk_buff *skb)return true; } +static inline int skb_dataref_bias (const struct sk_buff *skb) +{ +return skb->nohdr ? (1 <<SKB_DATAREF_SHIFT ) +1 :1 ; +} +static inline bool skb_data_unref (const struct sk_buff *skb,struct skb_shared_info *shinfo) {@@ -1303,7 +1308,7 @@ static inline bool skb_data_unref(const struct sk_buff *skb,if (!skb->cloned)return true; - bias = skb->nohdr ? (1 <<SKB_DATAREF_SHIFT ) +1 :1 ; + bias =skb_dataref_bias (skb);if (atomic_read (&shinfo->dataref) == bias)smp_rmb ();@@ -2019,6 +2024,12 @@ static inline struct sk_buff *skb_get(struct sk_buff *skb)* If users == 1, we are the only owner and can avoid redundant atomic changes. */ +static inline bool skb_data_is_shared (const struct sk_buff *skb) +{ +return skb->cloned && +atomic_read (&skb_shinfo (skb)->dataref) !=skb_dataref_bias (skb); +} +/** * skb_cloned - is the buffer a clone * @skb: buffer to check net/core/skbuff.c +0
-0
net/core/skbuff.c int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail, · line 2334
Quoted 5 lines
net/core/skbuff.c +1
-1@@ -2331,7 +2331,7 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail,* is not we can just drop the old head and let the existing refcount * be since all we did is relocate the values */ -if (skb_cloned (skb)) { +if (skb_data_is_shared (skb)) {
I'm sorry, I can't wrap my head around the above change; I have similar doubt WRT the sashiko reported one:
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260831095952.3385596-1-edumazet%40google.com
that is: I can't see when the new condition yield different results from the old one. Could you please describe exactly the bad layout and were/how it is obtained?
Thanks,
Paolo
Quoted 89 lines · Paolo Abeni
Quoted 78 lines · Eric Dumazet
pskb_expand_head()andpskb_carve_inside_header()decide whether to drop the old head gracefully viaskb_release_data()or directly free it viaskb_free_head().Blamed commit replaced the check against dataref == delta with
skb_cloned(skb).However,
skb_cloned(skb)masks out the upper 16 bits (SKB_DATAREF_SHIFT) of dataref usingSKB_DATAREF_MASK. For an skb with nohdr == 1 or a clone referencing a shared buffer where only one regular reference exists,skb_cloned(skb)evaluates to false even when dataref is shared with other skbs.When
pskb_expand_head()is called on such a buffer (e.g. during bridge flooding, generic XDP, or VLAN tag insertion), it falsely assumes the head is unshared and callsskb_free_head(skb)directly. This drops the underlying head/frag reference immediately, while other clones or references still point to it, causing a use-after-free in subsequent packet processing.Introduce
skb_dataref_bias()andskb_data_is_shared()to accurately test if dataref is shared by checking atomic_read(&skb_shinfo(skb)->dataref) != bias.Use
skb_dataref_bias()inskb_data_unref()andskb_data_is_shared()inpskb_expand_head()andpskb_carve_inside_header().Fixes 3e24591a19bb ("skb: Drop "fastpath" variable for skb_cloned check in pskb_expand_head")Reported-by [email protected]Reported-by [email protected]Signed-off-by Eric Dumazet <[email protected]>--- include/linux/skbuff.h | 13 ++++++++++++- net/core/skbuff.c | 4 ++-- 2 files changed, 14 insertions(+), 3 deletions(-)include/linux/skbuff.h +12
-1@@ -1295,6 +1295,11 @@ static inline bool skb_unref(struct sk_buff *skb)return true; } +static inline int skb_dataref_bias (const struct sk_buff *skb) +{ +return skb->nohdr ? (1 <<SKB_DATAREF_SHIFT ) +1 :1 ; +} +static inline bool skb_data_unref (const struct sk_buff *skb,struct skb_shared_info *shinfo) {@@ -1303,7 +1308,7 @@ static inline bool skb_data_unref(const struct sk_buff *skb,if (!skb->cloned)return true; - bias = skb->nohdr ? (1 <<SKB_DATAREF_SHIFT ) +1 :1 ; + bias =skb_dataref_bias (skb);if (atomic_read (&shinfo->dataref) == bias)smp_rmb ();@@ -2019,6 +2024,12 @@ static inline struct sk_buff *skb_get(struct sk_buff *skb)* If users == 1, we are the only owner and can avoid redundant atomic changes. */ +static inline bool skb_data_is_shared (const struct sk_buff *skb) +{ +return skb->cloned && +atomic_read (&skb_shinfo (skb)->dataref) !=skb_dataref_bias (skb); +} +/** * skb_cloned - is the buffer a clone * @skb: buffer to check net/core/skbuff.c +0
-0net/core/skbuff.c int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail, · line 2334
Quoted 5 lines
net/core/skbuff.c +1
-1@@ -2331,7 +2331,7 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail,* is not we can just drop the old head and let the existing refcount * be since all we did is relocate the values */ -if (skb_cloned (skb)) { +if (skb_data_is_shared (skb)) {I'm sorry, I can't wrap my head around the above change; I have similar doubt WRT the sashiko reported one:
Quoted 5 lines
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260831095952.3385596-1-edumazet%40google.com
that is: I can't see when the new condition yield different results from the old one. Could you please describe exactly the bad layout and were/how it is obtained?
Hi Paolo,
Here is the exact state layout and sequence where the old and new conditions differ:
1. The Layout and Values
Suppose an sk_buff is marked with __skb_header_release(skb) (e.g. in TCP or skb_gro_receive()):
- skb->nohdr = 1
- dataref is set to 1 + (1 << 16) = 0x00010001
Now a clone is created (e.g. in br_flood() via deliver_clone(), packet socket tap, or veth):
- __skb_clone(clone, skb) sets:
- clone->nohdr = 0 (clones always have nohdr = 0)
- clone->cloned = 1
- skb->cloned = 1
- dataref becomes 0x00010002 (or remains 0x00010001 if __skb_header_release() was called during GRO on an already-referenced buffer).
If a clone or sibling drops a reference via skb_data_unref() (subtracting bias = 1), dataref returns to 0x00010001.
Now we have a clone "clone" still referencing this buffer with:
- clone->cloned == 1
- clone->nohdr == 0
- dataref == 0x00010001 (1 TCP/GRO payload ref + 1 clone ref)
2. How Old vs. New Checks Differ on this "clone"
When pskb_expand_head(clone) is called (e.g. pushing a VLAN tag in validate_xmit_vlan or in generic XDP):
* Old condition (skb_cloned(clone)):
skb->cloned &&
(atomic_read(&skb_shinfo(skb)->dataref) & SKB_DATAREF_MASK) != 1Evaluates:
0x00010001 & 0xffff = 1 -> (1 != 1) -> false
Because it evaluates to false, pskb_expand_head() took the else branch and called:
skb_free_head(clone);
skb_free_head() immediately called put_page() / kfree(), freeing the shared head buffer memory. Meanwhile, the original skb (in GRO / TCP / bridge) was still referencing that buffer. When that skb was subsequently accessed or cloned, KASAN reported a use-after-free.
* New condition (skb_data_is_shared(clone)):
skb->cloned &&
atomic_read(&skb_shinfo(skb)->dataref) != (skb->nohdr ? (1 << 16) + 1 : 1) On clone, clone->nohdr == 0, so bias = 1.
Evaluates:
0x00010001 != 1 -> true
Because it evaluates to true, pskb_expand_head() takes the if branch and calls:
skb_release_data(clone, SKB_CONSUMED);
skb_data_unref() subtracts bias = 1 from dataref, leaving the memory intact for the other SKB.
Summary:
For an SKB with nohdr == 1, both old and new checks return false when dataref == 0x00010001 (the TCP fast path). The difference occurs on clones (nohdr == 0) sharing a nohdr buffer, where SKB_DATAREF_MASK previously masked out the upper 16 bits and caused skb_cloned() to falsely report false.
I can send a V2 with more details, or perhaps this reworded version:
pskb_expand_head() and pskb_carve_inside_header() decide whether to drop the old head gracefully via skb_release_data() or directly free it via skb_free_head().
Blamed commit replaced the check against dataref == delta with skb_cloned(skb).
However, skb_cloned(skb) masks out the upper 16 bits (SKB_DATAREF_SHIFT) of dataref using SKB_DATAREF_MASK. When an skb is headerless (nohdr == 1), its dataref is initialized to 1 + (1 << SKB_DATAREF_SHIFT). For a clone created from such a buffer (where clone->nohdr == 0), if dataref is 1 + (1 << SKB_DATAREF_SHIFT), skb_cloned(clone) checks:
(dataref & SKB_DATAREF_MASK) != 1 -> (1 != 1) -> false
Because skb_cloned(clone) evaluates to false, pskb_expand_head(clone) falsely assumes the head is unshared and calls skb_free_head(clone) directly. This frees the underlying head/frag memory while the original nohdr skb still references it, causing a use-after-free in subsequent packet processing. Introduce skb_dataref_bias() and skb_data_is_shared() to accurately test if dataref is shared by checking atomic_read(&skb_shinfo(skb)->dataref) != bias. For the clone, bias is 1, so (0x10001 != 1) correctly evaluates to true.
Use skb_dataref_bias() in skb_data_unref() and skb_data_is_shared() in pskb_expand_head() and pskb_carve_inside_header().
Paolo Abeni
maintainerQuoted 118 lines · Eric Dumazet
Quoted 89 lines · Paolo Abeni
Quoted 78 lines · Eric Dumazet
pskb_expand_head()andpskb_carve_inside_header()decide whether to drop the old head gracefully viaskb_release_data()or directly free it viaskb_free_head().Blamed commit replaced the check against dataref == delta with
skb_cloned(skb).However,
skb_cloned(skb)masks out the upper 16 bits (SKB_DATAREF_SHIFT) of dataref usingSKB_DATAREF_MASK. For an skb with nohdr == 1 or a clone referencing a shared buffer where only one regular reference exists,skb_cloned(skb)evaluates to false even when dataref is shared with other skbs.When
pskb_expand_head()is called on such a buffer (e.g. during bridge flooding, generic XDP, or VLAN tag insertion), it falsely assumes the head is unshared and callsskb_free_head(skb)directly. This drops the underlying head/frag reference immediately, while other clones or references still point to it, causing a use-after-free in subsequent packet processing.Introduce
skb_dataref_bias()andskb_data_is_shared()to accurately test if dataref is shared by checking atomic_read(&skb_shinfo(skb)->dataref) != bias.Use
skb_dataref_bias()inskb_data_unref()andskb_data_is_shared()inpskb_expand_head()andpskb_carve_inside_header().Fixes 3e24591a19bb ("skb: Drop "fastpath" variable for skb_cloned check in pskb_expand_head")Reported-by [email protected]Reported-by [email protected]Signed-off-by Eric Dumazet <[email protected]>--- include/linux/skbuff.h | 13 ++++++++++++- net/core/skbuff.c | 4 ++-- 2 files changed, 14 insertions(+), 3 deletions(-)include/linux/skbuff.h +12
-1@@ -1295,6 +1295,11 @@ static inline bool skb_unref(struct sk_buff *skb)return true; } +static inline int skb_dataref_bias (const struct sk_buff *skb) +{ +return skb->nohdr ? (1 <<SKB_DATAREF_SHIFT ) +1 :1 ; +} +static inline bool skb_data_unref (const struct sk_buff *skb,struct skb_shared_info *shinfo) {@@ -1303,7 +1308,7 @@ static inline bool skb_data_unref(const struct sk_buff *skb,if (!skb->cloned)return true; - bias = skb->nohdr ? (1 <<SKB_DATAREF_SHIFT ) +1 :1 ; + bias =skb_dataref_bias (skb);if (atomic_read (&shinfo->dataref) == bias)smp_rmb ();@@ -2019,6 +2024,12 @@ static inline struct sk_buff *skb_get(struct sk_buff *skb)* If users == 1, we are the only owner and can avoid redundant atomic changes. */ +static inline bool skb_data_is_shared (const struct sk_buff *skb) +{ +return skb->cloned && +atomic_read (&skb_shinfo (skb)->dataref) !=skb_dataref_bias (skb); +} +/** * skb_cloned - is the buffer a clone * @skb: buffer to check net/core/skbuff.c +0
-0net/core/skbuff.c int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail, · line 2334
Quoted 5 lines
net/core/skbuff.c +1
-1@@ -2331,7 +2331,7 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail,* is not we can just drop the old head and let the existing refcount * be since all we did is relocate the values */ -if (skb_cloned (skb)) { +if (skb_data_is_shared (skb)) {I'm sorry, I can't wrap my head around the above change; I have similar doubt WRT the sashiko reported one:
Quoted 5 lines
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260831095952.3385596-1-edumazet%40google.com
that is: I can't see when the new condition yield different results from the old one. Could you please describe exactly the bad layout and were/how it is obtained?
Hi Paolo,
Here is the exact state layout and sequence where the old and new conditions differ:
1. The Layout and Values
Suppose an
sk_buffis marked with__skb_header_release(skb)(e.g. in TCP orskb_gro_receive()):
-skb->nohdr= 1
- dataref is set to 1 + (1 << 16) =0x00010001Now a clone is created (e.g. in
br_flood()viadeliver_clone(), packet socket tap, or veth):
-__skb_clone(clone, skb)sets:
-clone->nohdr= 0 (clones always have nohdr = 0)
-clone->cloned= 1
-skb->cloned= 1
- dataref becomes0x00010002(or remains0x00010001if__skb_header_release()was called during GRO on an already-referenced buffer).
Quoted 2 lines
If a clone or sibling drops a reference via
skb_data_unref()(subtracting bias = 1), dataref returns to0x00010001.
This is the part that I can't follow: skb_data_unref() subtracts 1 if and only if nohdr == 0. dataref should stay 0x00010001 only on the "original" skb with nohdr == 1.
I feel the issue could be caused by __skb_header_release() being called on a cloned skb, which is AFAIK illegal. I *think* veth in bridge with GRO enabled could do that.
Perhaps adding a DEBUG_NET warning in __skb_header_release() would make sense?
/P
Quoted 127 lines · Paolo Abeni
Quoted 118 lines · Eric Dumazet
Quoted 89 lines · Paolo Abeni
Quoted 78 lines · Eric Dumazet
pskb_expand_head()andpskb_carve_inside_header()decide whether to drop the old head gracefully viaskb_release_data()or directly free it viaskb_free_head().Blamed commit replaced the check against dataref == delta with
skb_cloned(skb).However,
skb_cloned(skb)masks out the upper 16 bits (SKB_DATAREF_SHIFT) of dataref usingSKB_DATAREF_MASK. For an skb with nohdr == 1 or a clone referencing a shared buffer where only one regular reference exists,skb_cloned(skb)evaluates to false even when dataref is shared with other skbs.When
pskb_expand_head()is called on such a buffer (e.g. during bridge flooding, generic XDP, or VLAN tag insertion), it falsely assumes the head is unshared and callsskb_free_head(skb)directly. This drops the underlying head/frag reference immediately, while other clones or references still point to it, causing a use-after-free in subsequent packet processing.Introduce
skb_dataref_bias()andskb_data_is_shared()to accurately test if dataref is shared by checking atomic_read(&skb_shinfo(skb)->dataref) != bias.Use
skb_dataref_bias()inskb_data_unref()andskb_data_is_shared()inpskb_expand_head()andpskb_carve_inside_header().Fixes 3e24591a19bb ("skb: Drop "fastpath" variable for skb_cloned check in pskb_expand_head")Reported-by [email protected]Reported-by [email protected]Signed-off-by Eric Dumazet <[email protected]>--- include/linux/skbuff.h | 13 ++++++++++++- net/core/skbuff.c | 4 ++-- 2 files changed, 14 insertions(+), 3 deletions(-)include/linux/skbuff.h +12
-1@@ -1295,6 +1295,11 @@ static inline bool skb_unref(struct sk_buff *skb)return true; } +static inline int skb_dataref_bias (const struct sk_buff *skb) +{ +return skb->nohdr ? (1 <<SKB_DATAREF_SHIFT ) +1 :1 ; +} +static inline bool skb_data_unref (const struct sk_buff *skb,struct skb_shared_info *shinfo) {@@ -1303,7 +1308,7 @@ static inline bool skb_data_unref(const struct sk_buff *skb,if (!skb->cloned)return true; - bias = skb->nohdr ? (1 <<SKB_DATAREF_SHIFT ) +1 :1 ; + bias =skb_dataref_bias (skb);if (atomic_read (&shinfo->dataref) == bias)smp_rmb ();@@ -2019,6 +2024,12 @@ static inline struct sk_buff *skb_get(struct sk_buff *skb)* If users == 1, we are the only owner and can avoid redundant atomic changes. */ +static inline bool skb_data_is_shared (const struct sk_buff *skb) +{ +return skb->cloned && +atomic_read (&skb_shinfo (skb)->dataref) !=skb_dataref_bias (skb); +} +/** * skb_cloned - is the buffer a clone * @skb: buffer to check net/core/skbuff.c +0
-0net/core/skbuff.c int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail, · line 2334
Quoted 5 lines
net/core/skbuff.c +1
-1@@ -2331,7 +2331,7 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail,* is not we can just drop the old head and let the existing refcount * be since all we did is relocate the values */ -if (skb_cloned (skb)) { +if (skb_data_is_shared (skb)) {I'm sorry, I can't wrap my head around the above change; I have similar doubt WRT the sashiko reported one:
Quoted 5 lines
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260831095952.3385596-1-edumazet%40google.com
that is: I can't see when the new condition yield different results from the old one. Could you please describe exactly the bad layout and were/how it is obtained?
Hi Paolo,
Here is the exact state layout and sequence where the old and new conditions differ:
1. The Layout and Values
Suppose an
sk_buffis marked with__skb_header_release(skb)(e.g. in TCP orskb_gro_receive()):
-skb->nohdr= 1
- dataref is set to 1 + (1 << 16) =0x00010001Now a clone is created (e.g. in
br_flood()viadeliver_clone(), packet socket tap, or veth):
-__skb_clone(clone, skb)sets:
-clone->nohdr= 0 (clones always have nohdr = 0)
-clone->cloned= 1
-skb->cloned= 1
- dataref becomes0x00010002(or remains0x00010001if__skb_header_release()was called during GRO on an already-referenced buffer).Quoted 2 lines
If a clone or sibling drops a reference via
skb_data_unref()(subtracting bias = 1), dataref returns to0x00010001.This is the part that I can't follow:
skb_data_unref()subtracts 1 if and only if nohdr == 0. dataref should stay0x00010001only on the "original" skb with nohdr == 1.
Quoted 6 lines
I feel the issue could be caused by
__skb_header_release()being called on a cloned skb, which is AFAIK illegal. I *think* veth in bridge with GRO enabled could do that.Perhaps adding a
DEBUG_NETwarning in__skb_header_release()would make sense?
Arg... I missed that GRO can be fed with nohdr clones (from veth only I think)
We keep slowing down GRO to the point it is barely an optimization.
Adding back skb_header_release() and use it instead of __skb_header_release() in GRO will not fix the fact that GRO messes with frags.
pw-bot: cr