docs/mm/damon/design: add explanation of nr_snapshots
Subsystems (4)
SJ Park
maintainerv3 cover docs/mm/damon/design: add explanation of nr_snapshots
Add an explanation of nr_snapshots to avoid misunderstandings.
Changes from v2
- v2: https://lore.kernel.org/[email protected]
- Collect R-b: from SJ.
- Rebase to latest mm-new.
Changes from v1:
- v1: https://lore.kernel.org/damon/[email protected]
- Patch 1 word order adjustment: Repositioned "completely" ("tried to be completely applied" -> "completely tried to be applied").
- Patch 2: Use two spaces between sentences.
- Patch 3: Add the "Reviewed-by:" of SJ, because he added this in v1.
- Patch 3: Make some minor modifications, Patch 3 can be applied after Patch 2.
Liew Rui Yan (3):
docs/mm/damon/design: accurate semantics of nr_snapshots docs/mm/damon/design: difference between watermarks and nr_snapshots docs/mm/damon/design: fix typo of max_nr_snapshots
Documentation/mm/damon/design.rst | 9 +++++---- include/linux/damon.h | 5 +++-- 2 files changed, 8 insertions(+), 6 deletions(-)
base-commit: 5c4fade039dbd572ba5ad9cf993fbb56e6a5613f
Signature · 1 line
2.47.3
SJ Park
maintainerPATCH v3 1/3 docs/mm/damon/design: accurate semantics of nr_snapshots
From: Liew Rui Yan <[email protected]>
Change "tried to be applied" -> "completely tried to be applied" to maintain consistency between the documentation and the code.
--- Documentation/mm/damon/design.rst | 4 ++-- include/linux/damon.h | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-)
Documentation/mm/damon/design.rst +2 -2
@@ -848,8 +848,8 @@ scheme's execution. - ``nr_applied``: Total number of regions that the scheme is applied. - ``sz_applied``: Total size of regions that the scheme is applied. - ``qt_exceeds``: Total number of times the quota of the scheme has exceeded. -- ``nr_snapshots``: Total number of DAMON snapshots that the scheme is tried to - be applied. +- ``nr_snapshots``: Total number of DAMON snapshots that the scheme is + completely tried to be applied. - ``max_nr_snapshots``: Upper limit of ``nr_snapshots``. "A scheme is tried to be applied to a region" means DAMOS core logic determined
include/linux/damon.h +2 -1
@@ -359,7 +359,8 @@ struct damos_watermarks {* Total bytes that passed ops layer-handled DAMOS filters. * @qt_exceeds: Total number of times the quota of the scheme has exceeded. * @nr_snapshots: -* Total number of DAMON snapshots that the scheme has tried. +* Total number of DAMON snapshots that the scheme is completely +* tried to be applied. * * "Tried an action to a region" in this context means the DAMOS core logic * determined the region as eligible to apply the action. The access pattern
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [PATCH v3 1/3] docs/mm/damon/design: accurate semantics of nr_snapshots
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 8 lines
From: Liew Rui Yan <[email protected]>
Change "tried to be applied" -> "completely tried to be applied" to maintain consistency between the documentation and the code.
Signed-off-by Liew Rui Yan <[email protected]>Reviewed-by SJ Park <[email protected]>Signed-off-by SJ Park <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
SJ Park
maintainerPATCH v3 2/3 docs/mm/damon/design: difference between watermarks and nr_snapshots
In reply to SJ ParkFrom: Liew Rui Yan <[email protected]>
Explain the difference between nr_snapshots reaches max_nr_snapshots and watermarks.
--- Documentation/mm/damon/design.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/mm/damon/design.rst +2 -1
@@ -874,7 +874,8 @@ the action to the region will fail. Unlike normal stats, ``max_nr_snapshots`` is set by users. If it is set as non-zero and ``nr_snapshots`` be same to or greater than ``nr_snapshots``, the -scheme is deactivated. +scheme is deactivated. Note that, unlike watermarks, even if a scheme's +``nr_snapshots`` reaches ``max_nr_snapshots``, monitoring will not stop. To know how user-space can read the stats via :ref:`DAMON sysfs interface <sysfs_interface>`, refer to :ref:s`stats <sysfs_stats>` part of the
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [PATCH v3 2/3] docs/mm/damon/design: difference between watermarks and nr_snapshots
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 8 lines
From: Liew Rui Yan <[email protected]>
Explain the difference between
nr_snapshotsreachesmax_nr_snapshotsand watermarks.Signed-off-by Liew Rui Yan <[email protected]>Reviewed-by SJ Park <[email protected]>Signed-off-by SJ Park <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
SJ Park
maintainerPATCH v3 3/3 docs/mm/damon/design: fix typo of max_nr_snapshots
In reply to SJ ParkFrom: Liew Rui Yan <[email protected]>
Fixes a typo (nr_snapshots -> max_nr_snapshots) and corrects a grammar error.
--- Documentation/mm/damon/design.rst | 4 ++-- include/linux/damon.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
Documentation/mm/damon/design.rst +2 -2
@@ -873,8 +873,8 @@ action is ``pageout`` while all pages of the region are unreclaimable, applying the action to the region will fail. Unlike normal stats, ``max_nr_snapshots`` is set by users. If it is set as -non-zero and ``nr_snapshots`` be same to or greater than ``nr_snapshots``, the -scheme is deactivated. Note that, unlike watermarks, even if a scheme's +non-zero and ``nr_snapshots`` equals or is greater than ``max_nr_snapshots``, +the scheme is deactivated. Note that, unlike watermarks, even if a scheme's ``nr_snapshots`` reaches ``max_nr_snapshots``, monitoring will not stop. To know how user-space can read the stats via :ref:`DAMON sysfs interface
include/linux/damon.h +1 -1
@@ -551,7 +551,7 @@ struct damos_migrate_dests {* * After applying the &action to each region, &stat is updated. * -* If &max_nr_snapshots is set as non-zero and &stat.nr_snapshots be same to or +* If &max_nr_snapshots is set as non-zero and &stat.nr_snapshots equals or is * greater than it, the scheme is deactivated. */ struct damos {
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [PATCH v3 3/3] docs/mm/damon/design: fix typo of max_nr_snapshots
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 8 lines
From: Liew Rui Yan <[email protected]>
Fixes a typo (
nr_snapshots->max_nr_snapshots) and corrects a grammar error.Signed-off-by Liew Rui Yan <[email protected]>Reviewed-by SJ Park <[email protected]>Signed-off-by SJ Park <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3