Skip to contentSkip to conversation

wifi: ar5523: reject negative reply lengths

PATCH New Weiming Shi 1 participant 1 message Aug 31

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wifi: ar5523: reject negative reply lengths

The reply length is supplied by the USB device as a 32-bit unsigned integer, but ar5523_read_reply() stores it in an int. Values with bit 31 set become negative and bypass the existing signed upper-bound check. memcpy() then converts the value to size_t and overruns the command's small stack output buffer.

  BUG: KASAN: out-of-bounds in ar5523_cmd_rx_cb
  Read of size 18446744071562067968
  Call Trace:
   __asan_memcpy
   ar5523_cmd_rx_cb
   __usb_hcd_giveback_urb
   usb_hcd_giveback_urb
   dummy_timer
  Kernel panic - not syncing: Fatal exception in interrupt

Reject negative lengths through the existing overflow error path.

Fixes b7d572e1871d ("ar5523: Add new driver")
Reported-by [email protected]
Assisted-by Claude:gpt-5
---
 drivers/net/wireless/ath/ar5523/ar5523.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ar5523/ar5523.c +1 -1
index 66ac396858a5..176e5de6a64e 100644
@@ -73,7 +73,7 @@ static void ar5523_read_reply(struct ar5523 *ar, struct ar5523_cmd_hdr *hdr,
 		olen = 0;
 
 	if (cmd->odata) {
-		if (cmd->olen < olen) {
+		if (olen < 0 || cmd->olen < olen) {
 			ar5523_err(ar, "olen too small %d < %d\n",
 				   cmd->olen, olen);
 			cmd->olen = 0;
Signature · 1 line
2.55.0