thermal: of: Match trip property helper types
PATCH RESEND 1/1 thermal: of: Match trip property helper types
The thermal-zone binding defines "temperature" as a signed int32 value and "hysteresis" as an unsigned int32 value. Using helpers with matching types avoids dt_property_check mismatches and preserves the signed interpretation needed for trips below zero.
Read "temperature" with the signed helper and keep "hysteresis" on the unsigned helper using separate typed temporaries before storing them in the trip structure.
--- drivers/thermal/thermal_of.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/thermal/thermal_of.c +6 -5
@@ -63,22 +63,23 @@ static int thermal_of_get_trip_type(struct device_node *np,static int thermal_of_populate_trip (struct device_node *np,struct thermal_trip *trip) { -int prop; +u32 hysteresis; +s32 temperature;int ret; - ret =of_property_read_u32 (np,"temperature" , &prop); + ret =of_property_read_s32 (np,"temperature" , &temperature);if (ret <0 ) {pr_err ("missing temperature property\n" );return ret; } - trip->temperature = prop; + trip->temperature = temperature; - ret =of_property_read_u32 (np,"hysteresis" , &prop); + ret =of_property_read_u32 (np,"hysteresis" , &hysteresis);if (ret <0 ) {pr_err ("missing hysteresis property\n" );return ret; } - trip->hysteresis = prop; + trip->hysteresis = hysteresis; ret =thermal_of_get_trip_type (np, &trip->type);if (ret <0 ) {
Signature · 1 line
2.53.0
Hi Rob,
Quoted 9 lines · Rob Herring (Arm)
The thermal-zone binding defines "temperature" as a signed int32 value and "hysteresis" as an unsigned int32 value. Using helpers with matching types avoids
dt_property_checkmismatches and preserves the signed interpretation needed for trips below zero.Read "temperature" with the signed helper and keep "hysteresis" on the unsigned helper using separate typed temporaries before storing them in the trip structure.
Quoted 6 lines
Assisted-by Codex:gpt-5-5Signed-off-by Rob Herring (Arm) <[email protected]>--- drivers/thermal/thermal_of.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
I can see you've missed my previous tag, here it is:
Quoted 21 lines · Lukasz Luba
Hi Rob,
Quoted 9 lines · Rob Herring (Arm)
The thermal-zone binding defines "temperature" as a signed int32 value and "hysteresis" as an unsigned int32 value. Using helpers with matching types avoids
dt_property_checkmismatches and preserves the signed interpretation needed for trips below zero.Read "temperature" with the signed helper and keep "hysteresis" on the unsigned helper using separate typed temporaries before storing them in the trip structure.
Quoted 6 lines
Assisted-by Codex:gpt-5-5Signed-off-by Rob Herring (Arm) <[email protected]>--- drivers/thermal/thermal_of.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
Quoted 3 lines
I can see you've missed my previous tag, here it is:
Reviewed-by Lukasz Luba <[email protected]>
Applied as 7.4 material, thanks!