Skip to contentSkip to conversation

ARM: dts: helios4: add #phy-cells to USB nop phys

PATCH In review Rosen Penev 2 participants 2 messages Aug 31 – Sep 30

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: helios4: add #phy-cells to USB nop phys

The usb-nop-xceiv binding requires a #phy-cells property; without it dtbs_check reports:

usb2-phy: '#phy-cells' is a required property (usb-nop-xceiv)
usb3-phy: '#phy-cells' is a required property (usb-nop-xceiv)

Add #phy-cells = <0> to both nodes. No functional change.

Assisted-by opencode:big-pickle
---
 arch/arm/boot/dts/marvell/armada-388-helios4.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/marvell/armada-388-helios4.dts +2 -0
index e63b8b5e632d..548fb92ca811 100644
@@ -141,10 +141,12 @@ fan2: j17-pwm {
 	usb2_phy: usb2-phy {
 		compatible = "usb-nop-xceiv";
 		vbus-supply = <&reg_5p0v_usb>;
+		#phy-cells = <0>;
 	};
 
 	usb3_phy: usb3-phy {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 	};
 
 	soc {
Signature · 1 line
2.55.0
maintainer
#1 lore raw
Quoted 10 lines · Rosen Penev

The usb-nop-xceiv binding requires a #phy-cells property; without it dtbs_check reports:

usb2-phy: '#phy-cells' is a required property (usb-nop-xceiv)
usb3-phy: '#phy-cells' is a required property (usb-nop-xceiv)

Add #phy-cells = <0> to both nodes. No functional change.

Assisted-by opencode:big-pickle

Applied on mvebu/dt

Thanks,

Gregory

Quoted 24 lines
---
 arch/arm/boot/dts/marvell/armada-388-helios4.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/marvell/armada-388-helios4.dts +2 -0
index e63b8b5e632d..548fb92ca811 100644
@@ -141,10 +141,12 @@ fan2: j17-pwm {
 	usb2_phy: usb2-phy {
 		compatible = "usb-nop-xceiv";
 		vbus-supply = <&reg_5p0v_usb>;
+		#phy-cells = <0>;
 	};
 
 	usb3_phy: usb3-phy {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 	};
 
 	soc {
Signature · 1 line
2.55.0
Signature · 3 lines
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com