dt-bindings: hwmon: tmp102: Fix up TMP103 bindings
Subsystems (2)
PATCH v3 1/2 dt-bindings: hwmon: tmp102: Fix up TMP103 bindings
The TMP102 and TMP110 are backward compatible, therefore the valid compatible strings are "ti,tmp110", "ti,tmp102" and "ti,tmp102" .
The TMP103 is not backward compatible with TMP102, but it does share a schema now, therefore the only valid compatible string for the TMP103 should be "ti,tmp103" .
Make exactly those three compatible strings valid and everything else rejected.
---
Cc: Conor Dooley <[email protected]>
Cc: Flaviu Nistor <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V3: New patch
--- Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml +3 -4
@@ -13,11 +13,10 @@ properties: compatible: oneOf: - items: - - const: ti,tmp102 - - const: ti,tmp103 - const: ti,tmp110 - - enum: - - ti,tmp102 + - const: ti,tmp102 + - const: ti,tmp102 + - const: ti,tmp103 interrupts: maxItems: 1
Signature · 1 line
2.53.0
PATCH v3 2/2 dt-bindings: hwmon: tmp102: Document TMP113
The TMP113 temperature sensor part is register compatible with TMP102, document it using a fallback compatible. Unlike TMP102 and TMP110, the TMP113 does have additional unique ID registers, it is up to the driver to handle those.
---
Cc: Conor Dooley <[email protected]>
Cc: Flaviu Nistor <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: Rebase on current next and resend, resolve a conflict with commit
d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml") Note that the TMP102,110,113 are backward compatible, therefore the valid compatible strings are:
- "ti,tmp110", "ti,tmp102"
- "ti,tmp113", "ti,tmp102"
- "ti,tmp102"
The TMP103 is not backward compatible, it only shares bindings now, therefore the only valid compatible string for the TMP103 should be:
- "ti,tmp103"
And that is all, no other compatible strings are acceptable here.
V3: Rebase on top of 1/2 dt-bindings: hwmon: tmp102: Fix up TMP103 bindings
--- Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml +4 -2
@@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: TMP102/TMP103/TMP110 temperature sensor +title: TMP102/TMP103/TMP110/TMP113 temperature sensor maintainers: - Krzysztof Kozlowski <[email protected]>
@@ -13,7 +13,9 @@ properties: compatible: oneOf: - items: - - const: ti,tmp110 + - enum: + - ti,tmp110 + - ti,tmp113 - const: ti,tmp102 - const: ti,tmp102 - const: ti,tmp103
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines
The TMP113 temperature sensor part is register compatible with TMP102, document it using a fallback compatible. Unlike TMP102 and TMP110, the TMP113 does have additional unique ID registers, it is up to the driver to handle those.
Signed-off-by Marek Vasut <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
Re: [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113
In reply to Marek VasutQuoted 6 lines · Marek Vasut
The TMP113 temperature sensor part is register compatible with TMP102, document it using a fallback compatible. Unlike TMP102 and TMP110, the TMP113 does have additional unique ID registers, it is up to the driver to handle those.
Signed-off-by Marek Vasut <[email protected]>
pw-bot: not-applicable
Quoted 53 lines
---
Cc: Conor Dooley <[email protected]>
Cc: Flaviu Nistor <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: Rebase on current next and resend, resolve a conflict with commit
d67ec24d3f07("dt-bindings: hwmon: tmp102: move ti,tmp103 out oftrivial-devices.yaml") Note that the TMP102,110,113 are backward compatible, therefore the valid compatible strings are:
- "ti,tmp110", "ti,tmp102"
- "ti,tmp113", "ti,tmp102"
- "ti,tmp102"
The TMP103 is not backward compatible, it only shares bindings now, therefore the only valid compatible string for the TMP103 should be:
- "ti,tmp103"
And that is all, no other compatible strings are acceptable here.
V3: Rebase on top of 1/2 dt-bindings: hwmon: tmp102: Fix up TMP103 bindings--- Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml +4
-2@@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: TMP102/TMP103/TMP110 temperature sensor +title: TMP102/TMP103/TMP110/TMP113 temperature sensor maintainers: - Krzysztof Kozlowski <[email protected]>@@ -13,7 +13,9 @@ properties: compatible: oneOf: - items: - - const: ti,tmp110 + - enum: + - ti,tmp110 + - ti,tmp113 - const: ti,tmp102 - const: ti,tmp102 - const: ti,tmp103Signature · 1 line
2.53.0
Re: [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113
In reply to Marek VasutQuoted 7 lines · Marek Vasut
The TMP113 temperature sensor part is register compatible with TMP102, document it using a fallback compatible. Unlike TMP102 and TMP110, the TMP113 does have additional unique ID registers, it is up to the driver to handle those.
Signed-off-by Marek Vasut <[email protected]>Acked-by Conor Dooley <[email protected]>
Applied.
Thanks,
Guenter
[email protected]
AI reviewSashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines
The TMP102 and TMP110 are backward compatible, therefore the valid compatible strings are "ti,tmp110", "ti,tmp102" and "ti,tmp102" .
The TMP103 is not backward compatible with TMP102, but it does share a schema now, therefore the only valid compatible string for the TMP103 should be "ti,tmp103" .
Quoted 5 lines
Make exactly those three compatible strings valid and everything else rejected.
Fixes d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")Signed-off-by Marek Vasut <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 7 lines · Marek Vasut
The TMP102 and TMP110 are backward compatible, therefore the valid compatible strings are "ti,tmp110", "ti,tmp102" and "ti,tmp102" .
The TMP103 is not backward compatible with TMP102, but it does share a schema now, therefore the only valid compatible string for the TMP103 should be "ti,tmp103" .
Quoted 5 lines
Make exactly those three compatible strings valid and everything else rejected.
Fixes d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")Signed-off-by Marek Vasut <[email protected]>
(I am just realising now that the reason for this was the binding in-tree having been cocked up)
Quoted 37 lines
---
Cc: Conor Dooley <[email protected]>
Cc: Flaviu Nistor <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V3: New patch--- Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml +3
-4@@ -13,11 +13,10 @@ properties: compatible: oneOf: - items: - - const: ti,tmp102 - - const: ti,tmp103 - const: ti,tmp110 - - enum: - - ti,tmp102 + - const: ti,tmp102 + - const: ti,tmp102 + - const: ti,tmp103 interrupts: maxItems: 1Signature · 1 line
2.53.0
Guenter Roeck
maintainerQuoted 7 lines · Marek Vasut
The TMP102 and TMP110 are backward compatible, therefore the valid compatible strings are "ti,tmp110", "ti,tmp102" and "ti,tmp102" .
The TMP103 is not backward compatible with TMP102, but it does share a schema now, therefore the only valid compatible string for the TMP103 should be "ti,tmp103" .
Quoted 6 lines
Make exactly those three compatible strings valid and everything else rejected.
Fixes d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")Signed-off-by Marek Vasut <[email protected]>Acked-by Conor Dooley <[email protected]>
Applied (I'll squash it with d67ec24d3f07).
Thanks,
Guenter
Quoted 8 lines · Guenter Roeck
Quoted 7 lines · Marek Vasut
The TMP102 and TMP110 are backward compatible, therefore the valid compatible strings are "ti,tmp110", "ti,tmp102" and "ti,tmp102" .
The TMP103 is not backward compatible with TMP102, but it does share a schema now, therefore the only valid compatible string for the TMP103 should be "ti,tmp103" .
Quoted 8 lines
Quoted 6 lines
Make exactly those three compatible strings valid and everything else rejected.
Fixes d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")Signed-off-by Marek Vasut <[email protected]>Acked-by Conor Dooley <[email protected]>Applied (I'll squash it with
d67ec24d3f07).
Thank you