Skip to contentSkip to conversation

RDMA/irdma: Enforce local fence for IB_WR_REG_MR

PATCH Applied Jacob Moroni 2 participants 2 messages Sep 1 – Sep 2

Subsystems (2)
InfiniBand Intel Ethernet protocol driver for RDMA
lore
Share & tools
lore

Jacob Moroni

author
#0 lore raw

PATCH 1/1 RDMA/irdma: Enforce local fence for IB_WR_REG_MR

Enforce local fence for IB_WR_REG_MR to avoid spurious FASTREG_VALID_MKEY async events during heavy invalidation and registration activity.

Commit 69e8e429bca2 ("RDMA/irdma: Enforce local fence for LOCAL_INV WRs") was very similar, but was not sufficient to prevent all occurrences of these async events.

Fixes b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs")
Signed-off-by Jacob Moroni <[email protected]>
---
 drivers/infiniband/hw/irdma/verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/irdma/verbs.c +1 -1
index 9cfd84dd6869..5d71300da0ff 100644
@@ -4281,7 +4281,7 @@ static int irdma_post_send(struct ib_qp *ibqp,
 			stag_info.total_len = iwmr->ibmr.length;
 			stag_info.reg_addr_pa = *palloc->level1.addr;
 			stag_info.first_pm_pbl_index = palloc->level1.idx;
-			stag_info.local_fence = ib_wr->send_flags & IB_SEND_FENCE;
+			stag_info.local_fence = true;
 			if (iwmr->npages > IRDMA_MIN_PAGES_PER_FMR)
 				stag_info.chunk_size = 1;
 			err = irdma_sc_mr_fast_register(&iwqp->sc_qp, &stag_info,
Signature · 1 line
2.55.0.897.gb25b4bd76c-goog
Applied
#1 lore raw
Quoted 9 lines · Jacob Moroni

Enforce local fence for IB_WR_REG_MR to avoid spurious FASTREG_VALID_MKEY async events during heavy invalidation and registration activity.

Commit 69e8e429bca2 ("RDMA/irdma: Enforce local fence for LOCAL_INV WRs") was very similar, but was not sufficient to prevent all occurrences of these async events.

[...]

Applied, thanks!

[1/1] RDMA/irdma: Enforce local fence for IB_WR_REG_MR

      https://git.kernel.org/rdma/rdma/c/3fb905f07ea45b

Best regards,

Signature · 1 line
Leon Romanovsky <[email protected]>