staging: vc04_services: preserve bcm2835_audio_write errors
Subsystems (3)
PATCH 1/1 staging: vc04_services: preserve bcm2835_audio_write errors
When sending audio data in multiple packets, a successful later packet could overwrite an earlier failure in status. This caused the function to report success even if one packet was not queued.
Stop sending packets after the first failure to preserve the error.
Signed-off-by Lucas Jeffrey <[email protected]>
--- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c +3 -0
@@ -365,6 +365,9 @@ int bcm2835_audio_write(struct bcm2835_alsa_stream *alsa_stream, status =vchiq_queue_kernel_message (vchiq_instance, instance->service_handle, src, bytes); +if (status) +break ; + src += bytes; count -= bytes; }
Signature · 1 line
2.43.0
Greg KH
maintainerQuoted 29 lines · Lucas Jeffrey
When sending audio data in multiple packets, a successful later packet could overwrite an earlier failure in status. This caused the function to report success even if one packet was not queued.
Stop sending packets after the first failure to preserve the error.
Signed-off-by Lucas Jeffrey <[email protected]>--- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 3 +++ 1 file changed, 3 insertions(+)drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c +3
-0@@ -365,6 +365,9 @@ int bcm2835_audio_write(struct bcm2835_alsa_stream *alsa_stream, status =vchiq_queue_kernel_message (vchiq_instance, instance->service_handle, src, bytes); +if (status) +break ; + src += bytes; count -= bytes; }Signature · 1 line
2.43.0
Was this tested on the real hardware?
thanks,
greg k-h