Skip to contentSkip to conversation

staging: greybus: loopback: Fix argument alignment

PATCH In review Noah Techoueyres 2 participants 2 messages Aug 3 – Sep 1

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: greybus: loopback: Fix argument alignment

Align function arguments to match the open parenthesis per the kernel coding style guidelines.

---
 drivers/staging/greybus/loopback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/loopback.c +1 -1
index ea57b1f5d156..c33b8aa5871c 100644
@@ -679,7 +679,7 @@ static int gb_loopback_request_handler(struct gb_operation *operation)
 		}
 
 		if (!gb_operation_response_alloc(operation,
-				len + sizeof(*response), GFP_KERNEL)) {
+						 len + sizeof(*response), GFP_KERNEL)) {
 			dev_err(dev, "error allocating response\n");
 			return -ENOMEM;
 		}
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 13 lines · Noah Techoueyres

Align function arguments to match the open parenthesis per the kernel coding style guidelines.

---
 drivers/staging/greybus/loopback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/loopback.c +0 -0
index ea57b1f5d156..c33b8aa5871c 100644

drivers/staging/greybus/loopback.c static int gb_loopback_request_handler(struct gb_operation *operation) · line 682

Quoted 5 lines
drivers/staging/greybus/loopback.c +1 -1
@@ -679,7 +679,7 @@ static int gb_loopback_request_handler(struct gb_operation *operation)
 		}
 
 		if (!gb_operation_response_alloc(operation,
-				len + sizeof(*response), GFP_KERNEL)) {
+						 len + sizeof(*response), GFP_KERNEL)) {

Now you are over 80 columns, this keeps going back and forth. It's fine as-is.

thanks,

greg k-h