Skip to contentSkip to conversation

syscalls/ioctl03: add IFF_BACKPRESSURE flag

PATCH Applied Avinesh Kumar via ltp 2 participants 4 messages Sep 2 – Sep 3

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 syscalls/ioctl03: add IFF_BACKPRESSURE flag

From: Avinesh Kumar <[email protected]>

Kernel commit 485e38995cc3 ("tun/tap: add IFF_BACKPRESSURE flag") introduced a new TUNSETIFF flag, and d00c7369ef24 ("tun/tap &
vhost-net: stop tail-drop when IFF_BACKPRESSURE is set") added it to TUN_FEATURES. TUNGETFEATURES now reports bit 0x80 on kernels that support it, which ioctl03 does not recognize and reports as:

ioctl03.c:90: TFAIL: (UNKNOWN 0x80)

Add IFF_BACKPRESSURE to the known flags table.

---
 testcases/kernel/syscalls/ioctl/ioctl03.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
testcases/kernel/syscalls/ioctl/ioctl03.c +6 -1
index 8a868a98e605..1f538016344c 100644
@@ -44,6 +44,10 @@
 #define IFF_NO_CARRIER	0x0040
 #endif
 
+#ifndef IFF_BACKPRESSURE
+#define IFF_BACKPRESSURE	0x0080
+#endif
+
 static struct {
 	unsigned int flag;
 	const char *name;
@@ -56,7 +60,8 @@ static struct {
 	{IFF_MULTI_QUEUE, "MULTI_QUEUE"},
 	{IFF_NAPI, "IFF_NAPI"},
 	{IFF_NAPI_FRAGS, "IFF_NAPI_FRAGS"},
-	{IFF_NO_CARRIER, "IFF_NO_CARRIER"}
+	{IFF_NO_CARRIER, "IFF_NO_CARRIER"},
+	{IFF_BACKPRESSURE, "IFF_BACKPRESSURE"}
 };
 
 static void verify_features(void)
Signature · 5 lines
2.55.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Avinesh,

Quoted 1 line · Avinesh Kumar

syscalls/ioctl03: add IFF_BACKPRESSURE flag

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp