selftests/mm: remove unreachable returns after ksft exit helpers
Subsystems (4)
PATCH 1/1 selftests/mm: remove unreachable returns after ksft exit helpers
From: "Zenghui Yu (Huawei)" <[email protected]>
The ksft_exit*() helpers such as ksft_exit_fail_msg() are declared __noreturn, and the ksft_exit() and ksft_finished() macros expand to calls of them, always terminating the process via exit(). Any return statements following such calls are unreachable, both at the end of main() and on error paths of helper functions.
Remove all of them. No functional change.
--- tools/testing/selftests/mm/folio_split_race_test.c | 2 -- tools/testing/selftests/mm/mlock-random-test.c | 1 - tools/testing/selftests/mm/pkey_sighandler_tests.c | 1 - tools/testing/selftests/mm/split_huge_page_test.c | 4 ---- 4 files changed, 8 deletions(-)
tools/testing/selftests/mm/folio_split_race_test.c +0 -2
@@ -269,6 +269,4 @@ int main(void) NUM_ITERATIONS);ksft_exit (iter ==NUM_ITERATIONS ); - -return 0 ; }
tools/testing/selftests/mm/mlock-random-test.c +0 -1
@@ -71,7 +71,6 @@ int get_proc_locked_vm_size(void)fclose (f);ksft_exit_fail_msg ("cannot parse VmLck in /proc/self/status: %s\n" ,strerror (errno)); -return -1 ; }/*
tools/testing/selftests/mm/pkey_sighandler_tests.c +0 -1
@@ -556,5 +556,4 @@ int main(int argc, char *argv[]) }ksft_finished (); -return 0 ; }
tools/testing/selftests/mm/split_huge_page_test.c +0 -4
@@ -101,7 +101,6 @@ static bool is_backed_by_folio(char *vaddr, int order, int pagemap_fd,return (pfn_flags & folio_tail_flags) != folio_tail_flags; fail:ksft_exit_fail_msg ("Failed to get folio info\n" ); -return false; } static int check_after_split_folio_orders(char *vaddr_start, size_t len,
@@ -548,7 +547,6 @@ static int create_pagecache_thp_and_fd(const char *testfile, size_t fd_size, err_out_unlink:unlink (testfile);ksft_exit_fail_msg ("Failed to create large pagecache folios\n" ); -return -1 ; } static void split_thp_in_pagecache_to_order_at(size_t fd_size,
@@ -711,6 +709,4 @@ int main(int argc, char **argv)free (expected_orders);ksft_finished (); - -return 0 ; }
Signature · 1 line
2.53.0
Quoted 11 lines · Zenghui Yu
From: "Zenghui Yu (Huawei)" <[email protected]>
The ksft_exit*() helpers such as
ksft_exit_fail_msg()are declared__noreturn, and theksft_exit()andksft_finished()macros expand to calls of them, always terminating the process viaexit(). Any return statements following such calls are unreachable, both at the end ofmain()and on error paths of helper functions.Remove all of them. No functional change.
Assisted-by GLM-5.3 OpenCode
Thanks for providing the tag, much appreciated :)
Quoted 1 line
Signed-off-by Zenghui Yu (Huawei) <[email protected]>
LGTM, so:
Quoted 68 lines
--- tools/testing/selftests/mm/folio_split_race_test.c | 2 -- tools/testing/selftests/mm/mlock-random-test.c | 1 - tools/testing/selftests/mm/pkey_sighandler_tests.c | 1 - tools/testing/selftests/mm/split_huge_page_test.c | 4 ---- 4 files changed, 8 deletions(-)tools/testing/selftests/mm/folio_split_race_test.c +0
-2@@ -269,6 +269,4 @@ int main(void) NUM_ITERATIONS);ksft_exit (iter ==NUM_ITERATIONS ); - -return 0 ; }tools/testing/selftests/mm/mlock-random-test.c +0
-1@@ -71,7 +71,6 @@ int get_proc_locked_vm_size(void)fclose (f);ksft_exit_fail_msg ("cannot parse VmLck in /proc/self/status: %s\n" ,strerror (errno)); -return -1 ; }/* tools/testing/selftests/mm/pkey_sighandler_tests.c +0
-1@@ -556,5 +556,4 @@ int main(int argc, char *argv[]) }ksft_finished (); -return 0 ; }tools/testing/selftests/mm/split_huge_page_test.c +0
-5@@ -101,7 +101,6 @@ static bool is_backed_by_folio(char *vaddr, int order, int pagemap_fd,return (pfn_flags & folio_tail_flags) != folio_tail_flags; fail:ksft_exit_fail_msg ("Failed to get folio info\n" ); -return false; } static int check_after_split_folio_orders(char *vaddr_start, size_t len,@@ -548,7 +547,6 @@ static int create_pagecache_thp_and_fd(const char *testfile, size_t fd_size, err_out_unlink:unlink (testfile);ksft_exit_fail_msg ("Failed to create large pagecache folios\n" ); -return -1 ; } static void split_thp_in_pagecache_to_order_at(size_t fd_size,@@ -711,6 +709,4 @@ int main(int argc, char **argv)free (expected_orders);ksft_finished (); - -return 0 ; } --
Quoted 2 lines
2.53.0
--
Cheers, Lorenzo
'get_maintainer.pl --nogit --nogit-fallback' on mm-new suggests adding Kiryl. I added him.
- Kiryl Shutsemau <[email protected]>
Quoted 9 lines · On Thu, 3 Sep 2026 21:52:51 +0800 Zenghui Yu <[email protected]> wrote:
From: "Zenghui Yu (Huawei)" <[email protected]>
The ksft_exit*() helpers such as
ksft_exit_fail_msg()are declared__noreturn, and theksft_exit()andksft_finished()macros expand to calls of them, always terminating the process viaexit(). Any return statements following such calls are unreachable, both at the end ofmain()and on error paths of helper functions.Remove all of them. No functional change.
Makes sense and looks correct to me :)
Quoted 3 lines
Assisted-by GLM-5.3 OpenCodeSigned-off-by Zenghui Yu (Huawei) <[email protected]>
Thanks,
SJ
[...]
Quoted 10 lines · Zenghui Yu
From: "Zenghui Yu (Huawei)" <[email protected]>
The ksft_exit*() helpers such as
ksft_exit_fail_msg()are declared__noreturn, and theksft_exit()andksft_finished()macros expand to calls of them, always terminating the process viaexit(). Any return statements following such calls are unreachable, both at the end ofmain()and on error paths of helper functions.Remove all of them. No functional change.
Quoted 9 lines
Assisted-by GLM-5.3 OpenCodeSigned-off-by Zenghui Yu (Huawei) <[email protected]>--- tools/testing/selftests/mm/folio_split_race_test.c | 2 -- tools/testing/selftests/mm/mlock-random-test.c | 1 - tools/testing/selftests/mm/pkey_sighandler_tests.c | 1 - tools/testing/selftests/mm/split_huge_page_test.c | 4 ---- 4 files changed, 8 deletions(-)
Signature · 2 lines
Best Regards, Yan, Zi