Skip to contentSkip to conversation

package/qt6/qt6declarative: move comment where it belongs

PATCH Applied Thomas Petazzoni via buildroot 1 participant 6 messages Aug 26 – Sep 4

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/qt6/qt6declarative: move comment where it belongs

The commit "Enable host test module to ensure that qmltestrunner is built" in qt6declarative's Config.in feels lonely under BR2_PACKAGE_QT6DECLARATIVE. It's because it's actually related to a select done in the sub-option BR2_PACKAGE_QT6DECLARATIVE_QUICK, so move it there.

---
 package/qt6/qt6declarative/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/qt6/qt6declarative/Config.in +1 -1
index 0a977ed808..a57b203071 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_QT6DECLARATIVE
 	bool "qt6declarative"
-	# Enable host test module to ensure that qmltestrunner is built
 	help
 	  Qt is a cross-platform application and UI framework for
 	  developers using C++.
@@ -13,6 +12,7 @@ if BR2_PACKAGE_QT6DECLARATIVE
 
 config BR2_PACKAGE_QT6DECLARATIVE_QUICK
 	bool "quick module"
+	# Enable host test module to ensure that qmltestrunner is built
 	select BR2_PACKAGE_HOST_QT6BASE_TEST if BR2_PACKAGE_QT6BASE_TEST # qmltestrunner
 	select BR2_PACKAGE_HOST_QT6BASE_NETWORK if BR2_PACKAGE_QT6BASE_NETWORK # qmlprofiler
 	select BR2_PACKAGE_QT6BASE_GUI
Signature · 6 lines
2.55.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/2 package/qt6/qt6declarative: fix select of host-qt6base network

The BR2_PACKAGE_QT6DECLARATIVE_QUICK option has some logic to select network support in host-qt6base if network support is enabled in qt6base. However, it turns out that this is actually required at the top level BR2_PACKAGE_QT6DECLARATIVE option: as soon as network support is available in qt6base, the qt6declarative build will assume that qmlprofiler is available... but that requires network support in host-qt6base.

This fixes the following build failure:

CMake Error at /home/thomas/autobuild/instance-2/output-1/build/qt6base-6.9.1/cmake/QtToolHelpers.cmake:784 (message):
Failed to find the host tool "Qt6::qmlprofiler". It is part of the
Qt6QmlTools package, but the package did not contain the tool. Make sure
that the host module Qml was built with all features enabled (no explicitly
disabled tools).
Call Stack (most recent call first):
/home/thomas/autobuild/instance-2/output-1/build/qt6base-6.9.1/cmake/QtToolHelpers.cmake:83 (qt_internal_find_tool) tools/qmlprofiler/CMakeLists.txt:11 (qt_internal_add_tool)

Fixes:

https://autobuild.buildroot.net/results/72c956fdf982382d2981c649c456d1edc2c9d6b2/

We did not trace back exactly since when the problem exists, but we verified that the problem exists in 2025.02.x. It can be reproduced with the following defconfig:

BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_AARCH64_GLIBC_STABLE=y BR2_PACKAGE_QT6=y BR2_PACKAGE_QT6BASE_NETWORK=y BR2_PACKAGE_QT6DECLARATIVE=y

---
 package/qt6/qt6declarative/Config.in | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/qt6/qt6declarative/Config.in +4 -1
index a57b203071..e24133c3e5 100644
@@ -1,5 +1,9 @@
 config BR2_PACKAGE_QT6DECLARATIVE
 	bool "qt6declarative"
+	# When target qt6base has network support, qt6declarative
+	# assumes that qmlprofiler is available, but that requires
+	# network support in host-qt6base.
+	select BR2_PACKAGE_HOST_QT6BASE_NETWORK if BR2_PACKAGE_QT6BASE_NETWORK # qmlprofiler
 	help
 	  Qt is a cross-platform application and UI framework for
 	  developers using C++.
@@ -14,7 +18,6 @@ config BR2_PACKAGE_QT6DECLARATIVE_QUICK
 	bool "quick module"
 	# Enable host test module to ensure that qmltestrunner is built
 	select BR2_PACKAGE_HOST_QT6BASE_TEST if BR2_PACKAGE_QT6BASE_TEST # qmltestrunner
-	select BR2_PACKAGE_HOST_QT6BASE_NETWORK if BR2_PACKAGE_QT6BASE_NETWORK # qmlprofiler
 	select BR2_PACKAGE_QT6BASE_GUI
 	select BR2_PACKAGE_QT6BASE_OPENGL if BR2_PACKAGE_QT6_GL_SUPPORTS
 	select BR2_PACKAGE_QT6SHADERTOOLS
Signature · 6 lines
2.55.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH 2/2] package/qt6/qt6declarative: fix select of host-qt6base network

In reply of:

Quoted 35 lines

The BR2_PACKAGE_QT6DECLARATIVE_QUICK option has some logic to select network support in host-qt6base if network support is enabled in qt6base. However, it turns out that this is actually required at the top level BR2_PACKAGE_QT6DECLARATIVE option: as soon as network support is available in qt6base, the qt6declarative build will assume that qmlprofiler is available... but that requires network support in host-qt6base.

This fixes the following build failure:

CMake Error at /home/thomas/autobuild/instance-2/output-1/build/qt6base-6.9.1/cmake/QtToolHelpers.cmake:784 (message):
Failed to find the host tool "Qt6::qmlprofiler". It is part of the
Qt6QmlTools package, but the package did not contain the tool. Make sure
that the host module Qml was built with all features enabled (no explicitly
disabled tools).
Call Stack (most recent call first):
/home/thomas/autobuild/instance-2/output-1/build/qt6base-6.9.1/cmake/QtToolHelpers.cmake:83 (qt_internal_find_tool) tools/qmlprofiler/CMakeLists.txt:11 (qt_internal_add_tool)

Fixes:

https://autobuild.buildroot.net/results/72c956fdf982382d2981c649c456d1edc2c9d6b2/

We did not trace back exactly since when the problem exists, but we verified that the problem exists in 2025.02.x. It can be reproduced with the following defconfig:

BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_AARCH64_GLIBC_STABLE=y BR2_PACKAGE_QT6=y BR2_PACKAGE_QT6BASE_NETWORK=y BR2_PACKAGE_QT6DECLARATIVE=y

Quoted 1 line

Applied to 2025.02.x & 2026.05.x. Thanks

Quoted 33 lines
---
 package/qt6/qt6declarative/Config.in | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/qt6/qt6declarative/Config.in +4 -1
index a57b203071..e24133c3e5 100644
@@ -1,5 +1,9 @@
 config BR2_PACKAGE_QT6DECLARATIVE
 	bool "qt6declarative"
+	# When target qt6base has network support, qt6declarative
+	# assumes that qmlprofiler is available, but that requires
+	# network support in host-qt6base.
+	select BR2_PACKAGE_HOST_QT6BASE_NETWORK if BR2_PACKAGE_QT6BASE_NETWORK # qmlprofiler
 	help
 	  Qt is a cross-platform application and UI framework for
 	  developers using C++.
@@ -14,7 +18,6 @@ config BR2_PACKAGE_QT6DECLARATIVE_QUICK
 	bool "quick module"
 	# Enable host test module to ensure that qmltestrunner is built
 	select BR2_PACKAGE_HOST_QT6BASE_TEST if BR2_PACKAGE_QT6BASE_TEST # qmltestrunner
-	select BR2_PACKAGE_HOST_QT6BASE_NETWORK if BR2_PACKAGE_QT6BASE_NETWORK # qmlprofiler
 	select BR2_PACKAGE_QT6BASE_GUI
 	select BR2_PACKAGE_QT6BASE_OPENGL if BR2_PACKAGE_QT6_GL_SUPPORTS
 	select BR2_PACKAGE_QT6SHADERTOOLS
Signature · 6 lines
2.55.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
In reply to Thomas Petazzoni via buildroot

Hello Thomas, all,

Quoted 1 line · Thomas Petazzoni

The commit "Enable host test module to ensure that qmltestrunner is

s/commit/comment/

Regards,

Edgar.

Quoted 22 lines

built" in qt6declarative's Config.in feels lonely under BR2_PACKAGE_QT6DECLARATIVE. It's because it's actually related to a select done in the sub-option BR2_PACKAGE_QT6DECLARATIVE_QUICK, so move it there.

---
 package/qt6/qt6declarative/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/qt6/qt6declarative/Config.in +0 -1
index 0a977ed808..a57b203071 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_QT6DECLARATIVE
 	bool "qt6declarative"
-	# Enable host test module to ensure that qmltestrunner is built
 	help
 	  Qt is a cross-platform application and UI framework for
 	  developers using C++.

package/qt6/qt6declarative/Config.in if BR2_PACKAGE_QT6DECLARATIVE · line 18

Quoted 7 lines
package/qt6/qt6declarative/Config.in +1 -0
@@ -13,6 +12,7 @@ if BR2_PACKAGE_QT6DECLARATIVE
 
 config BR2_PACKAGE_QT6DECLARATIVE_QUICK
 	bool "quick module"
+	# Enable host test module to ensure that qmltestrunner is built
 	select BR2_PACKAGE_HOST_QT6BASE_TEST if BR2_PACKAGE_QT6BASE_TEST # qmltestrunner
 	select BR2_PACKAGE_HOST_QT6BASE_NETWORK if BR2_PACKAGE_QT6BASE_NETWORK # qmlprofiler
 	select BR2_PACKAGE_QT6BASE_GUI

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw
In reply to Thomas Petazzoni via buildroot
Quoted 7 lines · Thomas Petazzoni via buildroot

The commit "Enable host test module to ensure that qmltestrunner is built" in qt6declarative's Config.in feels lonely under BR2_PACKAGE_QT6DECLARATIVE. It's because it's actually related to a select done in the sub-option BR2_PACKAGE_QT6DECLARATIVE_QUICK, so move it there.

Series applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#5 lore raw
In reply to Thomas Petazzoni via buildroot

In reply of:

Quoted 7 lines

The commit "Enable host test module to ensure that qmltestrunner is built" in qt6declarative's Config.in feels lonely under BR2_PACKAGE_QT6DECLARATIVE. It's because it's actually related to a select done in the sub-option BR2_PACKAGE_QT6DECLARATIVE_QUICK, so move it there.

Applied to 2025.02.x & 2026.05.x. Thanks

Quoted 30 lines
---
 package/qt6/qt6declarative/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/qt6/qt6declarative/Config.in +1 -1
index 0a977ed808..a57b203071 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_QT6DECLARATIVE
 	bool "qt6declarative"
-	# Enable host test module to ensure that qmltestrunner is built
 	help
 	  Qt is a cross-platform application and UI framework for
 	  developers using C++.
@@ -13,6 +12,7 @@ if BR2_PACKAGE_QT6DECLARATIVE
 
 config BR2_PACKAGE_QT6DECLARATIVE_QUICK
 	bool "quick module"
+	# Enable host test module to ensure that qmltestrunner is built
 	select BR2_PACKAGE_HOST_QT6BASE_TEST if BR2_PACKAGE_QT6BASE_TEST # qmltestrunner
 	select BR2_PACKAGE_HOST_QT6BASE_NETWORK if BR2_PACKAGE_QT6BASE_NETWORK # qmlprofiler
 	select BR2_PACKAGE_QT6BASE_GUI
Signature · 6 lines
2.55.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot