Skip to contentSkip to conversation

ata: fix typos and repeated words in comments

PATCH In review Hemanth Selam 3 participants 4 messages Sep 4 – Sep 5 libata

lore
Share & tools
lore
#0 lore raw

cover ata: fix typos and repeated words in comments

This corrects 2 misspellings and repeated words in comments. Each is a separate patch so that any one of them can be dropped without touching the rest.

Nothing outside comments changes. Every touched C file was checked by dropping its comments, replacing each string literal with a placeholder and collapsing whitespace; what remained was identical before and after, so the compiled code cannot differ.

The mistakes were found with scripts/checkpatch.pl against the list in scripts/spelling.txt. The scanning, the edits and the changelogs were produced with Cursor running the claude-opus-5 model, from a request to find and fix spelling mistakes across the tree, and every correction was then re-checked by the comparison described above. Words that name an identifier were left alone deliberately, even when they read as typos, because correcting the prose would make the comment disagree with the code it describes.

Tested by building x86_64 defconfig at v7.3-rc1-269-gbc35965f6940, which is clean. Nothing else was built, so any patch touching code that x86_64 defconfig does not compile has been read but not compiled.

Hemanth Selam (2):
ata: fix typos in comments
ata: fix repeated words in comments

 drivers/ata/libata-eh.c      | 2 +-
 drivers/ata/pata_amd.c       | 2 +-
 drivers/ata/sata_dwc_460ex.c | 2 +-
 drivers/ata/sata_fsl.c       | 4 ++--
 drivers/ata/sata_sil24.c     | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)
Signature · 1 line
2.48.1
#1 lore raw

PATCH 2/2 ata: fix repeated words in comments

Drop words accidentally written twice, reported by checkpatch.pl as a possible repeated word. Only touches comments, no code changes.

Assisted-by Cursor:claude-opus-5
---
 drivers/ata/libata-eh.c      | 2 +-
 drivers/ata/sata_dwc_460ex.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/ata/libata-eh.c +1 -1
index c93c24b22d9c..630e6d44190b 100644
@@ -923,7 +923,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list *t)
  *
  *	Set ATA_PFLAG_EH_PENDING and activate fast drain if @fastdrain
  *	is non-zero and EH wasn't pending before.  Fast drain ensures
- *	that EH kicks in in timely manner.
+ *	that EH kicks in timely manner.
  *
  *	LOCKING:
  *	spin_lock_irqsave(host lock)
drivers/ata/sata_dwc_460ex.c +1 -1
index 8e3fc713891a..b0c069a02cc2 100644
@@ -1071,7 +1071,7 @@ static const struct scsi_host_template sata_dwc_sht = {
 	/*
 	 * test-only: Currently this driver doesn't handle NCQ
 	 * correctly. We enable NCQ but set the queue depth to a
-	 * max of 1. This will get fixed in in a future release.
+	 * max of 1. This will get fixed in a future release.
 	 */
 	.sg_tablesize		= LIBATA_MAX_PRD,
 	/* .can_queue		= ATA_MAX_QUEUE, */
Signature · 1 line
2.48.1
#2 lore raw

Re: [PATCH 2/2] ata: fix repeated words in comments

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The patch blindly removes a valid occurrence of the word 'in', creating a grammatical error in the…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch blindly removes a valid occurrence of the word 'in', creating a grammatical error in the comment. --

commit 82b3223c0ee5c7c14e26327dc44e83c5226cc9b8
Author: Hemanth Selam <[email protected]>

ata: fix repeated words in comments

This commit drops repeated words in comments reported by checkpatch.pl. It only touches comments and makes no code changes.

drivers/ata/libata-eh.c void ata_eh_fastdrain_timerfn(struct timer_list *t) · line 926

Quoted 10 lines
drivers/ata/libata-eh.c +1 -1
index c154103d892c3..bdf25c535c07c 100644
@@ -923,7 +923,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list *t)
  *
  *	Set ATA_PFLAG_EH_PENDING and activate fast drain if @fastdrain
  *	is non-zero and EH wasn't pending before.  Fast drain ensures
- *	that EH kicks in in timely manner.
+ *	that EH kicks in timely manner.

[Severity: Low]
Does this accidentally remove a valid occurrence of the word "in"?

The original text uses "in" twice for two different grammatical purposes: the first is part of the phrasal verb "kick in", and the second is the preposition for "in [a] timely manner".

Removing the second one leaves the sentence missing a preposition.

Would it be better to change this to "EH kicks in in a timely manner" or "EH kicks in promptly" instead of just dropping the word?

[ ... ]

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
maintainer
#3 lore raw

Re: [PATCH 2/2] ata: fix repeated words in comments

In reply to Hemanth Selam
Quoted 15 lines · Hemanth Selam

Drop words accidentally written twice, reported by checkpatch.pl as a possible repeated word. Only touches comments, no code changes.

Assisted-by Cursor:claude-opus-5
---
 drivers/ata/libata-eh.c      | 2 +-
 drivers/ata/sata_dwc_460ex.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/ata/libata-eh.c +0 -0
index c93c24b22d9c..630e6d44190b 100644

drivers/ata/libata-eh.c void ata_eh_fastdrain_timerfn(struct timer_list *t) · line 926

Quoted 5 lines
drivers/ata/libata-eh.c +1 -1
@@ -923,7 +923,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list *t)
  *
  *	Set ATA_PFLAG_EH_PENDING and activate fast drain if @fastdrain
  *	is non-zero and EH wasn't pending before.  Fast drain ensures
- *	that EH kicks in in timely manner.
+ *	that EH kicks in timely manner.

Sashiko is correct here. This is the wrong fix. This should read:

"that EH kicks in in a timely manner."

In any case, this is all very minor and I prefer that we do not apply this patch to avoid churn and backport issues and rather get these typos fixed when the code around them changes.

Quoted 16 lines
drivers/ata/libata-eh.c +0 -0
  *
  *	LOCKING:
  *	spin_lock_irqsave(host lock)
drivers/ata/sata_dwc_460ex.c +1 -1
index 8e3fc713891a..b0c069a02cc2 100644
@@ -1071,7 +1071,7 @@ static const struct scsi_host_template sata_dwc_sht = {
 	/*
 	 * test-only: Currently this driver doesn't handle NCQ
 	 * correctly. We enable NCQ but set the queue depth to a
-	 * max of 1. This will get fixed in in a future release.
+	 * max of 1. This will get fixed in a future release.
 	 */
 	.sg_tablesize		= LIBATA_MAX_PRD,
 	/* .can_queue		= ATA_MAX_QUEUE, */
Signature · 2 lines
Damien Le Moal
Western Digital Research